Subject: Re: [PATCH v10 1/3] powerpc: Detect the presence of big-cores via "ibm,thread-groups"

From: Srikar Dronamraju <[email-masked]>
Date: Fri, 12 Oct 2018 12:28:31 +0530

> +DECLARE_PER_CPU(cpumask_var_t, cpu_smallcore_map);
> 
> +/*
> + * On big-cores system, cpu_l1_cache_map for each CPU corresponds to
> + * the set its siblings that share the L1-cache.
> + */
> +DEFINE_PER_CPU(cpumask_var_t, cpu_l1_cache_map);
> 

Nit:
Can you add a comment on how cpu_l1_cache_map differs from
cpu_smallcore_map?.

Everything else looks okay to me.