From: Christoph Hellwig <hch@infradead•org>
To: "Joel Fernandes (Google)" <joel@joelfernandes•org>
Cc: linux-mips@linux-mips•org, Rich Felker <dalias@libc•org>,
linux-ia64@vger•kernel.org, linux-sh@vger•kernel.org,
Peter Zijlstra <peterz@infradead•org>,
Catalin Marinas <catalin.marinas@arm•com>,
Dave Hansen <dave.hansen@linux•intel.com>,
Will Deacon <will.deacon@arm•com>,
mhocko@kernel•org, linux-mm@kvack•org, lokeshgidra@google•com,
sparclinux@vger•kernel.org, linux-riscv@lists•infradead.org,
kvmarm@lists•cs.columbia.edu, Jonas Bonn <jonas@southpole•se>,
linux-s390@vger•kernel.org, dancol@google•com,
Yoshinori Sato <ysato@users•sourceforge.jp>,
Max Filippov <jcmvbkbc@gmail•com>,
linux-hexagon@vger•kernel.org, Helge Deller <deller@gmx•de>,
"maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT" <x86@kernel•org>,
hughd@google•com, "James E.J. Bottomley" <jejb@parisc-linux•org>,
kasan-dev@googlegroups•com, elfring@users•sourceforge.net,
Ingo Molnar <mingo@redhat•com>,
Geert Uytterhoeven <geert@linux-m68k•org>,
Andrey Ryabinin <aryabinin@virtuozzo•com>,
linux-snps-arc@lists•infradead.org, kernel-team@android•com,
Sam Creasey <sammy@sammy•net>,
linux-xtensa@linux-xtensa•org, Jeff Dike <jdike@addtoit•com>,
linux-alpha@vger•kernel.org, linux-um@lists•infradead.org,
Stefan Kristiansson <stefan.kristiansson@saunalahti•fi>,
Julia Lawall <Julia.Lawall@lip6•fr>,
linux-m68k@lists•linux-m68k.org, Borislav Petkov <bp@alien8•de>,
Andy Lutomirski <luto@kernel•org>,
Ley Foon Tan <lftan@altera•com>,
kirill@shutemov•name, Stafford Horne <shorne@gmail•com>,
Guan Xuetao <gxt@pku•edu.cn>, Chris Zankel <chris@zankel•net>,
Tony Luck <tony.luck@intel•com>,
linux-parisc@vger•kernel.org, pantin@google•com,
linux-kernel@vger•kernel.org, Fenghua Yu <fenghua.yu@intel•com>,
minchan@kernel•org, Thomas Gleixner <tglx@linutronix•de>,
Richard Weinberger <richard@nod•at>,
anton.ivanov@kot-begemot•co.uk, nios2-dev@lists•rocketboards.org,
akpm@linux-foundation•org, linuxppc-dev@lists•ozlabs.org,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH 2/4] mm: speed up mremap by 500x on large regions (v2)
Date: Mon, 15 Oct 2018 02:42:09 -0700 [thread overview]
Message-ID: <20181015094209.GA31999@infradead.org> (raw)
In-Reply-To: <20181013013200.206928-3-joel@joelfernandes.org>
On Fri, Oct 12, 2018 at 06:31:58PM -0700, Joel Fernandes (Google) wrote:
> Android needs to mremap large regions of memory during memory management
> related operations.
Just curious: why?
> + if ((old_addr & ~PMD_MASK) || (new_addr & ~PMD_MASK)
> + || old_end - old_addr < PMD_SIZE)
The || goes on the first line.
> + } else if (extent == PMD_SIZE && IS_ENABLED(CONFIG_HAVE_MOVE_PMD)) {
Overly long line.
next prev parent reply other threads:[~2018-10-15 10:18 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 1:31 [PATCH 0/4] Add support for fast mremap Joel Fernandes (Google)
2018-10-13 1:31 ` [PATCH 1/4] treewide: remove unused address argument from pte_alloc functions (v2) Joel Fernandes (Google)
2018-10-24 8:37 ` Peter Zijlstra
2018-10-25 2:21 ` Joel Fernandes
2018-10-26 8:52 ` Peter Zijlstra
2018-10-25 10:47 ` Kirill A. Shutemov
2018-10-26 8:50 ` Peter Zijlstra
2018-10-13 1:31 ` [PATCH 2/4] mm: speed up mremap by 500x on large regions (v2) Joel Fernandes (Google)
2018-10-15 9:42 ` Christoph Hellwig [this message]
2018-10-15 22:33 ` Joel Fernandes
2018-10-16 11:29 ` Vlastimil Babka
2018-10-16 19:43 ` Joel Fernandes
2018-10-17 7:38 ` Vlastimil Babka
2018-10-24 10:12 ` Kirill A. Shutemov
2018-10-24 11:57 ` Balbir Singh
2018-10-24 12:57 ` Kirill A. Shutemov
2018-10-25 2:09 ` Joel Fernandes
2018-10-25 10:19 ` Kirill A. Shutemov
2018-10-26 21:11 ` Joel Fernandes
2018-10-29 10:28 ` Will Deacon
2018-10-25 2:13 ` Joel Fernandes
2018-10-27 10:21 ` Balbir Singh
2018-10-27 19:39 ` Joel Fernandes
2018-10-28 22:40 ` Balbir Singh
2018-10-13 1:31 ` [PATCH 3/4] arm64: select HAVE_MOVE_PMD for faster mremap (v1) Joel Fernandes (Google)
2018-10-13 1:32 ` [PATCH 4/4] x86: " Joel Fernandes (Google)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181015094209.GA31999@infradead.org \
--to=hch@infradead$(echo .)org \
--cc=Julia.Lawall@lip6$(echo .)fr \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anton.ivanov@kot-begemot$(echo .)co.uk \
--cc=aryabinin@virtuozzo$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chris@zankel$(echo .)net \
--cc=dalias@libc$(echo .)org \
--cc=dancol@google$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=elfring@users$(echo .)sourceforge.net \
--cc=fenghua.yu@intel$(echo .)com \
--cc=geert@linux-m68k$(echo .)org \
--cc=gxt@pku$(echo .)edu.cn \
--cc=hughd@google$(echo .)com \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=jdike@addtoit$(echo .)com \
--cc=jejb@parisc-linux$(echo .)org \
--cc=joel@joelfernandes$(echo .)org \
--cc=jonas@southpole$(echo .)se \
--cc=kasan-dev@googlegroups$(echo .)com \
--cc=kernel-team@android$(echo .)com \
--cc=kirill@shutemov$(echo .)name \
--cc=kvmarm@lists$(echo .)cs.columbia.edu \
--cc=lftan@altera$(echo .)com \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux-um@lists$(echo .)infradead.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lokeshgidra@google$(echo .)com \
--cc=luto@kernel$(echo .)org \
--cc=mhocko@kernel$(echo .)org \
--cc=minchan@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=nios2-dev@lists$(echo .)rocketboards.org \
--cc=pantin@google$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=richard@nod$(echo .)at \
--cc=sammy@sammy$(echo .)net \
--cc=shorne@gmail$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=stefan.kristiansson@saunalahti$(echo .)fi \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=will.deacon@arm$(echo .)com \
--cc=x86@kernel$(echo .)org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox