From: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
To: Douglas Anderson <dianders@chromium•org>
Cc: nm@ti•com, linux-mips@linux-mips•org, dalias@libc•org,
vigneshr@ti•com, linux-aspeed@lists•ozlabs.org,
linux-sh@vger•kernel.org, peterz@infradead•org,
catalin.marinas@arm•com, will.deacon@arm•com, mhocko@suse•com,
paulus@samba•org, hpa@zytor•com, sparclinux@vger•kernel.org,
jslaby@suse•com, mingo@kernel•org, marex@denx•de,
sfr@canb•auug.org.au,
Daniel Thompson <daniel.thompson@linaro•org>,
ysato@users•sourceforge.jp, linux-hexagon@vger•kernel.org,
x86@kernel•org, linux@armlinux•org.uk, tony@atomide•com,
mingo@redhat•com, joel@jms•id.au, linux-serial@vger•kernel.org,
kgdb-bugreport@lists•sourceforge.net, jhogan@kernel•org,
rolf.evers.fischer@aptiv•com, asierra@xes-inc•com,
linux-snps-arc@lists•infradead.org, dan.carpenter@oracle•com,
ying.huang@intel•com, Jisheng.Zhang@synaptics•com,
riel@surriel•com, linux-arm-msm@vger•kernel.org,
frederic@kernel•org, pombredanne@nexb•com,
rppt@linux•vnet.ibm.com, bp@alien8•de, luto@kernel•org,
tglx@linutronix•de, linux-arm-kernel@lists•infradead.org,
andrew@aj•id.au, gregkh@linuxfoundation•org,
linux-kernel@vger•kernel.org, ralf@linux-mips•org,
rkuo@codeaurora•org, paul.burton@mips•com, vgupta@synopsys•com,
jk@ozlabs•org, Jason Wessel <jason.wessel@windriver•com>,
akpm@linux-foundation•org, linuxppc-dev@lists•ozlabs.org,
davem@davemloft•net, kstewart@linuxfoundation•org
Subject: Re: [PATCH 0/7] serial: Finish kgdb on qcom_geni; fix many lockdep splats w/ kgdb
Date: Tue, 30 Oct 2018 14:36:27 +0200 [thread overview]
Message-ID: <20181030123627.GS10650@smile.fi.intel.com> (raw)
In-Reply-To: <20181029180707.207546-1-dianders@chromium.org>
On Mon, Oct 29, 2018 at 11:07:00AM -0700, Douglas Anderson wrote:
> I started out this series trying to make sysrq work over the serial
> console on qcom_geni_serial, then fell into a rat's nest.
>
> To solve the deadlock I faced when enabling sysrq I tried to borrow
> code from '8250_port.c' which avoided grabbing the port lock in
> console_write(). ...but since these days I try to run with lockdep on
> all the time, I found it caused an annoying lockdep splat (which I
> also reproduced on my rk3399 board). ...so I instead changed my
> qcom_geni_serial solution to borrow code from 'msm_serial.c'
>
> I wasn't super happy with the solution in 'msm_serial.c' though. I
> don't like releasing the spinlock there. Not only is it ugly but it
> means we are unlocking / re-locking _all the time_ even though sysrq
> characters are rare. ...so I came up with what I think is a better
> solution and then implemented it for qcom_geni_serial.
>
> Since I had a good way to test 8250-based UARTs, I also fixed that
> driver to use my new method. When doing so, I ran into a missing
> msm_serial.c at all, so I didn't switch that (or all other serial
> drivers for that matter) to the new method.
>
> After fixing all the above issues, I found the next lockdep splat in
> kgdb and I think I've worked around it in a good-enough way, but I'm
> much less confident about this. Hopefully folks can take a look at
> it.
>
> In general, patches earlier in this series should be "less
> controversial" and hopefully can land even if people don't like
> patches later in the series. ;-)
>
> Looking back, this is pretty much two series squashed that could be
> treated indepdently. The first is a serial series and the second is a
> kgdb series.
>
> For all serial patches I'd expect them to go through the tty tree once
> they've been reviewed.
>
> If folks are OK w/ the 'smp' patch it probably should go in some core
> kernel tree. The kgdb patch won't work without it, though, so to land
> that we'd need coordination between the folks landing that and the
> folks landing the 'smp' patch.
I have got only 0/7 and 5/7, everything okay with your mail client and other tools?
>
>
> Douglas Anderson (7):
> serial: qcom_geni_serial: Finish supporting sysrq
> serial: core: Allow processing sysrq at port unlock time
> serial: qcom_geni_serial: Process sysrq at port unlock time
> serial: core: Include console.h from serial_core.h
> serial: 8250: Process sysrq at port unlock time
> smp: Don't yell about IRQs disabled in kgdb_roundup_cpus()
> kgdb: Remove irq flags and local_irq_enable/disable from roundup
>
> arch/arc/kernel/kgdb.c | 4 +--
> arch/arm/kernel/kgdb.c | 4 +--
> arch/arm64/kernel/kgdb.c | 4 +--
> arch/hexagon/kernel/kgdb.c | 11 ++----
> arch/mips/kernel/kgdb.c | 4 +--
> arch/powerpc/kernel/kgdb.c | 2 +-
> arch/sh/kernel/kgdb.c | 4 +--
> arch/sparc/kernel/smp_64.c | 2 +-
> arch/x86/kernel/kgdb.c | 9 ++---
> drivers/tty/serial/8250/8250_aspeed_vuart.c | 6 +++-
> drivers/tty/serial/8250/8250_fsl.c | 6 +++-
> drivers/tty/serial/8250/8250_omap.c | 6 +++-
> drivers/tty/serial/8250/8250_port.c | 8 ++---
> drivers/tty/serial/qcom_geni_serial.c | 10 ++++--
> include/linux/kgdb.h | 9 ++---
> include/linux/serial_core.h | 38 ++++++++++++++++++++-
> kernel/debug/debug_core.c | 2 +-
> kernel/smp.c | 4 ++-
> 18 files changed, 80 insertions(+), 53 deletions(-)
>
> --
> 2.19.1.568.g152ad8e336-goog
>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2018-10-30 15:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 18:07 [PATCH 0/7] serial: Finish kgdb on qcom_geni; fix many lockdep splats w/ kgdb Douglas Anderson
2018-10-29 18:07 ` [PATCH 6/7] smp: Don't yell about IRQs disabled in kgdb_roundup_cpus() Douglas Anderson
2018-10-30 8:25 ` Peter Zijlstra
2018-10-30 9:41 ` Daniel Thompson
2018-10-30 22:21 ` Doug Anderson
2018-10-29 18:07 ` [PATCH 7/7] kgdb: Remove irq flags and local_irq_enable/disable from roundup Douglas Anderson
2018-10-30 11:46 ` Daniel Thompson
2018-10-30 22:22 ` Doug Anderson
2018-10-30 11:56 ` [PATCH 0/7] serial: Finish kgdb on qcom_geni; fix many lockdep splats w/ kgdb Daniel Thompson
2018-10-30 12:31 ` Russell King - ARM Linux
2018-10-30 22:20 ` Doug Anderson
2018-10-30 12:36 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181030123627.GS10650@smile.fi.intel.com \
--to=andriy.shevchenko@linux$(echo .)intel.com \
--cc=Jisheng.Zhang@synaptics$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=andrew@aj$(echo .)id.au \
--cc=asierra@xes-inc$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=dalias@libc$(echo .)org \
--cc=dan.carpenter@oracle$(echo .)com \
--cc=daniel.thompson@linaro$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=dianders@chromium$(echo .)org \
--cc=frederic@kernel$(echo .)org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hpa@zytor$(echo .)com \
--cc=jason.wessel@windriver$(echo .)com \
--cc=jhogan@kernel$(echo .)org \
--cc=jk@ozlabs$(echo .)org \
--cc=joel@jms$(echo .)id.au \
--cc=jslaby@suse$(echo .)com \
--cc=kgdb-bugreport@lists$(echo .)sourceforge.net \
--cc=kstewart@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-aspeed@lists$(echo .)ozlabs.org \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@linux-mips$(echo .)org \
--cc=linux-serial@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=luto@kernel$(echo .)org \
--cc=marex@denx$(echo .)de \
--cc=mhocko@suse$(echo .)com \
--cc=mingo@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=nm@ti$(echo .)com \
--cc=paul.burton@mips$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=pombredanne@nexb$(echo .)com \
--cc=ralf@linux-mips$(echo .)org \
--cc=riel@surriel$(echo .)com \
--cc=rkuo@codeaurora$(echo .)org \
--cc=rolf.evers.fischer@aptiv$(echo .)com \
--cc=rppt@linux$(echo .)vnet.ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony@atomide$(echo .)com \
--cc=vgupta@synopsys$(echo .)com \
--cc=vigneshr@ti$(echo .)com \
--cc=will.deacon@arm$(echo .)com \
--cc=x86@kernel$(echo .)org \
--cc=ying.huang@intel$(echo .)com \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox