From: Christoph Hellwig <hch@lst•de>
To: Christophe Leroy <christophe.leroy@c-s•fr>
Cc: Christian Lamparter <chunkeey@gmail•com>,
Paul Mackerras <paulus@samba•org>,
linuxppc-dev@lists•ozlabs.org, Christoph Hellwig <hch@lst•de>
Subject: Re: [PATCH 7/8] powerpc/dma: split the two __dma_alloc_coherent implementations
Date: Mon, 17 Dec 2018 08:35:43 +0100 [thread overview]
Message-ID: <20181217073543.GD1933@lst.de> (raw)
In-Reply-To: <de3d6e75-70d6-e1af-f733-b1aeed99d6c5@c-s.fr>
On Mon, Dec 17, 2018 at 07:51:05AM +0100, Christophe Leroy wrote:
>
>
> Le 16/12/2018 à 18:19, Christoph Hellwig a écrit :
>> The implemementation for the CONFIG_NOT_COHERENT_CACHE case doesn't share
>> any code with the one for systems with coherent caches. Split it off
>> and merge it with the helpers in dma-noncoherent.c that have no other
>> callers.
>>
>> Signed-off-by: Christoph Hellwig <hch@lst•de>
>> Acked-by: Benjamin Herrenschmidt <benh@kernel•crashing.org>
>> ---
>> arch/powerpc/include/asm/dma-mapping.h | 5 -----
>> arch/powerpc/kernel/dma.c | 14 ++------------
>
> Instead of all the ifdefs in dma.c, couldn't we split it
> in two files, ie dma.c for common parts and dma-coherence.c for specific
> stuff ?
The end goal is to kill dma.c and keep dma-noncoherent.c only with most
of the code moving to common code. Here is the current state of that:
http://git.infradead.org/users/hch/misc.git/shortlog/refs/heads/powerpc-dma.5
But it still has issues on two tested platforms and isn't ready yet.
next prev parent reply other threads:[~2018-12-17 7:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-16 17:19 small powerpc DMA fixes and cleanups Christoph Hellwig
2018-12-16 17:19 ` [PATCH 1/8] powerpc: allow NOT_COHERENT_CACHE for amigaone Christoph Hellwig
2018-12-22 9:54 ` [1/8] " Michael Ellerman
2018-12-16 17:19 ` [PATCH 2/8] powerpc/dma: properly wire up the unmap_page and unmap_sg methods Christoph Hellwig
2018-12-17 6:41 ` Christophe Leroy
2018-12-17 7:34 ` Christoph Hellwig
2018-12-17 7:39 ` Christophe Leroy
2018-12-17 8:16 ` Christoph Hellwig
2018-12-17 11:37 ` Michael Ellerman
2018-12-16 17:19 ` [PATCH 3/8] crypto4xx_core: don't abuse __dma_sync_page Christoph Hellwig
2018-12-16 18:28 ` Christian Lamparter
2018-12-17 7:27 ` Christoph Hellwig
2018-12-19 10:13 ` Christian Lamparter
2018-12-16 17:19 ` [PATCH 4/8] powerpc/dma: remove the unused ARCH_HAS_DMA_MMAP_COHERENT define Christoph Hellwig
2018-12-16 17:19 ` [PATCH 5/8] powerpc/dma: remove the unused ISA_DMA_THRESHOLD export Christoph Hellwig
2018-12-16 17:19 ` [PATCH 6/8] powerpc/dma: remove the unused dma_iommu_ops export Christoph Hellwig
2018-12-16 17:19 ` [PATCH 7/8] powerpc/dma: split the two __dma_alloc_coherent implementations Christoph Hellwig
2018-12-17 6:51 ` Christophe Leroy
2018-12-17 7:35 ` Christoph Hellwig [this message]
2018-12-17 21:34 ` Gerhard Pircher
2018-12-16 17:19 ` [PATCH 8/8] cxl: drop the dma_set_mask callback from vphb Christoph Hellwig
2018-12-16 23:10 ` Andrew Donnellan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181217073543.GD1933@lst.de \
--to=hch@lst$(echo .)de \
--cc=christophe.leroy@c-s$(echo .)fr \
--cc=chunkeey@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox