From: Greg KH <gregkh@linuxfoundation•org>
To: Xiaowei Bao <xiaowei.bao@nxp•com>
Cc: mark.rutland@arm•com, roy.zang@nxp•com,
lorenzo.pieralisi@arm•com, arnd@arndb•de,
devicetree@vger•kernel.org, linux-pci@vger•kernel.org,
kstewart@linuxfoundation•org, niklas.cassel@axis•com,
linux-kernel@vger•kernel.org, kishon@ti•com,
minghuan.Lian@nxp•com, robh+dt@kernel•org,
cyrille.pitchen@free-electrons•com,
linux-arm-kernel@lists•infradead.org, pombredanne@nexb•com,
bhelgaas@google•com, leoyang.li@nxp•com, shawnguo@kernel•org,
shawn.lin@rock-chips•com, mingkai.hu@nxp•com,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCHv3 4/4] misc: pci_endpoint_test: Add the layerscape EP device support
Date: Wed, 19 Dec 2018 10:21:04 +0100 [thread overview]
Message-ID: <20181219092104.GA7356@kroah.com> (raw)
In-Reply-To: <20181203103505.46885-4-xiaowei.bao@nxp.com>
On Mon, Dec 03, 2018 at 06:35:05PM +0800, Xiaowei Bao wrote:
> Add the layerscape EP device support in pci_endpoint_test driver.
>
> Signed-off-by: Xiaowei Bao <xiaowei.bao@nxp•com>
> ---
> v2:
> - no change
> v3:
> - no change
>
> drivers/misc/pci_endpoint_test.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/misc/pci_endpoint_test.c b/drivers/misc/pci_endpoint_test.c
> index 896e2df..744d10c 100644
> --- a/drivers/misc/pci_endpoint_test.c
> +++ b/drivers/misc/pci_endpoint_test.c
> @@ -788,6 +788,8 @@ static void pci_endpoint_test_remove(struct pci_dev *pdev)
> static const struct pci_device_id pci_endpoint_test_tbl[] = {
> { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA74x) },
> { PCI_DEVICE(PCI_VENDOR_ID_TI, PCI_DEVICE_ID_TI_DRA72x) },
> + /* 0x81c0: The device id of ls1046a in NXP. */
There is no need for a comment, just this line is fine:
> + { PCI_DEVICE(PCI_VENDOR_ID_FREESCALE, 0x81c0) },
If you note, no other lines have comments.
If you want to say that this is a specific device, then use a #define
with that device name and then use that define here, like the
PCI_DEVICE_ID_TI_DRA72x was done.
thanks,
greg k-h
next prev parent reply other threads:[~2018-12-19 9:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-03 10:35 [PATCHv3 1/4] dt-bindings: add DT binding for the layerscape PCIe controller with EP mode Xiaowei Bao
2018-12-03 10:35 ` [PATCHv3 2/4] arm64: dts: Add the PCIE EP node in dts Xiaowei Bao
2018-12-03 10:35 ` [PATCHv3 3/4] pci: layerscape: Add the EP mode support Xiaowei Bao
2018-12-03 10:35 ` [PATCHv3 4/4] misc: pci_endpoint_test: Add the layerscape EP device support Xiaowei Bao
2018-12-19 9:21 ` Greg KH [this message]
2018-12-19 9:30 ` Xiaowei Bao
2018-12-10 22:27 ` [PATCHv3 1/4] dt-bindings: add DT binding for the layerscape PCIe controller with EP mode Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181219092104.GA7356@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=bhelgaas@google$(echo .)com \
--cc=cyrille.pitchen@free-electrons$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=kishon@ti$(echo .)com \
--cc=kstewart@linuxfoundation$(echo .)org \
--cc=leoyang.li@nxp$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=minghuan.Lian@nxp$(echo .)com \
--cc=mingkai.hu@nxp$(echo .)com \
--cc=niklas.cassel@axis$(echo .)com \
--cc=pombredanne@nexb$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=roy.zang@nxp$(echo .)com \
--cc=shawn.lin@rock-chips$(echo .)com \
--cc=shawnguo@kernel$(echo .)org \
--cc=xiaowei.bao@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox