From: <wen.yang99@zte•com.cn>
To: <davem@davemloft•net>
Cc: peng.hao2@zte•com.cn, netdev@vger•kernel.org,
linux-kernel@vger•kernel.org, leoyang.li@nxp•com,
julia.lawall@lip6•fr, linuxppc-dev@lists•ozlabs.org,
qiang.zhao@nxp•com
Subject: Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm
Date: Sat, 29 Dec 2018 15:06:49 +0800 (CST) [thread overview]
Message-ID: <201812291506496295466@zte.com.cn> (raw)
In-Reply-To: <20181228.211053.848330303302862567.davem@davemloft.net>
[-- Attachment #1.1: Type: text/plain, Size: 1247 bytes --]
Hi David，
Thank you, we'll fix it soon.
Best wishes,
Wen
------------------Original Mail------------------
Sender: DavidMiller <davem@davemloft•net>
To: peng hao10096742;
CC: qiang.zhao@nxp•com <qiang.zhao@nxp.com>leoyang.li@nxp•com <leoyang.li@nxp.com>linux-kernel@vger•kernel.org <linux-kernel@vger•kernel.org>wen yang10156314;julia.lawall@lip6•fr <julia.lawall@lip6.fr>netdev@vger•kernel.org <netdev@vger.kernel.org>linuxppc-dev@lists•ozlabs.org <linuxppc-dev@lists•ozlabs.org>
Date: 2018/12/29 13:11
Subject: Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm
From: Peng Hao <peng.hao2@zte•com.cn>
Date: Wed, 26 Dec 2018 16:26:29 +0800
> diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
> index 839fa77..8ce4921f 100644
> --- a/drivers/net/wan/fsl_ucc_hdlc.c
> +++ b/drivers/net/wan/fsl_ucc_hdlc.c
> @@ -1057,6 +1057,27 @@ static const struct net_device_ops uhdlc_ops = {
> .ndo_tx_timeout = uhdlc_tx_timeout,
> };
>
> +static int ucc_get_resource_by_nodename(char *name, struct resource *res)
> +{
...
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + return 0;
This assignment to 'res' doesn't do what you think it does. The caller never
sees the value you compute.
prev parent reply other threads:[~2018-12-29 7:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-26 8:26 [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm Peng Hao
2018-12-29 5:10 ` David Miller
2018-12-29 7:06 ` wen.yang99 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201812291506496295466@zte.com.cn \
--to=wen.yang99@zte$(echo .)com.cn \
--cc=davem@davemloft$(echo .)net \
--cc=julia.lawall@lip6$(echo .)fr \
--cc=leoyang.li@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=netdev@vger$(echo .)kernel.org \
--cc=peng.hao2@zte$(echo .)com.cn \
--cc=qiang.zhao@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox