Subject: Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm

From: <[email-masked]>
Date: Sat, 29 Dec 2018 15:06:49 +0800 (CST)

Hi David，
Thank you, we'll fix it soon.

Best wishes,
  Wen
------------------Original Mail------------------
Sender: DavidMiller <[email-masked]>
To: peng hao10096742;
CC: [email-masked] <[email-masked]>[email-masked] <[email-masked]>[email-masked] <[email-masked]>wen yang10156314;[email-masked] <[email-masked]>[email-masked] <[email-masked]>[email-masked] <[email-masked]>
Date: 2018/12/29 13:11
Subject: Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm
From: Peng Hao <[email-masked]>
Date: Wed, 26 Dec 2018 16:26:29 +0800

> diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
> index 839fa77..8ce4921f 100644
> --- a/drivers/net/wan/fsl_ucc_hdlc.c
> +++ b/drivers/net/wan/fsl_ucc_hdlc.c
> @@ -1057,6 +1057,27 @@ static const struct net_device_ops uhdlc_ops = {
>      .ndo_tx_timeout    = uhdlc_tx_timeout,
>  };
>
> +static int ucc_get_resource_by_nodename(char *name, struct resource *res)
> +{
...
> +    res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +    return 0;

This assignment to 'res' doesn't do what you think it does.  The caller never
sees the value you compute.