From: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
To: linux-kernel@vger•kernel.org
Cc: Michal Hocko <mhocko@suse•com>, Takashi Iwai <tiwai@suse•de>,
Dave Hansen <dave.hansen@linux•intel.com>,
Keith Busch <keith.busch@intel•com>,
linux-mm@kvack•org, Paul Mackerras <paulus@samba•org>,
Yaowei Bai <baiyaowei@cmss•chinamobile.com>,
Ross Zwisler <zwisler@kernel•org>,
Sasha Levin <sashal@kernel•org>,
Dave Jiang <dave.jiang@intel•com>,
linux-nvdimm@lists•01.org,
Vishal Verma <vishal.l.verma@intel•com>,
Huang Ying <ying.huang@intel•com>, Borislav Petkov <bp@suse•de>,
Tom Lendacky <thomas.lendacky@amd•com>,
Jerome Glisse <jglisse@redhat•com>,
Bjorn Helgaas <bhelgaas@google•com>,
Dan Williams <dan.j.williams@intel•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
stable@vger•kernel.org, Andrew Morton <akpm@linux-foundation•org>,
Fengguang Wu <fengguang.wu@intel•com>,
linuxppc-dev@lists•ozlabs.org
Subject: [PATCH 5.0 057/246] mm/resource: Return real error codes from walk failures
Date: Thu, 4 Apr 2019 10:45:57 +0200 [thread overview]
Message-ID: <20190404084621.174666333@linuxfoundation.org> (raw)
In-Reply-To: <20190404084619.236418459@linuxfoundation.org>
5.0-stable review patch. If anyone has any objections, please let me know.
------------------
[ Upstream commit 5cd401ace914dc68556c6d2fcae0c349444d5f86 ]
walk_system_ram_range() can return an error code either becuase
*it* failed, or because the 'func' that it calls returned an
error. The memory hotplug does the following:
ret = walk_system_ram_range(..., func);
if (ret)
return ret;
and 'ret' makes it out to userspace, eventually. The problem
s, walk_system_ram_range() failues that result from *it* failing
(as opposed to 'func') return -1. That leads to a very odd
-EPERM (-1) return code out to userspace.
Make walk_system_ram_range() return -EINVAL for internal
failures to keep userspace less confused.
This return code is compatible with all the callers that I
audited.
Signed-off-by: Dave Hansen <dave.hansen@linux•intel.com>
Reviewed-by: Bjorn Helgaas <bhelgaas@google•com>
Acked-by: Michael Ellerman <mpe@ellerman•id.au> (powerpc)
Cc: Dan Williams <dan.j.williams@intel•com>
Cc: Dave Jiang <dave.jiang@intel•com>
Cc: Ross Zwisler <zwisler@kernel•org>
Cc: Vishal Verma <vishal.l.verma@intel•com>
Cc: Tom Lendacky <thomas.lendacky@amd•com>
Cc: Andrew Morton <akpm@linux-foundation•org>
Cc: Michal Hocko <mhocko@suse•com>
Cc: linux-nvdimm@lists•01.org
Cc: linux-kernel@vger•kernel.org
Cc: linux-mm@kvack•org
Cc: Huang Ying <ying.huang@intel•com>
Cc: Fengguang Wu <fengguang.wu@intel•com>
Cc: Borislav Petkov <bp@suse•de>
Cc: Yaowei Bai <baiyaowei@cmss•chinamobile.com>
Cc: Takashi Iwai <tiwai@suse•de>
Cc: Jerome Glisse <jglisse@redhat•com>
Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
Cc: Paul Mackerras <paulus@samba•org>
Cc: linuxppc-dev@lists•ozlabs.org
Cc: Keith Busch <keith.busch@intel•com>
Signed-off-by: Dan Williams <dan.j.williams@intel•com>
Signed-off-by: Sasha Levin <sashal@kernel•org>
---
kernel/resource.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/kernel/resource.c b/kernel/resource.c
index 915c02e8e5dd..ca7ed5158cff 100644
--- a/kernel/resource.c
+++ b/kernel/resource.c
@@ -382,7 +382,7 @@ static int __walk_iomem_res_desc(resource_size_t start, resource_size_t end,
int (*func)(struct resource *, void *))
{
struct resource res;
- int ret = -1;
+ int ret = -EINVAL;
while (start < end &&
!find_next_iomem_res(start, end, flags, desc, first_lvl, &res)) {
@@ -462,7 +462,7 @@ int walk_system_ram_range(unsigned long start_pfn, unsigned long nr_pages,
unsigned long flags;
struct resource res;
unsigned long pfn, end_pfn;
- int ret = -1;
+ int ret = -EINVAL;
start = (u64) start_pfn << PAGE_SHIFT;
end = ((u64)(start_pfn + nr_pages) << PAGE_SHIFT) - 1;
--
2.19.1
next parent reply other threads:[~2019-04-04 9:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190404084619.236418459@linuxfoundation.org>
2019-04-04 8:45 ` Greg Kroah-Hartman [this message]
2019-04-04 8:46 ` [PATCH 5.0 111/246] SoC: imx-sgtl5000: add missing put_device() Greg Kroah-Hartman
2019-04-04 8:47 ` [PATCH 5.0 173/246] ASoC: fsl-asoc-card: fix object reference leaks in fsl_asoc_card_probe Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190404084621.174666333@linuxfoundation.org \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=baiyaowei@cmss$(echo .)chinamobile.com \
--cc=bhelgaas@google$(echo .)com \
--cc=bp@suse$(echo .)de \
--cc=dan.j.williams@intel$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=dave.jiang@intel$(echo .)com \
--cc=fengguang.wu@intel$(echo .)com \
--cc=jglisse@redhat$(echo .)com \
--cc=keith.busch@intel$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-nvdimm@lists$(echo .)01.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mhocko@suse$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=sashal@kernel$(echo .)org \
--cc=stable@vger$(echo .)kernel.org \
--cc=thomas.lendacky@amd$(echo .)com \
--cc=tiwai@suse$(echo .)de \
--cc=vishal.l.verma@intel$(echo .)com \
--cc=ying.huang@intel$(echo .)com \
--cc=zwisler@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox