From: Nicolin Chen <nicoleotsuka@gmail•com>
To: "S.j. Wang" <shengjiu.wang@nxp•com>
Cc: "alsa-devel@alsa-project•org" <alsa-devel@alsa-project•org>,
"timur@kernel•org" <timur@kernel•org>,
"gustavo@embeddedor•com" <gustavo@embeddedor•com>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"Xiubo.Lee@gmail•com" <Xiubo.Lee@gmail•com>,
"broonie@kernel•org" <broonie@kernel•org>,
"festevam@gmail•com" <festevam@gmail•com>
Subject: Re: [PATCH V2] ASoC: fsl_esai: replace fall-through with break
Date: Tue, 9 Apr 2019 20:53:17 -0700 [thread overview]
Message-ID: <20190410035317.GA3032@Asurada> (raw)
In-Reply-To: <46e9b55edb223894392a90c7cdb6241a43cb9cff.1554864022.git.shengjiu.wang@nxp.com>
On Wed, Apr 10, 2019 at 02:42:45AM +0000, S.j. Wang wrote:
> case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be independent of
> each other, so replace fall-through with break.
>
> Fixes: 43d24e76b698 ("ASoC: fsl_esai: Add ESAI CPU DAI driver")
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp•com>
Acked-by: Nicolin Chen <nicoleotsuka@gmail•com>
Thanks
> ---
> Changes in v2
> - fix the fixes tag.
>
> sound/soc/fsl/fsl_esai.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c
> index c7410bbfd2af..bad0dfed6b68 100644
> --- a/sound/soc/fsl/fsl_esai.c
> +++ b/sound/soc/fsl/fsl_esai.c
> @@ -251,7 +251,7 @@ static int fsl_esai_set_dai_sysclk(struct snd_soc_dai *dai, int clk_id,
> break;
> case ESAI_HCKT_EXTAL:
> ecr |= ESAI_ECR_ETI;
> - /* fall through */
> + break;
> case ESAI_HCKR_EXTAL:
> ecr |= esai_priv->synchronous ? ESAI_ECR_ETI : ESAI_ECR_ERI;
> break;
> --
> 1.9.1
>
next prev parent reply other threads:[~2019-04-10 3:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 2:42 [PATCH V2] ASoC: fsl_esai: replace fall-through with break S.j. Wang
2019-04-10 3:53 ` Nicolin Chen [this message]
2019-04-10 11:28 ` Mark Brown
2019-04-11 3:09 ` [EXT] " S.j. Wang
2019-04-10 14:31 ` Gustavo A. R. Silva
2019-04-11 2:48 ` [EXT] " S.j. Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410035317.GA3032@Asurada \
--to=nicoleotsuka@gmail$(echo .)com \
--cc=Xiubo.Lee@gmail$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=festevam@gmail$(echo .)com \
--cc=gustavo@embeddedor$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=shengjiu.wang@nxp$(echo .)com \
--cc=timur@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox