From: Nicolin Chen <nicoleotsuka@gmail•com>
To: Viorel Suman <viorel.suman@nxp•com>
Cc: "mark.rutland@arm•com" <mark.rutland@arm•com>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"alsa-devel@alsa-project•org" <alsa-devel@alsa-project•org>,
"lgirdwood@gmail•com" <lgirdwood@gmail•com>,
"timur@kernel•org" <timur@kernel•org>,
"Xiubo.Lee@gmail•com" <Xiubo.Lee@gmail•com>,
"festevam@gmail•com" <festevam@gmail•com>,
"broonie@kernel•org" <broonie@kernel•org>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"tiwai@suse•com" <tiwai@suse•com>,
"viorel.suman@gmail•com" <viorel.suman@gmail•com>,
"Julia.Lawall@lip6•fr" <Julia.Lawall@lip6•fr>,
"robh+dt@kernel•org" <robh+dt@kernel•org>,
dl-linux-imx <linux-imx@nxp•com>,
"kernel@pengutronix•de" <kernel@pengutronix•de>,
"shawnguo@kernel•org" <shawnguo@kernel•org>,
"perex@perex•cz" <perex@perex•cz>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
"s.hauer@pengutronix•de" <s.hauer@pengutronix•de>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [EXT] Re: [PATCH v2 1/3] ASoC: fsl_audmix: remove "model" attribute
Date: Wed, 10 Apr 2019 10:51:57 -0700 [thread overview]
Message-ID: <20190410175156.GA24002@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <1554892497.14997.13.camel@nxp.com>
On Wed, Apr 10, 2019 at 10:34:57AM +0000, Viorel Suman wrote:
> Hi Nicolin,
>
> On Ma, 2019-04-09 at 21:29 -0700, Nicolin Chen wrote:
> > WARNING: This email was created outside of NXP. DO NOT CLICK links or
> > attachments unless you recognize the sender and know the content is
> > safe.
> >
> >
> >
> > On Tue, Apr 09, 2019 at 11:27:39AM +0000, Viorel Suman wrote:
> > >
> > > Use "of_device_id.data" to specify the machine driver
> > > instead of "model" DTS attribute.
> > >
> > > Signed-off-by: Viorel Suman <viorel.suman@nxp•com>
> > Acked-by: Nicolin Chen <nicoleotsuka@gmail•com>
> >
> > >
> > > ---
> > > sound/soc/fsl/fsl_audmix.c | 43 +++++++++++++++++++++++-----------
> > > ---------
> > > 1 file changed, 23 insertions(+), 20 deletions(-)
> > >
> > > + priv->pdev = platform_device_register_data(&pdev->dev, mdrv,
> > > 0, NULL,
> > > + 0);
> > Would you please send a separate patch to replace "pdev->dev"?
>
> Thank you for review. Yes, will send V3.
Ah...when I said that, I was literally saying that you should
send a separate patch individually, not resend the series.
Now I see you sent v3/v4 almost at the same time as "Applied"
mails from Mark. And I am totally confused which version got
applied....
Please rebase your local tree and find out which version got
applied and then send the diff with a separate patch.
Thanks
Nicolin
next prev parent reply other threads:[~2019-04-10 17:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 11:27 [PATCH v2 0/3] ASoC: fsl: audmix: remove "model" attribute and fix ref leaks Viorel Suman
2019-04-09 11:27 ` [PATCH v2 1/3] ASoC: fsl_audmix: remove "model" attribute Viorel Suman
2019-04-10 4:29 ` Nicolin Chen
2019-04-10 6:20 ` [alsa-devel] " Daniel Baluta
2019-04-10 6:37 ` Nicolin Chen
2019-04-10 6:48 ` Daniel Baluta
2019-04-10 10:34 ` [EXT] " Viorel Suman
2019-04-10 17:51 ` Nicolin Chen [this message]
2019-04-09 11:27 ` [PATCH v2 2/3] dt-bindings: fsl,audmix: " Viorel Suman
2019-04-10 4:29 ` Nicolin Chen
2019-04-09 11:27 ` [PATCH v2 3/3] ASoC: imx-audmix: fix object reference leaks in probe Viorel Suman
2019-04-10 4:30 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190410175156.GA24002@Asurada-Nvidia.nvidia.com \
--to=nicoleotsuka@gmail$(echo .)com \
--cc=Julia.Lawall@lip6$(echo .)fr \
--cc=Xiubo.Lee@gmail$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=robh+dt@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=timur@kernel$(echo .)org \
--cc=tiwai@suse$(echo .)com \
--cc=viorel.suman@gmail$(echo .)com \
--cc=viorel.suman@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox