From: Nicolin Chen <nicoleotsuka@gmail•com>
To: Viorel Suman <viorel.suman@nxp•com>
Cc: Mark Rutland <mark.rutland@arm•com>,
"devicetree@vger•kernel.org" <devicetree@vger•kernel.org>,
"alsa-devel@alsa-project•org" <alsa-devel@alsa-project•org>,
"linuxppc-dev@lists•ozlabs.org" <linuxppc-dev@lists•ozlabs.org>,
Timur Tabi <timur@kernel•org>, Xiubo Li <Xiubo.Lee@gmail•com>,
Shawn Guo <shawnguo@kernel•org>,
Sascha Hauer <s.hauer@pengutronix•de>,
Takashi Iwai <tiwai@suse•com>,
Liam Girdwood <lgirdwood@gmail•com>,
Rob Herring <robh+dt@kernel•org>,
Jaroslav Kysela <perex@perex•cz>,
Viorel Suman <viorel.suman@gmail•com>,
Julia Lawall <Julia.Lawall@lip6•fr>,
Mark Brown <broonie@kernel•org>, dl-linux-imx <linux-imx@nxp•com>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Fabio Estevam <festevam@gmail•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH v4 4/4] ASoC: fsl_audmix: cache pdev->dev pointer
Date: Thu, 11 Apr 2019 13:21:18 -0700 [thread overview]
Message-ID: <20190411202117.GC13170@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <1554894380-25153-5-git-send-email-viorel.suman@nxp.com>
On Wed, Apr 10, 2019 at 11:06:39AM +0000, Viorel Suman wrote:
> There should be no trouble to understand dev = pdev->dev.
> This can save some space to have more print info or save
> some wrapped lines.
Change looks fine. Ack.
> Signed-off-by: Viorel Suman <viorel.suman@nxp•com>
> Suggested-by: Nicolin Chen <nicoleotsuka@gmail•com>
I think usually Suggested-by comes above Signed-off-by.
This was originally in your change already, so you can replace:
-Suggested-by: Nicolin Chen <nicoleotsuka@gmail•com>
-Acked-by: Nicolin Chen <nicoleotsuka@gmail•com>
Just a chance for it to get resent without being a noise :)
next prev parent reply other threads:[~2019-04-11 20:24 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 11:06 [PATCH v4 0/4] ASoC: fsl: audmix: remove "model" attribute and fix ref leaks Viorel Suman
2019-04-10 11:06 ` [PATCH v4 1/4] ASoC: fsl_audmix: remove "model" attribute Viorel Suman
2019-04-10 11:06 ` [PATCH v4 2/4] ASoC: fsl_audmix: remove "model" attribute from DT document Viorel Suman
2019-04-10 14:26 ` Fabio Estevam
2019-04-10 11:06 ` [PATCH v4 3/4] ASoC: imx-audmix: fix object reference leaks in probe Viorel Suman
2019-04-10 14:26 ` Fabio Estevam
2019-04-10 11:06 ` [PATCH v4 4/4] ASoC: fsl_audmix: cache pdev->dev pointer Viorel Suman
2019-04-11 20:21 ` Nicolin Chen [this message]
2019-04-15 8:53 ` Applied "ASoC: fsl_audmix: cache pdev->dev pointer" to the asoc tree Mark Brown
2019-05-02 2:18 ` Mark Brown
2019-04-10 11:12 ` [PATCH v4 0/4] ASoC: fsl: audmix: remove "model" attribute and fix ref leaks Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190411202117.GC13170@Asurada-Nvidia.nvidia.com \
--to=nicoleotsuka@gmail$(echo .)com \
--cc=Julia.Lawall@lip6$(echo .)fr \
--cc=Xiubo.Lee@gmail$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=robh+dt@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=timur@kernel$(echo .)org \
--cc=tiwai@suse$(echo .)com \
--cc=viorel.suman@gmail$(echo .)com \
--cc=viorel.suman@nxp$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox