public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
* [PATCH] powerpc/mm: Move some of the boot time info print to generic file
@ 2019-05-28  5:35 Aneesh Kumar K.V
  2019-05-29 15:55 ` Christophe Leroy
  0 siblings, 1 reply; 3+ messages in thread
From: Aneesh Kumar K.V @ 2019-05-28  5:35 UTC (permalink / raw)
  To: npiggin, paulus, mpe; +Cc: Aneesh Kumar K.V, linuxppc-dev

With radix translation enabled we find in dmesg

 hash-mmu: ppc64_pft_size    = 0x0
 hash-mmu: kernel vmalloc start   = 0xc008000000000000
 hash-mmu: kernel IO start        = 0xc00a000000000000
 hash-mmu: kernel vmemmap start   = 0xc00c000000000000

This is because these pr_info calls are in hash_utils.c which has

 #define pr_fmt(fmt) "hash-mmu: " fmt

The information printed in generic and hence move that to generic file

Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux•ibm.com>
---
 arch/powerpc/kernel/setup-common.c    | 4 ++++
 arch/powerpc/mm/book3s64/hash_utils.c | 5 -----
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/arch/powerpc/kernel/setup-common.c b/arch/powerpc/kernel/setup-common.c
index aad9f5df6ab6..a73a91f2c21f 100644
--- a/arch/powerpc/kernel/setup-common.c
+++ b/arch/powerpc/kernel/setup-common.c
@@ -810,6 +810,10 @@ static __init void print_system_info(void)
 	pr_info("mmu_features      = 0x%08x\n", cur_cpu_spec->mmu_features);
 #ifdef CONFIG_PPC64
 	pr_info("firmware_features = 0x%016lx\n", powerpc_firmware_features);
+	pr_info("ppc64_pft_size    = 0x%llx\n", ppc64_pft_size);
+	pr_info("kernel vmalloc start   = 0x%lx\n", KERN_VIRT_START);
+	pr_info("kernel IO start        = 0x%lx\n", KERN_IO_START);
+	pr_info("kernel vmemmap start   = 0x%lx\n", (unsigned long)vmemmap);
 #endif
 
 	print_system_hash_info();
diff --git a/arch/powerpc/mm/book3s64/hash_utils.c b/arch/powerpc/mm/book3s64/hash_utils.c
index 919a861a8ec0..2f677914bfd2 100644
--- a/arch/powerpc/mm/book3s64/hash_utils.c
+++ b/arch/powerpc/mm/book3s64/hash_utils.c
@@ -1950,11 +1950,6 @@ machine_device_initcall(pseries, hash64_debugfs);
 
 void __init print_system_hash_info(void)
 {
-	pr_info("ppc64_pft_size    = 0x%llx\n", ppc64_pft_size);
-
 	if (htab_hash_mask)
 		pr_info("htab_hash_mask    = 0x%lx\n", htab_hash_mask);
-	pr_info("kernel vmalloc start   = 0x%lx\n", KERN_VIRT_START);
-	pr_info("kernel IO start        = 0x%lx\n", KERN_IO_START);
-	pr_info("kernel vmemmap start   = 0x%lx\n", (unsigned long)vmemmap);
 }
-- 
2.21.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] powerpc/mm: Move some of the boot time info print to generic file
  2019-05-28  5:35 [PATCH] powerpc/mm: Move some of the boot time info print to generic file Aneesh Kumar K.V
@ 2019-05-29 15:55 ` Christophe Leroy
  2019-05-30  2:36   ` Aneesh Kumar K.V
  0 siblings, 1 reply; 3+ messages in thread
From: Christophe Leroy @ 2019-05-29 15:55 UTC (permalink / raw)
  To: Aneesh Kumar K.V; +Cc: linuxppc-dev, npiggin, paulus

"Aneesh Kumar K.V" <aneesh.kumar@linux•ibm.com> a écrit :

> With radix translation enabled we find in dmesg
>
>  hash-mmu: ppc64_pft_size    = 0x0
>  hash-mmu: kernel vmalloc start   = 0xc008000000000000
>  hash-mmu: kernel IO start        = 0xc00a000000000000
>  hash-mmu: kernel vmemmap start   = 0xc00c000000000000
>
> This is because these pr_info calls are in hash_utils.c which has
>
>  #define pr_fmt(fmt) "hash-mmu: " fmt
>
> The information printed in generic and hence move that to generic file

Some similarities with Nick's patch  
https://patchwork.ozlabs.org/patch/1100245/ ?

Christophe

>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux•ibm.com>
> ---
>  arch/powerpc/kernel/setup-common.c    | 4 ++++
>  arch/powerpc/mm/book3s64/hash_utils.c | 5 -----
>  2 files changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/arch/powerpc/kernel/setup-common.c  
> b/arch/powerpc/kernel/setup-common.c
> index aad9f5df6ab6..a73a91f2c21f 100644
> --- a/arch/powerpc/kernel/setup-common.c
> +++ b/arch/powerpc/kernel/setup-common.c
> @@ -810,6 +810,10 @@ static __init void print_system_info(void)
>  	pr_info("mmu_features      = 0x%08x\n", cur_cpu_spec->mmu_features);
>  #ifdef CONFIG_PPC64
>  	pr_info("firmware_features = 0x%016lx\n", powerpc_firmware_features);
> +	pr_info("ppc64_pft_size    = 0x%llx\n", ppc64_pft_size);
> +	pr_info("kernel vmalloc start   = 0x%lx\n", KERN_VIRT_START);
> +	pr_info("kernel IO start        = 0x%lx\n", KERN_IO_START);
> +	pr_info("kernel vmemmap start   = 0x%lx\n", (unsigned long)vmemmap);
>  #endif
>
>  	print_system_hash_info();
> diff --git a/arch/powerpc/mm/book3s64/hash_utils.c  
> b/arch/powerpc/mm/book3s64/hash_utils.c
> index 919a861a8ec0..2f677914bfd2 100644
> --- a/arch/powerpc/mm/book3s64/hash_utils.c
> +++ b/arch/powerpc/mm/book3s64/hash_utils.c
> @@ -1950,11 +1950,6 @@ machine_device_initcall(pseries, hash64_debugfs);
>
>  void __init print_system_hash_info(void)
>  {
> -	pr_info("ppc64_pft_size    = 0x%llx\n", ppc64_pft_size);
> -
>  	if (htab_hash_mask)
>  		pr_info("htab_hash_mask    = 0x%lx\n", htab_hash_mask);
> -	pr_info("kernel vmalloc start   = 0x%lx\n", KERN_VIRT_START);
> -	pr_info("kernel IO start        = 0x%lx\n", KERN_IO_START);
> -	pr_info("kernel vmemmap start   = 0x%lx\n", (unsigned long)vmemmap);
>  }
> --
> 2.21.0



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] powerpc/mm: Move some of the boot time info print to generic file
  2019-05-29 15:55 ` Christophe Leroy
@ 2019-05-30  2:36   ` Aneesh Kumar K.V
  0 siblings, 0 replies; 3+ messages in thread
From: Aneesh Kumar K.V @ 2019-05-30  2:36 UTC (permalink / raw)
  To: Christophe Leroy; +Cc: linuxppc-dev, npiggin, paulus

On 5/29/19 9:25 PM, Christophe Leroy wrote:
> "Aneesh Kumar K.V" <aneesh.kumar@linux•ibm.com> a écrit :
> 
>> With radix translation enabled we find in dmesg
>>
>>  hash-mmu: ppc64_pft_size    = 0x0
>>  hash-mmu: kernel vmalloc start   = 0xc008000000000000
>>  hash-mmu: kernel IO start        = 0xc00a000000000000
>>  hash-mmu: kernel vmemmap start   = 0xc00c000000000000
>>
>> This is because these pr_info calls are in hash_utils.c which has
>>
>>  #define pr_fmt(fmt) "hash-mmu: " fmt
>>
>> The information printed in generic and hence move that to generic file
> 
> Some similarities with Nick's patch 
> https://patchwork.ozlabs.org/patch/1100245/ ?
> 
>

I missed that completely.

-aneesh


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-05-30  2:38 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-28  5:35 [PATCH] powerpc/mm: Move some of the boot time info print to generic file Aneesh Kumar K.V
2019-05-29 15:55 ` Christophe Leroy
2019-05-30  2:36   ` Aneesh Kumar K.V

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox