From: <wen.yang99@zte•com.cn>
To: <viresh.kumar@linaro•org>
Cc: wang.yi59@zte•com.cn, linux-pm@vger•kernel.org,
rjw@rjwysocki•net, linux-kernel@vger•kernel.org,
xue.zhihong@zte•com.cn, cheng.shengyu@zte•com.cn,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2] cpufreq/pasemi: fix an use-after-free inpas_cpufreq_cpu_init()
Date: Mon, 8 Jul 2019 16:26:15 +0800 (CST) [thread overview]
Message-ID: <201907081626159718896@zte.com.cn> (raw)
In-Reply-To: <20190708074432.56q2e3ig5ehiee5f@vireshk-i7>
[-- Attachment #1.1: Type: text/plain, Size: 1674 bytes --]
> > The cpu variable is still being used in the of_get_property() call
> > after the of_node_put() call, which may result in use-after-free.
> >
> > Fixes: a9acc26b75f ("cpufreq/pasemi: fix possible object reference leak")
> > Signed-off-by: Wen Yang <wen.yang99@zte•com.cn>
> > Cc: "Rafael J. Wysocki" <rjw@rjwysocki•net>
> > Cc: Viresh Kumar <viresh.kumar@linaro•org>
> > Cc: linuxppc-dev@lists•ozlabs.org
> > Cc: linux-pm@vger•kernel.org
> > Cc: linux-kernel@vger•kernel.org
> > ---
> > v2: clean up the code according to the advice of viresh.
> >
> > drivers/cpufreq/pasemi-cpufreq.c | 10 +++++-----
> > 1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c
> > index 6b1e4ab..c6d464b 100644
> > --- a/drivers/cpufreq/pasemi-cpufreq.c
> > +++ b/drivers/cpufreq/pasemi-cpufreq.c
> > @@ -128,20 +128,18 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
> > int cur_astate, idx;
> > struct resource res;
> > struct device_node *cpu, *dn;
> > - int err = -ENODEV;
> > + int err;
> >
> > cpu = of_get_cpu_node(policy->cpu, NULL);
> > -
> > - of_node_put(cpu);
> > if (!cpu)
> > - goto out;
> > + return -ENODEV;
> >
>
>
> > dn = of_find_compatible_node(NULL, NULL, "1682m-sdc");
> > if (!dn)
> > dn = of_find_compatible_node(NULL, NULL,
> > "pasemi,pwrficient-sdc");
> > if (!dn)
> > - goto out;
> > + return -ENODEV;
>
> This change looks incorrect. You still need to drop reference to cpu ?
>
Thanks!
We will fix it immediately.
--
Thanks and regards,
Wen
prev parent reply other threads:[~2019-07-08 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 7:19 [PATCH v2] cpufreq/pasemi: fix an use-after-free in pas_cpufreq_cpu_init() Wen Yang
2019-07-08 7:44 ` Viresh Kumar
2019-07-08 8:26 ` wen.yang99 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201907081626159718896@zte.com.cn \
--to=wen.yang99@zte$(echo .)com.cn \
--cc=cheng.shengyu@zte$(echo .)com.cn \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=rjw@rjwysocki$(echo .)net \
--cc=viresh.kumar@linaro$(echo .)org \
--cc=wang.yi59@zte$(echo .)com.cn \
--cc=xue.zhihong@zte$(echo .)com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox