From: <wen.yang99@zte•com.cn>
To: <Markus.Elfring@web•de>
Cc: wang.yi59@zte•com.cn, cheng.shengyu@zte•com.cn,
kernel-janitors@vger•kernel.org, linux-kernel@vger•kernel.org,
oss@buserror•net, paulus@samba•org,
linuxppc-dev@lists•ozlabs.org
Subject: Re: powerpc/83xx: fix use-after-free on mpc831x_usb_cfg()
Date: Tue, 9 Jul 2019 10:19:58 +0800 (CST) [thread overview]
Message-ID: <201907091019586328815@zte.com.cn> (raw)
In-Reply-To: <99840e11-e0e6-b3f4-e35b-56ef4ec39417@web.de>
[-- Attachment #1.1: Type: text/plain, Size: 677 bytes --]
> > The np variable is still being used after the of_node_put() call,
>
> > which may result in use-after-free.
>
> > We fix this issue by calling of_node_put() after the last usage.
>
>
> I imagine that this commit description can be improved a bit more
> (by mentioning the influence of “immr_node”?).
> How do you think about to omit the word “We” here?
>
>
> > This patatch also do some cleanup.
>
>
> Should the renaming of a jump label be contributed in a separate update
> step of a small patch series besides a wording without a typo?
Thank you for your comments.
We will improve the commit description and send v2 as soon as possible.
--
Regards,
Wen
prev parent reply other threads:[~2019-07-09 2:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-05 8:58 [PATCH] powerpc/83xx: fix use-after-free on mpc831x_usb_cfg() Wen Yang
2019-07-08 15:21 ` Markus Elfring
2019-07-09 2:19 ` wen.yang99 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201907091019586328815@zte.com.cn \
--to=wen.yang99@zte$(echo .)com.cn \
--cc=Markus.Elfring@web$(echo .)de \
--cc=cheng.shengyu@zte$(echo .)com.cn \
--cc=kernel-janitors@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=oss@buserror$(echo .)net \
--cc=paulus@samba$(echo .)org \
--cc=wang.yi59@zte$(echo .)com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox