public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: <wen.yang99@zte•com.cn>
To: <Markus.Elfring@web•de>
Cc: wang.yi59@zte•com.cn, kernel-janitors@vger•kernel.org,
	linux-kernel@vger•kernel.org, oss@buserror•net,
	Markus.Elfring@web•de, xue.zhihong@zte•com.cn,
	cheng.shengyu@zte•com.cn, paulus@samba•org,
	linuxppc-dev@lists•ozlabs.org
Subject: Re: [1/2] powerpc/83xx: fix use-after-free in mpc831x_usb_cfg()
Date: Wed, 10 Jul 2019 15:33:44 +0800 (CST)	[thread overview]
Message-ID: <201907101533443009168@zte.com.cn> (raw)
In-Reply-To: <3138c2fa-1e99-f672-2108-33dd1cf25ca2@web.de>


[-- Attachment #1.1: Type: text/plain, Size: 479 bytes --]

> > The immr_node variable is still being used after the of_node_put() call,
> > which may result in use-after-free.
> 
> Was any known source code analysis tool involved to point such
> a questionable implementation detail out for further software
> development considerations?

Hi Markus, 
we developed a coccinelle script to detect such problems. 
This script is still being improved.
After a period of testing, we will send it to the LMKL mailing list later.

--
Regards,
Wen

  reply	other threads:[~2019-07-10  7:36 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1562670768-23178-1-git-send-email-wen.yang99@zte.com.cn>
2019-07-09 11:12 ` [PATCH 1/2] powerpc/83xx: fix use-after-free in mpc831x_usb_cfg() Wen Yang
2019-07-10  7:19   ` [1/2] " Markus Elfring
2019-07-10  7:33     ` wen.yang99 [this message]
2019-07-10  9:24       ` Markus Elfring
2019-07-10 15:15       ` Coccinelle: Checking of_node_put() calls with SmPL Markus Elfring
2019-07-11  6:35         ` wen.yang99
2019-07-11  6:46           ` Julia Lawall
2019-07-11  9:33             ` Markus Elfring
2019-07-11  9:04           ` Markus Elfring
2019-07-11 14:41           ` Tyrel Datwyler
2019-07-09 11:12 ` [PATCH 2/2] powerpc/83xx: cleanup error paths in mpc831x_usb_cfg() Wen Yang
2019-07-09 16:14 ` [PATCH 0/2] fix use-after-free in mpc831x_usb_cfg() and do some cleanups Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201907101533443009168@zte.com.cn \
    --to=wen.yang99@zte$(echo .)com.cn \
    --cc=Markus.Elfring@web$(echo .)de \
    --cc=cheng.shengyu@zte$(echo .)com.cn \
    --cc=kernel-janitors@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=oss@buserror$(echo .)net \
    --cc=paulus@samba$(echo .)org \
    --cc=wang.yi59@zte$(echo .)com.cn \
    --cc=xue.zhihong@zte$(echo .)com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox