From: Christoph Hellwig <hch@infradead•org>
To: Arnd Bergmann <arnd@arndb•de>
Cc: Rich Felker <dalias@libc•org>,
Linux-sh list <linux-sh@vger•kernel.org>,
Heiko Carstens <heiko.carstens@de•ibm.com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership•com>,
Max Filippov <jcmvbkbc@gmail•com>, Guo Ren <guoren@kernel•org>,
"H. Peter Anvin" <hpa@zytor•com>,
sparclinux <sparclinux@vger•kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm•com>,
Will Deacon <will@kernel•org>,
linux-arch <linux-arch@vger•kernel.org>,
linux-s390 <linux-s390@vger•kernel.org>,
Yoshinori Sato <ysato@users•sourceforge.jp>,
Helge Deller <deller@gmx•de>,
the arch/x86 maintainers <x86@kernel•org>,
Russell King <linux@armlinux•org.uk>,
Christian Borntraeger <borntraeger@de•ibm.com>,
Ingo Molnar <mingo@redhat•com>,
Geert Uytterhoeven <geert@linux-m68k•org>,
Christian Brauner <christian@brauner•io>,
Catalin Marinas <catalin.marinas@arm•com>,
James Hogan <jhogan@kernel•org>,
Firoz Khan <firoz.khan@linaro•org>,
Michal Suchanek <msuchanek@suse•de>,
linux-xtensa@linux-xtensa•org, Vasily Gorbik <gor@linux•ibm.com>,
Chris Zankel <chris@zankel•net>,
linux-m68k <linux-m68k@lists•linux-m68k.org>,
Borislav Petkov <bp@alien8•de>,
Alexander Viro <viro@zeniv•linux.org.uk>,
Thomas Gleixner <tglx@linutronix•de>,
Linux ARM <linux-arm-kernel@lists•infradead.org>,
David Howells <dhowells@redhat•com>,
Michal Simek <monstr@monstr•eu>,
Parisc List <linux-parisc@vger•kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
linux-mips@vger•kernel.org, Ralf Baechle <ralf@linux-mips•org>,
Paul Burton <paul.burton@mips•com>,
Linux FS-devel Mailing List <linux-fsdevel@vger•kernel.org>,
Paul Mackerras <paulus@samba•org>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH] Revert "asm-generic: Remove unneeded __ARCH_WANT_SYS_LLSEEK macro"
Date: Sat, 31 Aug 2019 01:38:49 -0700 [thread overview]
Message-ID: <20190831083849.GA24644@infradead.org> (raw)
In-Reply-To: <CAK8P3a16=ktJm5B3c5-XS7SqVuHBY5+E2FwVUqbdOdWK-AUgSA@mail.gmail.com>
On Fri, Aug 30, 2019 at 09:54:43PM +0200, Arnd Bergmann wrote:
> > -#if !defined(CONFIG_64BIT) || defined(CONFIG_COMPAT)
> > +#ifdef __ARCH_WANT_SYS_LLSEEK
> > SYSCALL_DEFINE5(llseek, unsigned int, fd, unsigned long, offset_high,
> > unsigned long, offset_low, loff_t __user *, result,
> > unsigned int, whence)
>
> However, only reverting the patch will now break all newly added
> 32-bit architectures that don't define __ARCH_WANT_SYS_LLSEEK:
> at least nds32 and riscv32 come to mind, not sure if there is another.
>
> I think the easiest way however would be to combine the two checks
> above and make it
>
> #if !defined(CONFIG_64BIT) || defined(CONFIG_COMPAT) ||
> defined(__ARCH_WANT_SYS_LLSEEK)
>
> and then only set __ARCH_WANT_SYS_LLSEEK for powerpc.
I'd much rather introduce a CONFIG_SYS_LLSEEK Kconfig symbol, selected
by CONFIG_64BIT and CONFIG_COMPAT by default, plus manually by powerpc.
next prev parent reply other threads:[~2019-08-31 8:42 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-30 18:57 [PATCH v6 0/6] Disable compat cruft on ppc64le v6 Michal Suchanek
2019-08-30 18:57 ` [PATCH v6 1/6] powerpc: make llseek 32bit-only Michal Suchanek
2019-08-30 19:46 ` [PATCH] Revert "asm-generic: Remove unneeded __ARCH_WANT_SYS_LLSEEK macro" Michal Suchanek
2019-08-30 19:54 ` Arnd Bergmann
2019-08-30 20:13 ` Michal Suchánek
2019-08-30 20:37 ` Arnd Bergmann
[not found] ` <20190830202959.3539-1-msuchanek@suse.de>
2019-08-30 20:32 ` Arnd Bergmann
2019-08-31 8:38 ` Christoph Hellwig [this message]
2019-08-31 13:44 ` [PATCH] Revert "asm-generic: Remove unneeded __ARCH_WANT_SYS_LLSEEK macro" Arnd Bergmann
2019-08-30 18:57 ` [PATCH v6 2/6] powerpc: move common register copy functions from signal_32.c to signal.c Michal Suchanek
2019-08-30 20:22 ` Christophe Leroy
2019-08-30 18:57 ` [PATCH v6 3/6] powerpc/perf: consolidate read_user_stack_32 Michal Suchanek
2019-08-30 20:21 ` Christophe Leroy
2019-08-30 18:57 ` [PATCH v6 4/6] powerpc/64: make buildable without CONFIG_COMPAT Michal Suchanek
2019-08-30 20:21 ` Christophe Leroy
2019-08-30 20:35 ` Michal Suchánek
2019-08-30 18:57 ` [PATCH v6 5/6] powerpc/64: Make COMPAT user-selectable disabled on littleendian by default Michal Suchanek
2019-08-30 20:23 ` Christophe Leroy
2019-08-30 18:57 ` [PATCH v6 6/6] powerpc/perf: split callchain.c by bitness Michal Suchanek
2019-08-30 19:06 ` Michal Suchánek
2019-09-02 2:51 ` Michael Ellerman
2019-08-30 20:28 ` Christophe Leroy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190831083849.GA24644@infradead.org \
--to=hch@infradead$(echo .)org \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chris@zankel$(echo .)net \
--cc=christian@brauner$(echo .)io \
--cc=dalias@libc$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=dhowells@redhat$(echo .)com \
--cc=firoz.khan@linaro$(echo .)org \
--cc=geert@linux-m68k$(echo .)org \
--cc=gor@linux$(echo .)ibm.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=guoren@kernel$(echo .)org \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=jhogan@kernel$(echo .)org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mingo@redhat$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=msuchanek@suse$(echo .)de \
--cc=paul.burton@mips$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=vincenzo.frascino@arm$(echo .)com \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox