From: Ingo Molnar <mingo@kernel•org>
To: Peter Zijlstra <peterz@infradead•org>
Cc: dalias@libc•org, linux-sh@vger•kernel.org,
catalin.marinas@arm•com, dave.hansen@linux•intel.com,
heiko.carstens@de•ibm.com, linuxarm@huawei•com,
jiaxun.yang@flygoat•com, linux-kernel@vger•kernel.org,
mwb@linux•vnet.ibm.com, paulus@samba•org, hpa@zytor•com,
sparclinux@vger•kernel.org, chenhc@lemote•com, will@kernel•org,
linux-s390@vger•kernel.org, ysato@users•sourceforge.jp,
x86@kernel•org, paul.burton@mips•com, rppt@linux•ibm.com,
borntraeger@de•ibm.com, dledford@redhat•com, mingo@redhat•com,
jeffrey.t.kirsher@intel•com, jhogan@kernel•org,
nfont@linux•vnet.ibm.com, mattst88@gmail•com,
len.brown@intel•com, gor@linux•ibm.com,
anshuman.khandual@arm•com, ink@jurassic•park.msu.ru, cai@lca•pw,
luto@kernel•org, tglx@linutronix•de,
naveen.n.rao@linux•vnet.ibm.com,
linux-arm-kernel@lists•infradead.org, rth@twiddle•net,
axboe@kernel•dk, robin.murphy@arm•com,
linux-mips@vger•kernel.org, ralf@linux-mips•org,
tbogendoerfer@suse•de, Yunsheng Lin <linyunsheng@huawei•com>,
linux-alpha@vger•kernel.org, bp@alien8•de,
akpm@linux-foundation•org, linuxppc-dev@lists•ozlabs.org,
davem@davemloft•net
Subject: Re: [PATCH v2 2/9] x86: numa: check the node id consistently for x86
Date: Mon, 2 Sep 2019 20:17:31 +0200 [thread overview]
Message-ID: <20190902181731.GB35858@gmail.com> (raw)
In-Reply-To: <20190902072542.GN2369@hirez.programming.kicks-ass.net>
* Peter Zijlstra <peterz@infradead•org> wrote:
> Also note that the CONFIG_DEBUG_PER_CPU_MAPS version of
> cpumask_of_node() already does this (although it wants the below fix).
>
> ---
> diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
> index e6dad600614c..5f49c10201c7 100644
> --- a/arch/x86/mm/numa.c
> +++ b/arch/x86/mm/numa.c
> @@ -861,7 +861,7 @@ void numa_remove_cpu(int cpu)
> */
> const struct cpumask *cpumask_of_node(int node)
> {
> - if (node >= nr_node_ids) {
> + if ((unsigned)node >= nr_node_ids) {
> printk(KERN_WARNING
> "cpumask_of_node(%d): node > nr_node_ids(%u)\n",
> node, nr_node_ids);
Nitpicking: please also fix the kernel message to say ">=".
With that:
Acked-by: Ingo Molnar <mingo@kernel•org>
Note that:
- arch/arm64/mm/numa.c copied the same sign bug (or unrobustness if we
don't want to call it a bug).
- Kudos to the mm/memcontrol.c and kernel/bpf/syscall.c teams for not
copying that bug. Booo for none of them fixing the buggy pattern
elsewhere in the kernel ;-)
Thanks,
Ingo
next prev parent reply other threads:[~2019-09-02 18:19 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 5:58 [PATCH v2 0/9] check the node id consistently across different arches Yunsheng Lin
2019-08-31 5:58 ` [PATCH v2 1/9] arm64: numa: check the node id consistently for arm64 Yunsheng Lin
2019-08-31 5:58 ` [PATCH v2 2/9] x86: numa: check the node id consistently for x86 Yunsheng Lin
2019-08-31 8:55 ` Peter Zijlstra
2019-08-31 10:09 ` Yunsheng Lin
2019-08-31 16:12 ` Peter Zijlstra
2019-09-02 5:46 ` Yunsheng Lin
2019-09-02 7:25 ` Peter Zijlstra
2019-09-02 12:25 ` Yunsheng Lin
2019-09-02 12:56 ` Peter Zijlstra
2019-09-02 18:22 ` Ingo Molnar
2019-09-02 19:14 ` Peter Zijlstra
2019-09-03 6:19 ` Yunsheng Lin
2019-09-03 7:11 ` Peter Zijlstra
2019-09-03 8:31 ` Yunsheng Lin
2019-09-03 12:15 ` Salil Mehta
2019-09-03 14:28 ` Peter Zijlstra
2019-09-02 18:17 ` Ingo Molnar [this message]
2019-09-03 7:53 ` [PATCH] x86/mm: Fix cpumask_of_node() error condition Peter Zijlstra
2019-08-31 5:58 ` [PATCH v2 3/9] alpha: numa: check the node id consistently for alpha Yunsheng Lin
2019-08-31 5:58 ` [PATCH v2 4/9] powerpc: numa: check the node id consistently for powerpc Yunsheng Lin
2019-08-31 5:58 ` [PATCH v2 5/9] s390: numa: check the node id consistently for s390 Yunsheng Lin
2019-09-02 4:05 ` kbuild test robot
2019-08-31 5:58 ` [PATCH v2 6/9] sh: numa: check the node id consistently for sh Yunsheng Lin
2019-08-31 5:58 ` [PATCH v2 7/9] sparc64: numa: check the node id consistently for sparc64 Yunsheng Lin
2019-08-31 6:53 ` David Miller
2019-08-31 8:57 ` Yunsheng Lin
2019-08-31 20:02 ` David Miller
2019-09-02 6:08 ` Yunsheng Lin
2019-09-02 15:17 ` David Miller
2019-08-31 5:58 ` [PATCH v2 8/9] mips: numa: check the node id consistently for mips ip27 Yunsheng Lin
2019-08-31 15:45 ` Paul Burton
2019-09-02 6:11 ` Yunsheng Lin
2019-08-31 5:58 ` [PATCH v2 9/9] mips: numa: check the node id consistently for mips loongson64 Yunsheng Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190902181731.GB35858@gmail.com \
--to=mingo@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anshuman.khandual@arm$(echo .)com \
--cc=axboe@kernel$(echo .)dk \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=bp@alien8$(echo .)de \
--cc=cai@lca$(echo .)pw \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chenhc@lemote$(echo .)com \
--cc=dalias@libc$(echo .)org \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=dledford@redhat$(echo .)com \
--cc=gor@linux$(echo .)ibm.com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=jeffrey.t.kirsher@intel$(echo .)com \
--cc=jhogan@kernel$(echo .)org \
--cc=jiaxun.yang@flygoat$(echo .)com \
--cc=len.brown@intel$(echo .)com \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linuxarm@huawei$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=linyunsheng@huawei$(echo .)com \
--cc=luto@kernel$(echo .)org \
--cc=mattst88@gmail$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=mwb@linux$(echo .)vnet.ibm.com \
--cc=naveen.n.rao@linux$(echo .)vnet.ibm.com \
--cc=nfont@linux$(echo .)vnet.ibm.com \
--cc=paul.burton@mips$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=robin.murphy@arm$(echo .)com \
--cc=rppt@linux$(echo .)ibm.com \
--cc=rth@twiddle$(echo .)net \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tbogendoerfer@suse$(echo .)de \
--cc=tglx@linutronix$(echo .)de \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox