From: Ingo Molnar <mingo@kernel•org>
To: Anshuman Khandual <anshuman.khandual@arm•com>
Cc: Mark Rutland <mark.rutland@arm•com>,
linux-ia64@vger•kernel.org, linux-sh@vger•kernel.org,
Peter Zijlstra <peterz@infradead•org>,
James Hogan <jhogan@kernel•org>,
Tetsuo Handa <penguin-kernel@i-love•sakura.ne.jp>,
Heiko Carstens <heiko.carstens@de•ibm.com>,
Michal Hocko <mhocko@kernel•org>,
linux-mm@kvack•org, Dave Hansen <dave.hansen@intel•com>,
Paul Mackerras <paulus@samba•org>,
sparclinux@vger•kernel.org, Thomas Gleixner <tglx@linutronix•de>,
linux-s390@vger•kernel.org, x86@kernel•org,
Russell King - ARM Linux <linux@armlinux•org.uk>,
Matthew Wilcox <willy@infradead•org>,
Steven Price <Steven.Price@arm•com>,
Jason Gunthorpe <jgg@ziepe•ca>,
Gerald Schaefer <gerald.schaefer@de•ibm.com>,
linux-snps-arc@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
Kees Cook <keescook@chromium•org>,
Masahiro Yamada <yamada.masahiro@socionext•com>,
Mark Brown <broonie@kernel•org>,
"Kirill A . Shutemov" <kirill@shutemov•name>,
Dan Williams <dan.j.williams@intel•com>,
Vlastimil Babka <vbabka@suse•cz>,
Sri Krishna chowdary <schowdary@nvidia•com>,
Ard Biesheuvel <ard.biesheuvel@linaro•org>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
linux-mips@vger•kernel.org, Ralf Baechle <ralf@linux-mips•org>,
linux-kernel@vger•kernel.org, Paul Burton <paul.burton@mips•com>,
Mike Rapoport <rppt@linux•vnet.ibm.com>,
Vineet Gupta <vgupta@synopsys•com>,
Martin Schwidefsky <schwidefsky@de•ibm.com>,
Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH V9] mm/debug: Add tests validating architecture page table helpers
Date: Tue, 12 Nov 2019 07:29:51 +0100 [thread overview]
Message-ID: <20191112062951.GA100264@gmail.com> (raw)
In-Reply-To: <1573532326-24084-1-git-send-email-anshuman.khandual@arm.com>
* Anshuman Khandual <anshuman.khandual@arm•com> wrote:
> +config DEBUG_VM_PGTABLE
> + bool "Debug arch page table for semantics compliance"
> + depends on MMU
> + depends on DEBUG_VM
> + depends on ARCH_HAS_DEBUG_VM_PGTABLE
> + help
> + This option provides a debug method which can be used to test
> + architecture page table helper functions on various platforms in
> + verifying if they comply with expected generic MM semantics. This
> + will help architecture code in making sure that any changes or
> + new additions of these helpers still conform to expected
> + semantics of the generic MM.
> +
> + If unsure, say N.
Since CONFIG_DEBUG_VM is generally disabled in distro kernel packages,
why not make this 'default y' to maximize testing coverage? The code size
increase should be minimal, and DEBUG_VM increases size anyway.
Other than that this looks good to me:
Reviewed-by: Ingo Molnar <mingo@kernel•org>
Thanks,
Ingo
next prev parent reply other threads:[~2019-11-12 6:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 4:18 [PATCH V9] mm/debug: Add tests validating architecture page table helpers Anshuman Khandual
2019-11-12 4:38 ` Anshuman Khandual
2019-11-12 6:29 ` Ingo Molnar [this message]
2019-11-12 6:52 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191112062951.GA100264@gmail.com \
--to=mingo@kernel$(echo .)org \
--cc=Steven.Price@arm$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anshuman.khandual@arm$(echo .)com \
--cc=ard.biesheuvel@linaro$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=dan.j.williams@intel$(echo .)com \
--cc=dave.hansen@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=gerald.schaefer@de$(echo .)ibm.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=jgg@ziepe$(echo .)ca \
--cc=jhogan@kernel$(echo .)org \
--cc=keescook@chromium$(echo .)org \
--cc=kirill@shutemov$(echo .)name \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mhocko@kernel$(echo .)org \
--cc=paul.burton@mips$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=penguin-kernel@i-love$(echo .)sakura.ne.jp \
--cc=peterz@infradead$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
--cc=rppt@linux$(echo .)vnet.ibm.com \
--cc=schowdary@nvidia$(echo .)com \
--cc=schwidefsky@de$(echo .)ibm.com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=vbabka@suse$(echo .)cz \
--cc=vgupta@synopsys$(echo .)com \
--cc=willy@infradead$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=yamada.masahiro@socionext$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox