From: Jan Kara <jack@suse•cz>
To: John Hubbard <jhubbard@nvidia•com>
Cc: "Michal Hocko" <mhocko@suse•com>, "Jan Kara" <jack@suse•cz>,
kvm@vger•kernel.org, linux-doc@vger•kernel.org,
"David Airlie" <airlied@linux•ie>,
"Dave Chinner" <david@fromorbit•com>,
dri-devel@lists•freedesktop.org,
LKML <linux-kernel@vger•kernel.org>,
linux-mm@kvack•org, "Paul Mackerras" <paulus@samba•org>,
linux-kselftest@vger•kernel.org,
"Ira Weiny" <ira.weiny@intel•com>,
"Jonathan Corbet" <corbet@lwn•net>,
linux-rdma@vger•kernel.org,
"Christoph Hellwig" <hch@infradead•org>,
"Jason Gunthorpe" <jgg@ziepe•ca>,
"Vlastimil Babka" <vbabka@suse•cz>,
"Björn Töpel" <bjorn.topel@intel•com>,
linux-media@vger•kernel.org, "Shuah Khan" <shuah@kernel•org>,
linux-block@vger•kernel.org, "Jérôme Glisse" <jglisse@redhat•com>,
"Al Viro" <viro@zeniv•linux.org.uk>,
"Dan Williams" <dan.j.williams@intel•com>,
"Mauro Carvalho Chehab" <mchehab@kernel•org>,
bpf@vger•kernel.org,
"Magnus Karlsson" <magnus.karlsson@intel•com>,
"Jens Axboe" <axboe@kernel•dk>,
netdev@vger•kernel.org,
"Alex Williamson" <alex.williamson@redhat•com>,
"Daniel Vetter" <daniel@ffwll•ch>,
linux-fsdevel@vger•kernel.org,
"Andrew Morton" <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org,
"David S . Miller" <davem@davemloft•net>,
"Mike Kravetz" <mike.kravetz@oracle•com>
Subject: Re: [PATCH v4 03/23] mm/gup: move try_get_compound_head() to top, fix minor issues
Date: Wed, 13 Nov 2019 11:50:23 +0100 [thread overview]
Message-ID: <20191113105023.GG6367@quack2.suse.cz> (raw)
In-Reply-To: <20191113042710.3997854-4-jhubbard@nvidia.com>
On Tue 12-11-19 20:26:50, John Hubbard wrote:
> An upcoming patch uses try_get_compound_head() more widely,
> so move it to the top of gup.c.
>
> Also fix a tiny spelling error and a checkpatch.pl warning.
>
> Signed-off-by: John Hubbard <jhubbard@nvidia•com>
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse•cz>
Honza
> ---
> mm/gup.c | 29 +++++++++++++++--------------
> 1 file changed, 15 insertions(+), 14 deletions(-)
>
> diff --git a/mm/gup.c b/mm/gup.c
> index 199da99e8ffc..933524de6249 100644
> --- a/mm/gup.c
> +++ b/mm/gup.c
> @@ -29,6 +29,21 @@ struct follow_page_context {
> unsigned int page_mask;
> };
>
> +/*
> + * Return the compound head page with ref appropriately incremented,
> + * or NULL if that failed.
> + */
> +static inline struct page *try_get_compound_head(struct page *page, int refs)
> +{
> + struct page *head = compound_head(page);
> +
> + if (WARN_ON_ONCE(page_ref_count(head) < 0))
> + return NULL;
> + if (unlikely(!page_cache_add_speculative(head, refs)))
> + return NULL;
> + return head;
> +}
> +
> /**
> * put_user_pages_dirty_lock() - release and optionally dirty gup-pinned pages
> * @pages: array of pages to be maybe marked dirty, and definitely released.
> @@ -1793,20 +1808,6 @@ static void __maybe_unused undo_dev_pagemap(int *nr, int nr_start,
> }
> }
>
> -/*
> - * Return the compund head page with ref appropriately incremented,
> - * or NULL if that failed.
> - */
> -static inline struct page *try_get_compound_head(struct page *page, int refs)
> -{
> - struct page *head = compound_head(page);
> - if (WARN_ON_ONCE(page_ref_count(head) < 0))
> - return NULL;
> - if (unlikely(!page_cache_add_speculative(head, refs)))
> - return NULL;
> - return head;
> -}
> -
> #ifdef CONFIG_ARCH_HAS_PTE_SPECIAL
> static int gup_pte_range(pmd_t pmd, unsigned long addr, unsigned long end,
> unsigned int flags, struct page **pages, int *nr)
> --
> 2.24.0
>
--
Jan Kara <jack@suse•com>
SUSE Labs, CR
next prev parent reply other threads:[~2019-11-13 10:54 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 4:26 [PATCH v4 00/23] mm/gup: track dma-pinned pages: FOLL_PIN, FOLL_LONGTERM John Hubbard
2019-11-13 4:26 ` [PATCH v4 01/23] mm/gup: pass flags arg to __gup_device_* functions John Hubbard
2019-11-13 10:50 ` Jan Kara
2019-11-13 4:26 ` [PATCH v4 02/23] mm/gup: factor out duplicate code from four routines John Hubbard
2019-11-13 11:15 ` Jan Kara
2019-11-13 23:12 ` John Hubbard
2019-11-13 4:26 ` [PATCH v4 03/23] mm/gup: move try_get_compound_head() to top, fix minor issues John Hubbard
2019-11-13 10:50 ` Jan Kara [this message]
2019-11-13 18:38 ` Ira Weiny
2019-11-13 4:26 ` [PATCH v4 04/23] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages John Hubbard
2019-11-13 10:49 ` Jan Kara
2019-11-13 19:09 ` Jerome Glisse
2019-11-13 19:23 ` Dan Williams
2019-11-13 22:00 ` Dan Williams
2019-11-13 22:46 ` John Hubbard
2019-11-13 22:55 ` Dan Williams
2019-11-13 22:56 ` John Hubbard
2019-11-13 23:03 ` Jerome Glisse
2019-11-13 4:26 ` [PATCH v4 05/23] goldish_pipe: rename local pin_user_pages() routine John Hubbard
2019-11-13 4:26 ` [PATCH v4 06/23] IB/umem: use get_user_pages_fast() to pin DMA pages John Hubbard
2019-11-13 4:26 ` [PATCH v4 07/23] media/v4l2-core: set pages dirty upon releasing DMA buffers John Hubbard
2019-11-13 4:26 ` [PATCH v4 08/23] vfio, mm: fix get_user_pages_remote() and FOLL_LONGTERM John Hubbard
2019-11-13 13:02 ` Jason Gunthorpe
2019-11-13 19:17 ` Ira Weiny
2019-11-13 20:19 ` John Hubbard
2019-11-13 18:47 ` Ira Weiny
2019-11-13 4:26 ` [PATCH v4 09/23] mm/gup: introduce pin_user_pages*() and FOLL_PIN John Hubbard
2019-11-13 10:43 ` Jan Kara
2019-11-13 18:31 ` Ira Weiny
2019-11-13 18:45 ` Dan Williams
2019-11-13 23:22 ` John Hubbard
2019-11-14 6:08 ` John Hubbard
2019-11-13 18:59 ` Ira Weiny
2019-11-13 20:24 ` John Hubbard
2019-11-13 4:26 ` [PATCH v4 10/23] goldish_pipe: convert to pin_user_pages() and put_user_page() John Hubbard
2019-11-13 4:26 ` [PATCH v4 11/23] IB/{core, hw, umem}: set FOLL_PIN, FOLL_LONGTERM via pin_longterm_pages*() John Hubbard
2019-11-13 4:26 ` [PATCH v4 12/23] mm/process_vm_access: set FOLL_PIN via pin_user_pages_remote() John Hubbard
2019-11-13 4:27 ` [PATCH v4 13/23] drm/via: set FOLL_PIN via pin_user_pages_fast() John Hubbard
2019-11-13 4:27 ` [PATCH v4 14/23] fs/io_uring: set FOLL_PIN via pin_user_pages() John Hubbard
2019-11-13 4:27 ` [PATCH v4 15/23] net/xdp: " John Hubbard
2019-11-13 4:27 ` [PATCH v4 16/23] mm/gup: track FOLL_PIN pages John Hubbard
2019-11-13 4:27 ` [PATCH v4 17/23] media/v4l2-core: pin_longterm_pages (FOLL_PIN) and put_user_page() conversion John Hubbard
2019-11-13 4:27 ` [PATCH v4 18/23] vfio, mm: " John Hubbard
2019-11-13 4:27 ` [PATCH v4 19/23] powerpc: book3s64: convert to pin_longterm_pages() and put_user_page() John Hubbard
2019-11-13 4:27 ` [PATCH v4 20/23] mm/gup_benchmark: use proper FOLL_WRITE flags instead of hard-coding "1" John Hubbard
2019-11-13 19:01 ` Ira Weiny
2019-11-13 4:27 ` [PATCH v4 21/23] mm/gup_benchmark: support pin_user_pages() and related calls John Hubbard
2019-11-13 19:03 ` Ira Weiny
2019-11-13 4:27 ` [PATCH v4 22/23] selftests/vm: run_vmtests: invoke gup_benchmark with basic FOLL_PIN coverage John Hubbard
2019-11-13 19:06 ` Ira Weiny
2019-11-13 4:27 ` [PATCH v4 23/23] mm/gup: remove support for gup(FOLL_LONGTERM) John Hubbard
2019-11-13 19:09 ` Ira Weiny
2019-11-13 23:27 ` John Hubbard
2019-11-13 4:32 ` [PATCH v4 00/23] mm/gup: track dma-pinned pages: FOLL_PIN, FOLL_LONGTERM John Hubbard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191113105023.GG6367@quack2.suse.cz \
--to=jack@suse$(echo .)cz \
--cc=airlied@linux$(echo .)ie \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alex.williamson@redhat$(echo .)com \
--cc=axboe@kernel$(echo .)dk \
--cc=bjorn.topel@intel$(echo .)com \
--cc=bpf@vger$(echo .)kernel.org \
--cc=corbet@lwn$(echo .)net \
--cc=dan.j.williams@intel$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=davem@davemloft$(echo .)net \
--cc=david@fromorbit$(echo .)com \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=hch@infradead$(echo .)org \
--cc=ira.weiny@intel$(echo .)com \
--cc=jgg@ziepe$(echo .)ca \
--cc=jglisse@redhat$(echo .)com \
--cc=jhubbard@nvidia$(echo .)com \
--cc=kvm@vger$(echo .)kernel.org \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-rdma@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=magnus.karlsson@intel$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=mhocko@suse$(echo .)com \
--cc=mike.kravetz@oracle$(echo .)com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paulus@samba$(echo .)org \
--cc=shuah@kernel$(echo .)org \
--cc=vbabka@suse$(echo .)cz \
--cc=viro@zeniv$(echo .)linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox