From: Greg KH <greg@kroah•com>
To: Andrew Donnellan <ajd@linux•ibm.com>
Cc: linuxppc-dev@lists•ozlabs.org, npiggin@gmail•com,
stable@vger•kernel.org, Anton Blanchard <anton@samba•org>
Subject: Re: [PATCH stable 4.4] powerpc/boot: Request no dynamic linker for boot wrapper
Date: Thu, 14 Nov 2019 14:02:36 +0800 [thread overview]
Message-ID: <20191114060236.GD353293@kroah.com> (raw)
In-Reply-To: <20191112065941.9548-1-ajd@linux.ibm.com>
On Tue, Nov 12, 2019 at 05:59:41PM +1100, Andrew Donnellan wrote:
> From: Nicholas Piggin <npiggin@gmail•com>
>
> Commit ff45000fcb56b5b0f1a14a865d3541746d838a0a upstream.
>
> The boot wrapper performs its own relocations and does not require
> PT_INTERP segment. However currently we don't tell the linker that.
>
> Prior to binutils 2.28 that works OK. But since binutils commit
> 1a9ccd70f9a7 ("Fix the linker so that it will not silently generate ELF
> binaries with invalid program headers. Fix readelf to report such
> invalid binaries.") binutils tries to create a program header segment
> due to PT_INTERP, and the link fails because there is no space for it:
>
> ld: arch/powerpc/boot/zImage.pseries: Not enough room for program headers, try linking with -N
> ld: final link failed: Bad value
>
> So tell the linker not to do that, by passing --no-dynamic-linker.
>
> Cc: stable@vger•kernel.org
> Reported-by: Anton Blanchard <anton@samba•org>
> Signed-off-by: Nicholas Piggin <npiggin@gmail•com>
> [mpe: Drop dependency on ld-version.sh and massage change log]
> Signed-off-by: Michael Ellerman <mpe@ellerman•id.au>
> [ajd: backport to v4.4 (resolve conflict with a comment line)]
> Signed-off-by: Andrew Donnellan <ajd@linux•ibm.com>
> ---
> arch/powerpc/boot/wrapper | 24 +++++++++++++++++++++++-
> 1 file changed, 23 insertions(+), 1 deletion(-)
Now queud up, thanks.
greg k-h
prev parent reply other threads:[~2019-11-14 6:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 6:59 [PATCH stable 4.4] powerpc/boot: Request no dynamic linker for boot wrapper Andrew Donnellan
2019-11-14 6:02 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114060236.GD353293@kroah.com \
--to=greg@kroah$(echo .)com \
--cc=ajd@linux$(echo .)ibm.com \
--cc=anton@samba$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=npiggin@gmail$(echo .)com \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox