From: Nicolin Chen <nicoleotsuka@gmail•com>
To: Michael Walle <michael@walle•cc>
Cc: alsa-devel@alsa-project•org, Timur Tabi <timur@kernel•org>,
Xiubo Li <Xiubo.Lee@gmail•com>,
linuxppc-dev@lists•ozlabs.org, Takashi Iwai <tiwai@suse•com>,
linux-kernel@vger•kernel.org, Liam Girdwood <lgirdwood@gmail•com>,
Mark Brown <broonie@kernel•org>, Jaroslav Kysela <perex@perex•cz>,
Fabio Estevam <festevam@gmail•com>
Subject: Re: [PATCH] ASoC: fsl_sai: add IRQF_SHARED
Date: Wed, 4 Dec 2019 18:17:57 -0800 [thread overview]
Message-ID: <20191205021756.GA1122@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <20191128223802.18228-1-michael@walle.cc>
On Thu, Nov 28, 2019 at 11:38:02PM +0100, Michael Walle wrote:
> The LS1028A SoC uses the same interrupt line for adjacent SAIs. Use
> IRQF_SHARED to be able to use these SAIs simultaneously.
>
> Signed-off-by: Michael Walle <michael@walle•cc>
Acked-by: Nicolin Chen <nicoleotsuka@gmail•com>
Thanks
> ---
> sound/soc/fsl/fsl_sai.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_sai.c b/sound/soc/fsl/fsl_sai.c
> index b517e4bc1b87..8c3ea7300972 100644
> --- a/sound/soc/fsl/fsl_sai.c
> +++ b/sound/soc/fsl/fsl_sai.c
> @@ -958,7 +958,8 @@ static int fsl_sai_probe(struct platform_device *pdev)
> if (irq < 0)
> return irq;
>
> - ret = devm_request_irq(&pdev->dev, irq, fsl_sai_isr, 0, np->name, sai);
> + ret = devm_request_irq(&pdev->dev, irq, fsl_sai_isr, IRQF_SHARED,
> + np->name, sai);
> if (ret) {
> dev_err(&pdev->dev, "failed to claim irq %u\n", irq);
> return ret;
> --
> 2.20.1
>
next prev parent reply other threads:[~2019-12-05 2:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 22:38 [PATCH] ASoC: fsl_sai: add IRQF_SHARED Michael Walle
2019-11-29 21:57 ` Fabio Estevam
2019-12-05 2:17 ` Nicolin Chen [this message]
2019-12-05 8:43 ` Daniel Baluta
2019-12-05 9:18 ` Michael Walle
2019-12-05 9:45 ` Daniel Baluta
2019-12-09 18:59 ` Applied "ASoC: fsl_sai: add IRQF_SHARED" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191205021756.GA1122@Asurada-Nvidia.nvidia.com \
--to=nicoleotsuka@gmail$(echo .)com \
--cc=Xiubo.Lee@gmail$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=festevam@gmail$(echo .)com \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=michael@walle$(echo .)cc \
--cc=perex@perex$(echo .)cz \
--cc=timur@kernel$(echo .)org \
--cc=tiwai@suse$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox