From: Greg KH <gregkh@linuxfoundation•org>
To: Santosh Sivaraj <santosh@fossix•org>
Cc: peterz@infradead•org, aneesh.kumar@linux•ibm.com,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
akshay.adiga@linux•ibm.com, stable@vger•kernel.org
Subject: Re: [PATCH 0/6] Memory corruption may occur due to incorrent tlb flush
Date: Thu, 20 Feb 2020 08:29:34 +0100 [thread overview]
Message-ID: <20200220072934.GA3253157@kroah.com> (raw)
In-Reply-To: <20200220053457.930231-1-santosh@fossix.org>
On Thu, Feb 20, 2020 at 11:04:51AM +0530, Santosh Sivaraj wrote:
> The TLB flush optimisation (a46cc7a90f: powerpc/mm/radix: Improve TLB/PWC
> flushes) may result in random memory corruption. Any concurrent page-table walk
> could end up with a Use-after-Free. Even on UP this might give issues, since
> mmu_gather is preemptible these days. An interrupt or preempted task accessing
> user pages might stumble into the free page if the hardware caches page
> directories.
>
> The series is a backport of the fix sent by Peter [1].
>
> The first three patches are dependencies for the last patch (avoid potential
> double flush). If the performance impact due to double flush is considered
> trivial then the first three patches and last patch may be dropped.
>
> [1] https://patchwork.kernel.org/cover/11284843/
Can you resend these with the git commit ids of the upstream patches in
them, and say what stable tree(s) you wish to have them applied to?
thanks,
greg k-h
next prev parent reply other threads:[~2020-02-20 7:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-20 5:34 [PATCH 0/6] Memory corruption may occur due to incorrent tlb flush Santosh Sivaraj
2020-02-20 5:34 ` [PATCH 1/6] asm-generic/tlb: Track freeing of page-table directories in struct mmu_gather Santosh Sivaraj
2020-02-20 5:34 ` [PATCH 2/6] asm-generic/tlb: Track which levels of the page tables have been cleared Santosh Sivaraj
2020-02-20 5:34 ` [PATCH 3/6] asm-generic/tlb, arch: Invert CONFIG_HAVE_RCU_TABLE_INVALIDATE Santosh Sivaraj
2020-02-20 5:34 ` [PATCH 4/6] powerpc/mmu_gather: enable RCU_TABLE_FREE even for !SMP case Santosh Sivaraj
2020-02-20 5:34 ` [PATCH 5/6] mm/mmu_gather: invalidate TLB correctly on batch allocation failure and flush Santosh Sivaraj
2020-02-20 5:34 ` [PATCH 6/6] asm-generic/tlb: avoid potential double flush Santosh Sivaraj
2020-02-20 7:29 ` Greg KH [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-02-20 8:42 [PATCH 0/6] Memory corruption may occur due to incorrent tlb flush Santosh Sivaraj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200220072934.GA3253157@kroah.com \
--to=gregkh@linuxfoundation$(echo .)org \
--cc=akshay.adiga@linux$(echo .)ibm.com \
--cc=aneesh.kumar@linux$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=peterz@infradead$(echo .)org \
--cc=santosh@fossix$(echo .)org \
--cc=stable@vger$(echo .)kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox