From: Alan Modra <amodra@gmail•com>
To: Michael Ellerman <mpe@ellerman•id.au>
Cc: linuxppc-dev@ozlabs•org, joel@jms•id.au
Subject: Re: [PATCH 1/2] powerpc/vmlinux.lds: Explicitly retain .gnu.hash
Date: Thu, 27 Feb 2020 16:51:47 +1030 [thread overview]
Message-ID: <20200227062147.GC32593@bubble.grove.modra.org> (raw)
In-Reply-To: <20200227045933.22967-1-mpe@ellerman.id.au>
On Thu, Feb 27, 2020 at 03:59:32PM +1100, Michael Ellerman wrote:
> Relocatable kernel builds produce a warning about .gnu.hash being an
> orphan section:
>
> ld: warning: orphan section `.gnu.hash' from `linker stubs' being placed in section `.gnu.hash'
>
> If we try to discard it the build fails:
>
> ld -EL -m elf64lppc -pie --orphan-handling=warn --build-id -o
> .tmp_vmlinux1 -T ./arch/powerpc/kernel/vmlinux.lds --whole-archive
> arch/powerpc/kernel/head_64.o arch/powerpc/kernel/entry_64.o
> ...
> sound/built-in.a net/built-in.a virt/built-in.a --no-whole-archive
> --start-group lib/lib.a --end-group
> ld: could not find section .gnu.hash
>
> So add an entry to explicitly retain it, as we do for .hash.
Looks fine to me. You can also pass --hash-style=sysv to ld (since
binutils-2.18) to disable generation of .gnu.hash.
>
> Signed-off-by: Michael Ellerman <mpe@ellerman•id.au>
> ---
> arch/powerpc/kernel/vmlinux.lds.S | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/powerpc/kernel/vmlinux.lds.S b/arch/powerpc/kernel/vmlinux.lds.S
> index b4c89a1acebb..31a0f201fb6f 100644
> --- a/arch/powerpc/kernel/vmlinux.lds.S
> +++ b/arch/powerpc/kernel/vmlinux.lds.S
> @@ -256,6 +256,7 @@ SECTIONS
> *(.dynamic)
> }
> .hash : AT(ADDR(.hash) - LOAD_OFFSET) { *(.hash) }
> + .gnu.hash : AT(ADDR(.gnu.hash) - LOAD_OFFSET) { *(.gnu.hash) }
> .interp : AT(ADDR(.interp) - LOAD_OFFSET) { *(.interp) }
> .rela.dyn : AT(ADDR(.rela.dyn) - LOAD_OFFSET)
> {
> --
> 2.21.1
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2020-02-27 6:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 4:59 [PATCH 1/2] powerpc/vmlinux.lds: Explicitly retain .gnu.hash Michael Ellerman
2020-02-27 4:59 ` [PATCH 2/2] powerpc/vmlinux.lds: Discard .interp section Michael Ellerman
2020-02-27 6:27 ` Alan Modra
2020-03-27 9:27 ` Michael Ellerman
2020-02-27 6:21 ` Alan Modra [this message]
2020-03-27 9:29 ` [PATCH 1/2] powerpc/vmlinux.lds: Explicitly retain .gnu.hash Michael Ellerman
2020-04-01 12:53 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227062147.GC32593@bubble.grove.modra.org \
--to=amodra@gmail$(echo .)com \
--cc=joel@jms$(echo .)id.au \
--cc=linuxppc-dev@ozlabs$(echo .)org \
--cc=mpe@ellerman$(echo .)id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox