From: Nicolin Chen <nicoleotsuka@gmail•com>
To: Shengjiu Wang <shengjiu.wang@gmail•com>
Cc: Mark Rutland <mark.rutland@arm•com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger•kernel.org>,
Linux-ALSA <alsa-devel@alsa-project•org>,
Timur Tabi <timur@kernel•org>, Xiubo Li <Xiubo.Lee@gmail•com>,
Fabio Estevam <festevam@gmail•com>,
Shengjiu Wang <shengjiu.wang@nxp•com>,
Takashi Iwai <tiwai@suse•com>,
Liam Girdwood <lgirdwood@gmail•com>,
Rob Herring <robh+dt@kernel•org>, Mark Brown <broonie@kernel•org>,
linuxppc-dev@lists•ozlabs.org,
linux-kernel <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH v3 1/4] ASoC: fsl_asrc: Change asrc_width to asrc_format
Date: Thu, 27 Feb 2020 09:45:41 -0800 [thread overview]
Message-ID: <20200227174540.GA17040@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <CAA+D8AMzqpC35_CR2dCG6a_h4FzvZ6orXkPSYh_1o1d8hv+BMg@mail.gmail.com>
On Thu, Feb 27, 2020 at 01:10:19PM +0800, Shengjiu Wang wrote:
> On Thu, Feb 27, 2020 at 11:43 AM Nicolin Chen <nicoleotsuka@gmail•com> wrote:
> >
> > On Thu, Feb 27, 2020 at 10:41:55AM +0800, Shengjiu Wang wrote:
> > > asrc_format is more inteligent variable, which is align
> > > with the alsa definition snd_pcm_format_t.
> > >
> > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp•com>
> > > ---
> > > sound/soc/fsl/fsl_asrc.c | 23 +++++++++++------------
> > > sound/soc/fsl/fsl_asrc.h | 4 ++--
> > > sound/soc/fsl/fsl_asrc_dma.c | 2 +-
> > > 3 files changed, 14 insertions(+), 15 deletions(-)
> > >
> > > diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
> > > index 0dcebc24c312..2b6a1643573c 100644
> > > --- a/sound/soc/fsl/fsl_asrc.c
> > > +++ b/sound/soc/fsl/fsl_asrc.c
> >
> > > @@ -600,11 +599,6 @@ static int fsl_asrc_dai_hw_params(struct snd_pcm_substream *substream,
> > >
> > > pair->config = &config;
> > >
> > > - if (asrc_priv->asrc_width == 16)
> > > - format = SNDRV_PCM_FORMAT_S16_LE;
> > > - else
> > > - format = SNDRV_PCM_FORMAT_S24_LE;
> >
> > It feels better to me that we have format settings in hw_params().
> >
> > Why not let fsl_easrc align with this? Any reason that I'm missing?
>
> because the asrc_width is not formal, in the future we can direct
Hmm..that's our DT binding. And I don't feel it is a problem
to be ASoC irrelative.
> input the format from the dts. format involve the info about width.
Is there such any formal ASoC binding? I don't see those PCM
formats under include/dt-bindings/ folder. How are we going
to involve those formats in DT?
next prev parent reply other threads:[~2020-02-27 17:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 2:41 [PATCH v3 0/4] ASoC: Add new module driver for new ASRC Shengjiu Wang
2020-02-27 2:41 ` [PATCH v3 1/4] ASoC: fsl_asrc: Change asrc_width to asrc_format Shengjiu Wang
2020-02-27 3:41 ` Nicolin Chen
2020-02-27 5:10 ` Shengjiu Wang
2020-02-27 17:45 ` Nicolin Chen [this message]
2020-02-28 2:54 ` Shengjiu Wang
2020-02-28 6:40 ` Nicolin Chen
2020-02-28 6:56 ` Shengjiu Wang
2020-02-27 2:41 ` [PATCH v3 2/4] ASoC: fsl_asrc: Move common definition to fsl_asrc_common Shengjiu Wang
2020-02-27 18:39 ` Nicolin Chen
2020-02-28 6:59 ` Shengjiu Wang
2020-02-27 2:41 ` [PATCH v3 3/4] ASoC: dt-bindings: fsl_easrc: Add document for EASRC Shengjiu Wang
2020-02-27 2:41 ` [PATCH v3 4/4] ASoC: fsl_easrc: Add EASRC ASoC CPU DAI and platform drivers Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227174540.GA17040@Asurada-Nvidia.nvidia.com \
--to=nicoleotsuka@gmail$(echo .)com \
--cc=Xiubo.Lee@gmail$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=shengjiu.wang@gmail$(echo .)com \
--cc=shengjiu.wang@nxp$(echo .)com \
--cc=timur@kernel$(echo .)org \
--cc=tiwai@suse$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox