Subject: Re: [PATCH 1/2] powerpc/smp: Drop superfluous NULL check

From: Srikar Dronamraju <[email-masked]>
Date: Fri, 13 Mar 2020 20:16:50 +0530

* Michael Ellerman <[email-masked]> [2020-03-13 22:20:19]:

> We don't need the NULL check of np, the result is the same because the
> OF helpers cope with NULL, of_node_to_nid(NULL) == NUMA_NO_NODE (-1).
> 

Looks good to me.

Reviewed-by: Srikar Dronamraju <[email-masked]>

> Signed-off-by: Michael Ellerman <[email-masked]>
> ---
>  arch/powerpc/kernel/smp.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/powerpc/kernel/smp.c b/arch/powerpc/kernel/smp.c
> index 37c12e3bab9e..aae61a3b3201 100644
> --- a/arch/powerpc/kernel/smp.c
> +++ b/arch/powerpc/kernel/smp.c
> @@ -1197,11 +1197,8 @@ int get_physical_package_id(int cpu)
>  	 */
>  	if (pkg_id == -1 && firmware_has_feature(FW_FEATURE_LPAR)) {
>  		struct device_node *np = of_get_cpu_node(cpu, NULL);
> -
> -		if (np) {
> -			pkg_id = of_node_to_nid(np);
> -			of_node_put(np);
> -		}
> +		pkg_id = of_node_to_nid(np);
> +		of_node_put(np);
>  	}
>  #endif /* CONFIG_PPC_SPLPAR */
> 
> -- 
> 2.21.1
> 

-- 
Thanks and Regards
Srikar Dronamraju