Subject: Re: [PATCH 4/4] powerpc/numa: Set fallback nodes for offline nodes

From: Srikar Dronamraju <[email-masked]>
Date: Tue, 17 Mar 2020 19:59:26 +0530

* Bharata B Rao <[email-masked]> [2020-03-17 19:52:32]:

Thanks Bharata.

> This patchset can also fix a related problem that I reported earlier at
> https://lists.ozlabs.org/pipermail/linuxppc-dev/2020-March/206076.html
> with an additional change, suggested by Srikar as shown below:
> 
> >  
> > -	for_each_online_node(node) {
> > +	for_each_node(node) {
> > +		/*
> > +		 * For all possible but not yet online nodes, ensure their
> > +		 * node_numa_mem is set correctly so that kmalloc_node works
> > +		 * for such nodes.
> > +		 */
> > +		if (!node_online(node)) {
> 
> Change the above line to like below:
> 
> +               if (!node_state(node, N_MEMORY)) {
> 

Just to clarify, this is needed if we don't have
http://lore.kernel.org/lkml/[email-masked]/t/#u

-- 
Thanks and Regards
Srikar Dronamraju