From: Mahesh J Salgaonkar <mahesh@linux•ibm.com>
To: Ganesh Goudar <ganeshgr@linux•ibm.com>
Cc: santosh@fossix•org, linuxppc-dev@lists•ozlabs.org,
aneesh.kumar@linux•ibm.com, mahesh@linux•vnet.ibm.com
Subject: Re: [PATCH] powerpc/pseries: Handle UE event for memcpy_mcsafe
Date: Fri, 20 Mar 2020 10:53:18 +0530 [thread overview]
Message-ID: <20200320052318.cdxdadfyadsofovd@in.ibm.com> (raw)
In-Reply-To: <20200313140612.8112-1-ganeshgr@linux.ibm.com>
On 2020-03-13 19:36:12 Fri, Ganesh Goudar wrote:
> If we hit UE at an instruction with a fixup entry, flag to
> ignore the event and set nip to continue execution at the
> fixup entry.
> For powernv this changes are already made by commit
> 895e3dceeb97 ("powerpc/mce: Handle UE event for memcpy_mcsafe")
>
> Signed-off-by: Ganesh Goudar <ganeshgr@linux•ibm.com>
Thanks for working on this. Looks good.
Reviewed-by: Mahesh Salgaonkar <mahesh@linux•ibm.com>
Thanks,
-Mahesh.
> ---
> arch/powerpc/platforms/pseries/ras.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/arch/powerpc/platforms/pseries/ras.c b/arch/powerpc/platforms/pseries/ras.c
> index 5d49d9d711da..6dc3074a34c5 100644
> --- a/arch/powerpc/platforms/pseries/ras.c
> +++ b/arch/powerpc/platforms/pseries/ras.c
> @@ -10,6 +10,7 @@
> #include <linux/fs.h>
> #include <linux/reboot.h>
> #include <linux/irq_work.h>
> +#include <linux/extable.h>
>
> #include <asm/machdep.h>
> #include <asm/rtas.h>
> @@ -505,6 +506,7 @@ static int mce_handle_error(struct pt_regs *regs, struct rtas_error_log *errp)
> int initiator = rtas_error_initiator(errp);
> int severity = rtas_error_severity(errp);
> u8 error_type, err_sub_type;
> + const struct exception_table_entry *entry;
>
> if (initiator == RTAS_INITIATOR_UNKNOWN)
> mce_err.initiator = MCE_INITIATOR_UNKNOWN;
> @@ -558,6 +560,12 @@ static int mce_handle_error(struct pt_regs *regs, struct rtas_error_log *errp)
> switch (mce_log->error_type) {
> case MC_ERROR_TYPE_UE:
> mce_err.error_type = MCE_ERROR_TYPE_UE;
> + entry = search_kernel_exception_table(regs->nip);
> + if (entry) {
> + mce_err.ignore_event = true;
> + regs->nip = extable_fixup(entry);
> + disposition = RTAS_DISP_FULLY_RECOVERED;
> + }
> switch (err_sub_type) {
> case MC_ERROR_UE_IFETCH:
> mce_err.u.ue_error_type = MCE_UE_ERROR_IFETCH;
> --
> 2.17.2
>
--
Mahesh J Salgaonkar
prev parent reply other threads:[~2020-03-20 5:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-13 14:06 [PATCH] powerpc/pseries: Handle UE event for memcpy_mcsafe Ganesh Goudar
2020-03-20 5:23 ` Mahesh J Salgaonkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200320052318.cdxdadfyadsofovd@in.ibm.com \
--to=mahesh@linux$(echo .)ibm.com \
--cc=aneesh.kumar@linux$(echo .)ibm.com \
--cc=ganeshgr@linux$(echo .)ibm.com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mahesh@linux$(echo .)vnet.ibm.com \
--cc=santosh@fossix$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox