From: Segher Boessenkool <segher@kernel•crashing.org>
To: Fangrui Song <maskray@google•com>
Cc: Nick Desaulniers <ndesaulniers@google•com>,
linuxppc-dev@lists•ozlabs.org, Joel Stanley <joel@jms•id.au>,
clang-built-linux@googlegroups•com
Subject: Re: [PATCH] powerpc/boot: Delete unneeded .globl _zimage_start
Date: Wed, 25 Mar 2020 01:23:23 -0500 [thread overview]
Message-ID: <20200325062323.GS22482@gate.crashing.org> (raw)
In-Reply-To: <20200325051820.163253-1-maskray@google.com>
On Tue, Mar 24, 2020 at 10:18:20PM -0700, Fangrui Song wrote:
> .globl sets the symbol binding to STB_GLOBAL while .weak sets the
> binding to STB_WEAK. They should not be used together. It is accidetal
> rather then intentional that GNU as let .weak override .globl while
> clang integrated assembler let the last win.
Nothing is "overridden".
The as manual says (.weak):
This directive sets the weak attribute on the comma separated list of
symbol 'names'. If the symbols do not already exist, they will be
created.
so this behaviour is obviously as intended (or was later documented in
any case), so LLVM has a bug to fix (whether you like this (much saner)
behaviour or not).
Segher
next prev parent reply other threads:[~2020-03-25 6:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 5:18 [PATCH] powerpc/boot: Delete unneeded .globl _zimage_start Fangrui Song
2020-03-25 5:22 ` Joel Stanley
2020-03-25 8:37 ` Alan Modra
2020-03-25 16:34 ` Fangrui Song
2020-03-25 6:23 ` Segher Boessenkool [this message]
2020-03-25 10:42 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325062323.GS22482@gate.crashing.org \
--to=segher@kernel$(echo .)crashing.org \
--cc=clang-built-linux@googlegroups$(echo .)com \
--cc=joel@jms$(echo .)id.au \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maskray@google$(echo .)com \
--cc=ndesaulniers@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox