From: Greg Kurz <groug@kaod•org>
To: Michael Ellerman <mpe@ellerman•id.au>
Cc: linuxram@us•ibm.com, paulus@samba•org,
linuxppc-dev@lists•ozlabs.org, kvm-ppc@vger•kernel.org,
Fabiano Rosas <farosas@linux•ibm.com>
Subject: Re: [PATCH] powerpc/prom_init: Include the termination message in ibm,os-term RTAS call
Date: Wed, 25 Mar 2020 11:34:12 +0100 [thread overview]
Message-ID: <20200325113412.1fed2d82@bahia.lan> (raw)
In-Reply-To: <87zhc4wxy9.fsf@mpe.ellerman.id.au>
On Wed, 25 Mar 2020 21:06:22 +1100
Michael Ellerman <mpe@ellerman•id.au> wrote:
> Fabiano Rosas <farosas@linux•ibm.com> writes:
>
> > QEMU can now print the ibm,os-term message[1], so let's include it in
> > the RTAS call. E.g.:
> >
> > qemu-system-ppc64: OS terminated: Switch to secure mode failed.
> >
> > 1- https://git.qemu.org/?p=qemu.git;a=commitdiff;h=a4c3791ae0
> >
> > Signed-off-by: Fabiano Rosas <farosas@linux•ibm.com>
> > ---
> > arch/powerpc/kernel/prom_init.c | 3 +++
> > 1 file changed, 3 insertions(+)
>
> I have this queued:
> https://patchwork.ozlabs.org/patch/1253390/
>
> Which I think does the same thing?
>
Alexey's patch also sets os_term_args.nret as indicated in PAPR.
Even if QEMU's handler for "ibm,os-term" doesn't seem to have
a use for nret, I think it's better to stick to the spec.
Cheers,
--
Greg
> cheers
>
> > diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c
> > index 577345382b23..d543fb6d29c5 100644
> > --- a/arch/powerpc/kernel/prom_init.c
> > +++ b/arch/powerpc/kernel/prom_init.c
> > @@ -1773,6 +1773,9 @@ static void __init prom_rtas_os_term(char *str)
> > if (token == 0)
> > prom_panic("Could not get token for ibm,os-term\n");
> > os_term_args.token = cpu_to_be32(token);
> > + os_term_args.nargs = cpu_to_be32(1);
> > + os_term_args.args[0] = cpu_to_be32(__pa(str));
> > +
> > prom_rtas_hcall((uint64_t)&os_term_args);
> > }
> > #endif /* CONFIG_PPC_SVM */
> > --
> > 2.23.0
next prev parent reply other threads:[~2020-03-25 11:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 20:12 [PATCH] powerpc/prom_init: Include the termination message in ibm, os-term RTAS call Fabiano Rosas
2020-03-25 10:06 ` Michael Ellerman
2020-03-25 10:34 ` Greg Kurz [this message]
2020-03-25 13:24 ` Fabiano Rosas
2020-03-25 13:24 ` [PATCH] powerpc/prom_init: Include the termination message in ibm,os-term " Ram Pai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200325113412.1fed2d82@bahia.lan \
--to=groug@kaod$(echo .)org \
--cc=farosas@linux$(echo .)ibm.com \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=linuxram@us$(echo .)ibm.com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox