From: Jiri Olsa <jolsa@redhat•com>
To: Kajol Jain <kjain@linux•ibm.com>
Cc: mark.rutland@arm•com, maddy@linux•vnet.ibm.com,
peterz@infradead•org, yao.jin@linux•intel.com, mingo@kernel•org,
kan.liang@linux•intel.com, ak@linux•intel.com,
alexander.shishkin@linux•intel.com, anju@linux•vnet.ibm.com,
mamatha4@linux•vnet.ibm.com, sukadev@linux•vnet.ibm.com,
ravi.bangoria@linux•ibm.com, acme@kernel•org, jmario@redhat•com,
namhyung@kernel•org, tglx@linutronix•de, mpetlan@redhat•com,
gregkh@linuxfoundation•org, linux-kernel@vger•kernel.org,
linux-perf-users@vger•kernel.org, jolsa@kernel•org,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v7 3/6] perf/tools: Refactoring metricgroup__add_metric function
Date: Mon, 30 Mar 2020 21:36:44 +0200 [thread overview]
Message-ID: <20200330193644.GF2490231@krava> (raw)
In-Reply-To: <20200327102528.4267-4-kjain@linux.ibm.com>
On Fri, Mar 27, 2020 at 03:55:25PM +0530, Kajol Jain wrote:
SNIP
> + eg->ids = ids;
> + eg->idnum = idnum;
> + eg->metric_name = pe->metric_name;
> + eg->metric_expr = pe->metric_expr;
> + eg->metric_unit = pe->unit;
> + list_add_tail(&eg->nd, group_list);
> +
> + return 0;
> +}
> +
> static int metricgroup__add_metric(const char *metric, struct strbuf *events,
> struct list_head *group_list)
> {
> @@ -504,35 +538,12 @@ static int metricgroup__add_metric(const char *metric, struct strbuf *events,
> continue;
> if (match_metric(pe->metric_group, metric) ||
> match_metric(pe->metric_name, metric)) {
> - const char **ids;
> - int idnum;
> - struct egroup *eg;
>
> pr_debug("metric expr %s for %s\n", pe->metric_expr, pe->metric_name);
>
> - if (expr__find_other(pe->metric_expr,
> - NULL, &ids, &idnum) < 0)
> + ret = __metricgroup__add_metric(events, group_list, pe);
> + if (ret == -EINVAL || !ret)
> continue;
what's the point of continue in here? it's end of the loop..
jirka
next prev parent reply other threads:[~2020-03-30 19:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-27 10:25 [PATCH v7 0/6] powerpc/perf: Add json file metric support for the hv_24x7 socket/chip level events Kajol Jain
2020-03-27 10:25 ` [PATCH v7 1/6] perf expr: Add expr_ prefix for parse_ctx and parse_id Kajol Jain
2020-03-27 10:25 ` [PATCH v7 2/6] perf expr: Add expr_scanner_ctx object Kajol Jain
2020-03-27 10:25 ` [PATCH v7 3/6] perf/tools: Refactoring metricgroup__add_metric function Kajol Jain
2020-03-30 19:36 ` Jiri Olsa
2020-03-30 19:36 ` Jiri Olsa [this message]
2020-03-27 10:25 ` [PATCH v7 4/6] perf/tools: Enhance JSON/metric infrastructure to handle "?" Kajol Jain
2020-03-30 19:35 ` Jiri Olsa
2020-03-30 19:35 ` Jiri Olsa
2020-03-27 10:25 ` [PATCH v7 5/6] tools/perf: Enable Hz/hz prinitg for --metric-only option Kajol Jain
2020-03-27 10:25 ` [PATCH v7 6/6] perf/tools/pmu-events/powerpc: Add hv_24x7 socket/chip level metric events Kajol Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200330193644.GF2490231@krava \
--to=jolsa@redhat$(echo .)com \
--cc=acme@kernel$(echo .)org \
--cc=ak@linux$(echo .)intel.com \
--cc=alexander.shishkin@linux$(echo .)intel.com \
--cc=anju@linux$(echo .)vnet.ibm.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=jmario@redhat$(echo .)com \
--cc=jolsa@kernel$(echo .)org \
--cc=kan.liang@linux$(echo .)intel.com \
--cc=kjain@linux$(echo .)ibm.com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-perf-users@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maddy@linux$(echo .)vnet.ibm.com \
--cc=mamatha4@linux$(echo .)vnet.ibm.com \
--cc=mark.rutland@arm$(echo .)com \
--cc=mingo@kernel$(echo .)org \
--cc=mpetlan@redhat$(echo .)com \
--cc=namhyung@kernel$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=ravi.bangoria@linux$(echo .)ibm.com \
--cc=sukadev@linux$(echo .)vnet.ibm.com \
--cc=tglx@linutronix$(echo .)de \
--cc=yao.jin@linux$(echo .)intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox