From: Nicolin Chen <nicoleotsuka@gmail•com>
To: Shengjiu Wang <shengjiu.wang@nxp•com>
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org,
alsa-devel@alsa-project•org, timur@kernel•org,
Xiubo.Lee@gmail•com, linuxppc-dev@lists•ozlabs.org,
tiwai@suse•com, lgirdwood@gmail•com, robh+dt@kernel•org,
perex@perex•cz, broonie@kernel•org, festevam@gmail•com,
linux-kernel@vger•kernel.org
Subject: Re: [PATCH v6 2/7] ASoC: dt-bindings: fsl_asrc: Add new property fsl,asrc-format
Date: Mon, 6 Apr 2020 15:43:52 -0700 [thread overview]
Message-ID: <20200406224352.GA20891@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <47fcf06689d1a086141ce4d80f7ea7af7958dc89.1585726761.git.shengjiu.wang@nxp.com>
On Wed, Apr 01, 2020 at 04:45:35PM +0800, Shengjiu Wang wrote:
> In order to support new EASRC and simplify the code structure,
> We decide to share the common structure between them. This bring
> a problem that EASRC accept format directly from devicetree, but
> ASRC accept width from devicetree.
>
> In order to align with new ESARC, we add new property fsl,asrc-format.
> The fsl,asrc-format can replace the fsl,asrc-width, then driver
> can accept format from devicetree, don't need to convert it to
> format through width.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp•com>
Once Rob has no objection:
Acked-by: Nicolin Chen <nicoleotsuka@gmail•com>
> ---
> Documentation/devicetree/bindings/sound/fsl,asrc.txt | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,asrc.txt b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> index cb9a25165503..998b4c8a7f78 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> +++ b/Documentation/devicetree/bindings/sound/fsl,asrc.txt
> @@ -51,6 +51,10 @@ Optional properties:
> will be in use as default. Otherwise, the big endian
> mode will be in use for all the device registers.
>
> + - fsl,asrc-format : Defines a mutual sample format used by DPCM Back
> + Ends, which can replace the fsl,asrc-width.
> + The value is 2 (S16_LE), or 6 (S24_LE).
> +
> Example:
>
> asrc: asrc@2034000 {
> --
> 2.21.0
>
next prev parent reply other threads:[~2020-04-06 22:45 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 8:45 [PATCH v6 0/7] ASoC: Add new module driver for new ASRC Shengjiu Wang
2020-04-01 8:45 ` [PATCH v6 1/7] ASoC: fsl_asrc: rename asrc_priv to asrc Shengjiu Wang
2020-04-01 9:00 ` Nicolin Chen
2020-04-01 8:45 ` [PATCH v6 2/7] ASoC: dt-bindings: fsl_asrc: Add new property fsl, asrc-format Shengjiu Wang
2020-04-06 22:43 ` Nicolin Chen [this message]
2020-04-14 15:23 ` [PATCH v6 2/7] ASoC: dt-bindings: fsl_asrc: Add new property fsl,asrc-format Rob Herring
2020-04-01 8:45 ` [PATCH v6 3/7] ASoC: fsl-asoc-card: Support new property fsl, asrc-format Shengjiu Wang
2020-04-06 22:59 ` [PATCH v6 3/7] ASoC: fsl-asoc-card: Support new property fsl,asrc-format Nicolin Chen
2020-04-01 8:45 ` [PATCH v6 4/7] ASoC: fsl_asrc: " Shengjiu Wang
2020-04-06 23:19 ` Nicolin Chen
2020-04-01 8:45 ` [PATCH v6 5/7] ASoC: fsl_asrc: Move common definition to fsl_asrc_common Shengjiu Wang
2020-04-06 23:48 ` Nicolin Chen
2020-04-11 5:49 ` Shengjiu Wang
2020-04-12 2:08 ` Nicolin Chen
2020-04-13 3:16 ` Shengjiu Wang
2020-04-13 4:31 ` Nicolin Chen
2020-04-13 7:19 ` Shengjiu Wang
2020-04-01 8:45 ` [PATCH v6 6/7] ASoC: dt-bindings: fsl_easrc: Add document for EASRC Shengjiu Wang
2020-04-14 15:46 ` Rob Herring
2020-04-15 2:55 ` Shengjiu Wang
2020-04-15 14:11 ` Rob Herring
2020-04-01 8:45 ` [PATCH v6 7/7] ASoC: fsl_easrc: Add EASRC ASoC CPU DAI drivers Shengjiu Wang
2020-04-07 0:29 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200406224352.GA20891@Asurada-Nvidia.nvidia.com \
--to=nicoleotsuka@gmail$(echo .)com \
--cc=Xiubo.Lee@gmail$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=perex@perex$(echo .)cz \
--cc=robh+dt@kernel$(echo .)org \
--cc=shengjiu.wang@nxp$(echo .)com \
--cc=timur@kernel$(echo .)org \
--cc=tiwai@suse$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox