Subject: Re: [PATCH v5 05/21] powerpc: Use a function for getting the instruction op code

From: Segher Boessenkool <[email-masked]>
Date: Wed, 8 Apr 2020 13:21:09 -0500

Hi!

On Mon, Apr 06, 2020 at 06:09:20PM +1000, Jordan Niethe wrote:
> +static inline int ppc_inst_opcode(u32 x)
> +{
> +	return x >> 26;
> +}

Maybe you should have "primary opcode" in this function name?

Segher