From: Nicolin Chen <nicoleotsuka@gmail•com>
To: Shengjiu Wang <shengjiu.wang@gmail•com>
Cc: Mark Rutland <mark.rutland@arm•com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger•kernel.org>,
Linux-ALSA <alsa-devel@alsa-project•org>,
Timur Tabi <timur@kernel•org>, Xiubo Li <Xiubo.Lee@gmail•com>,
Fabio Estevam <festevam@gmail•com>,
Shengjiu Wang <shengjiu.wang@nxp•com>,
Takashi Iwai <tiwai@suse•com>,
Liam Girdwood <lgirdwood@gmail•com>,
Rob Herring <robh+dt@kernel•org>, Mark Brown <broonie@kernel•org>,
linuxppc-dev@lists•ozlabs.org,
linux-kernel <linux-kernel@vger•kernel.org>
Subject: Re: [PATCH v7 5/7] ASoC: fsl_asrc: Move common definition to fsl_asrc_common
Date: Mon, 13 Apr 2020 20:00:17 -0700 [thread overview]
Message-ID: <20200414030017.GA10719@Asurada-Nvidia.nvidia.com> (raw)
In-Reply-To: <CAA+D8AN8OUtTftc_So-Z0_sjWt4RXq6fr4GpSy3Xh+YbkryfpQ@mail.gmail.com>
On Tue, Apr 14, 2020 at 10:21:29AM +0800, Shengjiu Wang wrote:
> On Tue, Apr 14, 2020 at 10:09 AM Nicolin Chen <nicoleotsuka@gmail•com> wrote:
> >
> > On Tue, Apr 14, 2020 at 08:43:07AM +0800, Shengjiu Wang wrote:
> > > There is a new ASRC included in i.MX serial platform, there
> > > are some common definition can be shared with each other.
> > > So move the common definition to a separate header file.
> > >
> > > And add fsl_asrc_pair_priv and fsl_asrc_priv for
> > > the variable specific for the module, which can be used
> > > internally.
> > >
> > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp•com>
> >
> > > diff --git a/sound/soc/fsl/fsl_asrc.c b/sound/soc/fsl/fsl_asrc.c
> > > +static size_t fsl_asrc_get_pair_priv_size(void)
> > > +{
> > > + return sizeof(struct fsl_asrc_pair_priv);
> > > +}
> >
> > Perhaps we haven't understood completely each other's point.
> >
> > Yet, would the following change work?
>
> Should work, almost same
Function call involving branch instruction may fail CPU's branch
prediction and hurt performance, depending on the CPU arch. If a
variable simply does the job, we should avoid doing that.
> or do you want me to use variable to replace function pointer?
Yes. And please add my ack once you change it as the reset LGTM:
Acked-by: Nicolin Chen <nicoleotsuka@gmail•com>
next prev parent reply other threads:[~2020-04-14 3:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-14 0:43 [PATCH v7 0/7] ASoC: Add new module driver for new ASRC Shengjiu Wang
2020-04-14 0:43 ` [PATCH v7 1/7] ASoC: fsl_asrc: rename asrc_priv to asrc Shengjiu Wang
2020-04-14 0:43 ` [PATCH v7 2/7] ASoC: dt-bindings: fsl_asrc: Add new property fsl, asrc-format Shengjiu Wang
2020-04-14 0:43 ` [PATCH v7 3/7] ASoC: fsl-asoc-card: Support " Shengjiu Wang
2020-04-14 0:43 ` [PATCH v7 4/7] ASoC: fsl_asrc: Support new property fsl,asrc-format Shengjiu Wang
2020-04-14 1:52 ` Nicolin Chen
2020-04-14 0:43 ` [PATCH v7 5/7] ASoC: fsl_asrc: Move common definition to fsl_asrc_common Shengjiu Wang
2020-04-14 2:07 ` Nicolin Chen
2020-04-14 2:21 ` Shengjiu Wang
2020-04-14 3:00 ` Nicolin Chen [this message]
2020-04-14 0:43 ` [PATCH v7 6/7] ASoC: dt-bindings: fsl_easrc: Add document for EASRC Shengjiu Wang
2020-04-14 0:43 ` [PATCH v7 7/7] ASoC: fsl_easrc: Add EASRC ASoC CPU DAI drivers Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200414030017.GA10719@Asurada-Nvidia.nvidia.com \
--to=nicoleotsuka@gmail$(echo .)com \
--cc=Xiubo.Lee@gmail$(echo .)com \
--cc=alsa-devel@alsa-project$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=festevam@gmail$(echo .)com \
--cc=lgirdwood@gmail$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=shengjiu.wang@gmail$(echo .)com \
--cc=shengjiu.wang@nxp$(echo .)com \
--cc=timur@kernel$(echo .)org \
--cc=tiwai@suse$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox