From: Cornelia Huck <cohuck@redhat•com>
To: Tianjia Zhang <tianjia.zhang@linux•alibaba.com>
Cc: christoffer.dall@arm•com, wanpengli@tencent•com,
kvm@vger•kernel.org, david@redhat•com, heiko.carstens@de•ibm.com,
peterx@redhat•com, linux-kernel@vger•kernel.org, hpa@zytor•com,
kvmarm@lists•cs.columbia.edu, linux-s390@vger•kernel.org,
frankja@linux•ibm.com, Marc Zyngier <maz@kernel•org>,
joro@8bytes•org, x86@kernel•org, borntraeger@de•ibm.com,
mingo@redhat•com, julien.thierry.kdev@gmail•com,
thuth@redhat•com, gor@linux•ibm.com, suzuki.poulose@arm•com,
kvm-ppc@vger•kernel.org, bp@alien8•de, tglx@linutronix•de,
linux-arm-kernel@lists•infradead.org, jmattson@google•com,
tsbogend@alpha•franken.de, linux-mips@vger•kernel.org,
sean.j.christopherson@intel•com, james.morse@arm•com,
pbonzini@redhat•com, Vitaly Kuznetsov <vkuznets@redhat•com>,
linuxppc-dev@lists•ozlabs.org
Subject: Re: [PATCH v2] KVM: Optimize kvm_arch_vcpu_ioctl_run function
Date: Thu, 16 Apr 2020 10:50:19 +0200 [thread overview]
Message-ID: <20200416105019.51191d79.cohuck@redhat.com> (raw)
In-Reply-To: <8b92fb5b-5138-0695-fb90-6c36b8dfad00@linux.alibaba.com>
On Thu, 16 Apr 2020 16:45:33 +0800
Tianjia Zhang <tianjia.zhang@linux•alibaba.com> wrote:
> On 2020/4/16 16:28, Marc Zyngier wrote:
> > On 2020-04-16 08:03, Vitaly Kuznetsov wrote:
> >> Tianjia Zhang <tianjia.zhang@linux•alibaba.com> writes:
> >>
> >>> In earlier versions of kvm, 'kvm_run' is an independent structure
> >>> and is not included in the vcpu structure. At present, 'kvm_run'
> >>> is already included in the vcpu structure, so the parameter
> >>> 'kvm_run' is redundant.
> >>>
> >>> This patch simplify the function definition, removes the extra
> >>> 'kvm_run' parameter, and extract it from the 'kvm_vcpu' structure
> >>> if necessary.
> >>>
> >>> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux•alibaba.com>
> >>> ---
> >>>
> >>> v2 change:
> >>> remove 'kvm_run' parameter and extract it from 'kvm_vcpu'
> >>>
> >>> arch/mips/kvm/mips.c | 3 ++-
> >>> arch/powerpc/kvm/powerpc.c | 3 ++-
> >>> arch/s390/kvm/kvm-s390.c | 3 ++-
> >>> arch/x86/kvm/x86.c | 11 ++++++-----
> >>> include/linux/kvm_host.h | 2 +-
> >>> virt/kvm/arm/arm.c | 6 +++---
> >>> virt/kvm/kvm_main.c | 2 +-
> >>> 7 files changed, 17 insertions(+), 13 deletions(-)
> > Overall, there is a large set of cleanups to be done when both the vcpu
> > and the run
> > structures are passed as parameters at the same time. Just grepping the
> > tree for
> > kvm_run is pretty instructive.
> >
> > M.
>
> Sorry, it's my mistake, I only compiled the x86 platform, I will submit
> patch again.
I think it's completely fine (and even preferable) to do cleanups like
that on top.
[FWIW, I compiled s390 here.]
next prev parent reply other threads:[~2020-04-16 9:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-16 5:10 [PATCH v2] KVM: Optimize kvm_arch_vcpu_ioctl_run function Tianjia Zhang
2020-04-16 7:03 ` Vitaly Kuznetsov
2020-04-16 8:28 ` Marc Zyngier
2020-04-16 8:45 ` Tianjia Zhang
2020-04-16 8:50 ` Cornelia Huck [this message]
2020-04-16 9:08 ` Tianjia Zhang
2020-04-16 8:58 ` Marc Zyngier
2020-04-16 8:10 ` Cornelia Huck
2020-04-16 14:16 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416105019.51191d79.cohuck@redhat.com \
--to=cohuck@redhat$(echo .)com \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=bp@alien8$(echo .)de \
--cc=christoffer.dall@arm$(echo .)com \
--cc=david@redhat$(echo .)com \
--cc=frankja@linux$(echo .)ibm.com \
--cc=gor@linux$(echo .)ibm.com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=james.morse@arm$(echo .)com \
--cc=jmattson@google$(echo .)com \
--cc=joro@8bytes$(echo .)org \
--cc=julien.thierry.kdev@gmail$(echo .)com \
--cc=kvm-ppc@vger$(echo .)kernel.org \
--cc=kvm@vger$(echo .)kernel.org \
--cc=kvmarm@lists$(echo .)cs.columbia.edu \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=maz@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=pbonzini@redhat$(echo .)com \
--cc=peterx@redhat$(echo .)com \
--cc=sean.j.christopherson@intel$(echo .)com \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=thuth@redhat$(echo .)com \
--cc=tianjia.zhang@linux$(echo .)alibaba.com \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=vkuznets@redhat$(echo .)com \
--cc=wanpengli@tencent$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox