Subject: Re: [PATCH V2 08/11] arch/kmap: Ensure kmap_prot visibility

From: Christoph Hellwig <[email-masked]>
Date: Tue, 5 May 2020 23:13:26 -0700

On Sun, May 03, 2020 at 06:09:09PM -0700, [email-masked] wrote:
> From: Ira Weiny <[email-masked]>
> 
> We want to support kmap_atomic_prot() on all architectures and it makes
> sense to define kmap_atomic() to use the default kmap_prot.
> 
> So we ensure all arch's have a globally available kmap_prot either as a
> define or exported symbol.

FYI, I still think a

#ifndef kmap_prot
#define kmap_prot PAGE_KERNEL
#endif

in linux/highmem.h would be nicer.  Then only xtensa and sparc need
to override it and clearly stand out.