From: Rob Herring <robh@kernel•org>
To: Prakhar Srivastava <prsriva@linux•microsoft.com>
Cc: kstewart@linuxfoundation•org, mark.rutland@arm•com,
gregkh@linuxfoundation•org, bhsharma@redhat•com, tao.li@vivo•com,
zohar@linux•ibm.com, paulus@samba•org, vincenzo.frascino@arm•com,
will@kernel•org, nramas@linux•microsoft.com,
frowand.list@gmail•com, masahiroy@kernel•org, jmorris@namei•org,
takahiro.akashi@linaro•org, linux-arm-kernel@lists•infradead.org,
catalin.marinas@arm•com, serge@hallyn•com,
devicetree@vger•kernel.org, pasha.tatashin@soleen•com,
hsinyi@chromium•org, tusharsu@linux•microsoft.com,
tglx@linutronix•de, allison@lohutok•net, mbrugger@suse•com,
balajib@linux•microsoft.com, dmitry.kasatkin@gmail•com,
linux-kernel@vger•kernel.org,
linux-security-module@vger•kernel.org, james.morse@arm•com,
linux-integrity@vger•kernel.org, linuxppc-dev@lists•ozlabs.org
Subject: Re: [RFC][PATCH 1/2] Add a layer of abstraction to use the memory reserved by device tree for ima buffer pass.
Date: Tue, 12 May 2020 18:09:54 -0500 [thread overview]
Message-ID: <20200512230954.GB2654@bogus> (raw)
In-Reply-To: <20200504203829.6330-2-prsriva@linux.microsoft.com>
On Mon, May 04, 2020 at 01:38:28PM -0700, Prakhar Srivastava wrote:
> Introduce a device tree layer for to read and store ima buffer
> from the reserved memory section of a device tree.
But why do I need 'a layer of abstraction'? I don't like them.
> Signed-off-by: Prakhar Srivastava <prsriva@linux•microsoft.com>
> ---
> drivers/of/Kconfig | 6 ++
> drivers/of/Makefile | 1 +
> drivers/of/of_ima.c | 165 ++++++++++++++++++++++++++++++++++++++++++++
Who are the users of this code and why does it need to be here? Most
code for specific bindings are not in drivers/of/ but with the user. It
doesn't sound like there's more than 1 user.
> include/linux/of.h | 34 +++++++++
> 4 files changed, 206 insertions(+)
> create mode 100644 drivers/of/of_ima.c
next prev parent reply other threads:[~2020-05-12 23:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 20:38 [RFC][PATCH 0/2] Add support for using reserved memory for ima buffer pass Prakhar Srivastava
2020-05-04 20:38 ` [RFC][PATCH 1/2] Add a layer of abstraction to use the memory reserved by device tree " Prakhar Srivastava
2020-05-12 23:09 ` Rob Herring [this message]
2020-05-18 20:34 ` Prakhar Srivastava
2020-05-04 20:38 ` [RFC][PATCH 2/2] Add support for ima buffer pass using reserved memory arm64 Prakhar Srivastava
2020-05-05 9:59 ` [RFC][PATCH 0/2] Add support for using reserved memory for ima buffer pass Mark Rutland
2020-05-07 5:50 ` Prakhar Srivastava
2020-05-12 23:05 ` Rob Herring
2020-05-18 20:16 ` Prakhar Srivastava
2020-05-23 4:08 ` Thiago Jung Bauermann
2020-06-01 4:05 ` Prakhar Srivastava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200512230954.GB2654@bogus \
--to=robh@kernel$(echo .)org \
--cc=allison@lohutok$(echo .)net \
--cc=balajib@linux$(echo .)microsoft.com \
--cc=bhsharma@redhat$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmitry.kasatkin@gmail$(echo .)com \
--cc=frowand.list@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hsinyi@chromium$(echo .)org \
--cc=james.morse@arm$(echo .)com \
--cc=jmorris@namei$(echo .)org \
--cc=kstewart@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-integrity@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-security-module@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=masahiroy@kernel$(echo .)org \
--cc=mbrugger@suse$(echo .)com \
--cc=nramas@linux$(echo .)microsoft.com \
--cc=pasha.tatashin@soleen$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=prsriva@linux$(echo .)microsoft.com \
--cc=serge@hallyn$(echo .)com \
--cc=takahiro.akashi@linaro$(echo .)org \
--cc=tao.li@vivo$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=tusharsu@linux$(echo .)microsoft.com \
--cc=vincenzo.frascino@arm$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=zohar@linux$(echo .)ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox