From: Mike Rapoport <rppt@kernel•org>
To: Matthew Wilcox <willy@infradead•org>
Cc: Rich Felker <dalias@libc•org>,
linux-ia64@vger•kernel.org, linux-sh@vger•kernel.org,
Catalin Marinas <catalin.marinas@arm•com>,
Heiko Carstens <heiko.carstens@de•ibm.com>,
linux-mips@vger•kernel.org, Max Filippov <jcmvbkbc@gmail•com>,
Guo Ren <guoren@kernel•org>,
linux-csky@vger•kernel.org, sparclinux@vger•kernel.org,
linux-hexagon@vger•kernel.org, linux-riscv@lists•infradead.org,
Vincent Chen <deanbo422@gmail•com>, Will Deacon <will@kernel•org>,
Greg Ungerer <gerg@linux-m68k•org>,
linux-arch@vger•kernel.org, linux-s390@vger•kernel.org,
linux-c6x-dev@linux-c6x•org, Brian Cain <bcain@codeaurora•org>,
Helge Deller <deller@gmx•de>,
x86@kernel•org, Russell King <linux@armlinux•org.uk>,
Ley Foon Tan <ley.foon.tan@intel•com>,
Mike Rapoport <rppt@linux•ibm.com>,
Ingo Molnar <mingo@redhat•com>,
Geert Uytterhoeven <geert@linux-m68k•org>,
linux-parisc@vger•kernel.org, Mark Salter <msalter@redhat•com>,
Matt Turner <mattst88@gmail•com>,
linux-snps-arc@lists•infradead.org,
linux-xtensa@linux-xtensa•org, Arnd Bergmann <arnd@arndb•de>,
linux-alpha@vger•kernel.org, linux-um@lists•infradead.org,
linux-m68k@lists•linux-m68k.org, Tony Luck <tony.luck@intel•com>,
Borislav Petkov <bp@alien8•de>, Greentime Hu <green.hu@gmail•com>,
Paul Walmsley <paul.walmsley@sifive•com>,
Stafford Horne <shorne@gmail•com>, Guan Xuetao <gxt@pku•edu.cn>,
linux-arm-kernel@lists•infradead.org,
Chris Zankel <chris@zankel•net>, Michal Simek <monstr@monstr•eu>,
Thomas Bogendoerfer <tsbogend@alpha•franken.de>,
Yoshinori Sato <ysato@users•sourceforge.jp>,
Nick Hu <nickhu@andestech•com>,
linux-mm@kvack•org, Vineet Gupta <vgupta@synopsys•com>,
linux-kernel@vger•kernel.org, openrisc@lists•librecores.org,
Thomas Gleixner <tglx@linutronix•de>,
Richard Weinberger <richard@nod•at>,
Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH 08/12] mm: pgtable: add shortcuts for accessing kernel PMD and PTE
Date: Wed, 13 May 2020 08:23:20 +0300 [thread overview]
Message-ID: <20200513052320.GO14260@kernel.org> (raw)
In-Reply-To: <20200512192441.GZ16070@bombadil.infradead.org>
On Tue, May 12, 2020 at 12:24:41PM -0700, Matthew Wilcox wrote:
> On Tue, May 12, 2020 at 09:44:18PM +0300, Mike Rapoport wrote:
> > +++ b/include/linux/pgtable.h
> > @@ -28,6 +28,24 @@
> > #define USER_PGTABLES_CEILING 0UL
> > #endif
> >
> > +/* FIXME: */
>
> Fix you what? Add documentation?
Ouch, indeed :)
> > +static inline pmd_t *pmd_off(struct mm_struct *mm, unsigned long va)
> > +{
> > + return pmd_offset(pud_offset(p4d_offset(pgd_offset(mm, va), va), va), va);
> > +}
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2020-05-13 5:25 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-12 18:44 [PATCH 00/12] mm: consolidate definitions of page table accessors Mike Rapoport
2020-05-12 18:44 ` [PATCH 01/12] mm: don't include asm/pgtable.h if linux/mm.h is already included Mike Rapoport
2020-05-12 18:44 ` [PATCH 02/12] mm: introduce include/linux/pgtable.h Mike Rapoport
2020-05-12 18:44 ` [PATCH 03/12] mm: reorder includes after introduction of linux/pgtable.h Mike Rapoport
2020-05-12 19:20 ` Matthew Wilcox
2020-05-13 5:21 ` Mike Rapoport
2020-05-12 18:44 ` [PATCH 04/12] csky: replace definitions of __pXd_offset() with pXd_index() Mike Rapoport
2020-05-12 18:44 ` [PATCH 05/12] m68k/mm/motorola: move comment about page table allocation funcitons Mike Rapoport
2020-05-12 18:44 ` [PATCH 06/12] m68k/mm: move {cache, nocahe}_page() definitions close to their user Mike Rapoport
2020-05-13 11:19 ` [PATCH 06/12] m68k/mm: move {cache,nocahe}_page() " Greg Ungerer
2020-05-12 18:44 ` [PATCH 07/12] x86/mm: simplify init_trampoline() and surrounding logic Mike Rapoport
2020-05-12 18:44 ` [PATCH 08/12] mm: pgtable: add shortcuts for accessing kernel PMD and PTE Mike Rapoport
2020-05-12 19:24 ` Matthew Wilcox
2020-05-13 5:23 ` Mike Rapoport [this message]
2020-05-12 18:44 ` [PATCH 09/12] mm: consolidate pte_index() and pte_offset_*() definitions Mike Rapoport
2020-05-12 18:44 ` [PATCH 10/12] mm: consolidate pmd_index() and pmd_offset() definitions Mike Rapoport
2020-05-12 18:44 ` [PATCH 11/12] mm: consolidate pud_index() and pud_offset() definitions Mike Rapoport
2020-05-12 18:44 ` [PATCH 12/12] mm: consolidate pgd_index() and pgd_offset{_k}() definitions Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200513052320.GO14260@kernel.org \
--to=rppt@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=bcain@codeaurora$(echo .)org \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=chris@zankel$(echo .)net \
--cc=dalias@libc$(echo .)org \
--cc=davem@davemloft$(echo .)net \
--cc=deanbo422@gmail$(echo .)com \
--cc=deller@gmx$(echo .)de \
--cc=geert@linux-m68k$(echo .)org \
--cc=gerg@linux-m68k$(echo .)org \
--cc=green.hu@gmail$(echo .)com \
--cc=guoren@kernel$(echo .)org \
--cc=gxt@pku$(echo .)edu.cn \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=ley.foon.tan@intel$(echo .)com \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-c6x-dev@linux-c6x$(echo .)org \
--cc=linux-csky@vger$(echo .)kernel.org \
--cc=linux-hexagon@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-m68k@lists$(echo .)linux-m68k.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux-um@lists$(echo .)infradead.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mattst88@gmail$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=monstr@monstr$(echo .)eu \
--cc=msalter@redhat$(echo .)com \
--cc=nickhu@andestech$(echo .)com \
--cc=openrisc@lists$(echo .)librecores.org \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=richard@nod$(echo .)at \
--cc=rppt@linux$(echo .)ibm.com \
--cc=shorne@gmail$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=vgupta@synopsys$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=willy@infradead$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox