public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel•org>
To: Prakhar Srivastava <prsriva@linux•microsoft.com>
Cc: kstewart@linuxfoundation•org, mark.rutland@arm•com,
	gregkh@linuxfoundation•org, bhsharma@redhat•com, tao.li@vivo•com,
	zohar@linux•ibm.com, paulus@samba•org, vincenzo.frascino@arm•com,
	will@kernel•org, nramas@linux•microsoft.com,
	frowand.list@gmail•com, masahiroy@kernel•org, jmorris@namei•org,
	takahiro.akashi@linaro•org, linux-arm-kernel@lists•infradead.org,
	catalin.marinas@arm•com, serge@hallyn•com,
	devicetree@vger•kernel.org, pasha.tatashin@soleen•com,
	hsinyi@chromium•org, tusharsu@linux•microsoft.com,
	tglx@linutronix•de, allison@lohutok•net, christophe.leroy@c-s•fr,
	mbrugger@suse•com, balajib@linux•microsoft.com,
	dmitry.kasatkin@gmail•com, linux-kernel@vger•kernel.org,
	linux-security-module@vger•kernel.org, james.morse@arm•com,
	linux-integrity@vger•kernel.org, linuxppc-dev@lists•ozlabs.org
Subject: Re: [v1 PATCH 2/2] Add Documentation regarding the ima-kexec-buffer node in the chosen node documentation
Date: Wed, 17 Jun 2020 14:43:24 -0600	[thread overview]
Message-ID: <20200617204324.GA2740878@bogus> (raw)
In-Reply-To: <20200607233323.22375-3-prsriva@linux.microsoft.com>

On Sun, Jun 07, 2020 at 04:33:23PM -0700, Prakhar Srivastava wrote:
> Add Documentation regarding the ima-kexec-buffer node in
>  the chosen node documentation

Run 'git log --oneline Documentation/devicetree/bindings/chosen.txt' and 
write $subject using the dominate format used.

For the commit message, answer why you need the change, not what the 
change is. I can read the diff for that.

>  
> Signed-off-by: Prakhar Srivastava <prsriva@linux•microsoft.com>
> ---
>  Documentation/devicetree/bindings/chosen.txt | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)

This file has moved to a schema here[1]. You need to update it.

> 
> diff --git a/Documentation/devicetree/bindings/chosen.txt b/Documentation/devicetree/bindings/chosen.txt
> index 45e79172a646..a15f70c007ef 100644
> --- a/Documentation/devicetree/bindings/chosen.txt
> +++ b/Documentation/devicetree/bindings/chosen.txt
> @@ -135,3 +135,20 @@ e.g.
>  		linux,initrd-end = <0x82800000>;
>  	};
>  };
> +
> +linux,ima-kexec-buffer
> +----------------------
> +
> +This property(currently used by powerpc, arm64) holds the memory range,
> +the address and the size, of the IMA measurement logs that are being carried
> +over to the kexec session.

What's IMA? 

> +
> +/ {
> +	chosen {
> +		linux,ima-kexec-buffer = <0x9 0x82000000 0x0 0x00008000>;
> +	};
> +};
> +
> +This porperty does not represent real hardware, but the memory allocated for

typo

> +carrying the IMA measurement logs. The address and the suze are expressed in

typo

> +#address-cells and #size-cells, respectively of the root node.
> -- 
> 2.25.1
> 


[1] https://github.com/devicetree-org/dt-schema/blob/master/schemas/chosen.yaml


      reply	other threads:[~2020-06-17 20:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-07 23:33 [v1 PATCH 0/2] Adding support to carry IMA measurement logs Prakhar Srivastava
2020-06-07 23:33 ` [v1 PATCH 1/2] Refactoring carrying over IMA measuremnet logs over Kexec Prakhar Srivastava
2020-06-08  1:35   ` kernel test robot
2020-06-08  1:47   ` kernel test robot
2020-06-08  2:29   ` kernel test robot
2020-06-08 12:02   ` Mimi Zohar
2020-06-07 23:33 ` [v1 PATCH 2/2] Add Documentation regarding the ima-kexec-buffer node in the chosen node documentation Prakhar Srivastava
2020-06-17 20:43   ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200617204324.GA2740878@bogus \
    --to=robh@kernel$(echo .)org \
    --cc=allison@lohutok$(echo .)net \
    --cc=balajib@linux$(echo .)microsoft.com \
    --cc=bhsharma@redhat$(echo .)com \
    --cc=catalin.marinas@arm$(echo .)com \
    --cc=christophe.leroy@c-s$(echo .)fr \
    --cc=devicetree@vger$(echo .)kernel.org \
    --cc=dmitry.kasatkin@gmail$(echo .)com \
    --cc=frowand.list@gmail$(echo .)com \
    --cc=gregkh@linuxfoundation$(echo .)org \
    --cc=hsinyi@chromium$(echo .)org \
    --cc=james.morse@arm$(echo .)com \
    --cc=jmorris@namei$(echo .)org \
    --cc=kstewart@linuxfoundation$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-integrity@vger$(echo .)kernel.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-security-module@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=mark.rutland@arm$(echo .)com \
    --cc=masahiroy@kernel$(echo .)org \
    --cc=mbrugger@suse$(echo .)com \
    --cc=nramas@linux$(echo .)microsoft.com \
    --cc=pasha.tatashin@soleen$(echo .)com \
    --cc=paulus@samba$(echo .)org \
    --cc=prsriva@linux$(echo .)microsoft.com \
    --cc=serge@hallyn$(echo .)com \
    --cc=takahiro.akashi@linaro$(echo .)org \
    --cc=tao.li@vivo$(echo .)com \
    --cc=tglx@linutronix$(echo .)de \
    --cc=tusharsu@linux$(echo .)microsoft.com \
    --cc=vincenzo.frascino@arm$(echo .)com \
    --cc=will@kernel$(echo .)org \
    --cc=zohar@linux$(echo .)ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox