From: Mike Rapoport <rppt@linux•ibm.com>
To: Anshuman Khandual <anshuman.khandual@arm•com>
Cc: Mark Rutland <mark.rutland@arm•com>,
Michal Hocko <mhocko@suse•com>,
linux-ia64@vger•kernel.org, David Hildenbrand <david@redhat•com>,
Peter Zijlstra <peterz@infradead•org>,
Dave Hansen <dave.hansen@linux•intel.com>,
linux-mm@kvack•org, Paul Mackerras <paulus@samba•org>,
linux-riscv@lists•infradead.org, Will Deacon <will@kernel•org>,
Thomas Gleixner <tglx@linutronix•de>,
x86@kernel•org, "Matthew Wilcox \(Oracle\)" <willy@infradead•org>,
Ingo Molnar <mingo@redhat•com>,
Catalin Marinas <catalin.marinas@arm•com>,
Fenghua Yu <fenghua.yu@intel•com>,
Pavel Tatashin <pasha.tatashin@soleen•com>,
Andy Lutomirski <luto@kernel•org>,
Paul Walmsley <paul.walmsley@sifive•com>,
Dan Williams <dan.j.williams@intel•com>,
linux-arm-kernel@lists•infradead.org,
Tony Luck <tony.luck@intel•com>,
linux-kernel@vger•kernel.org, Palmer Dabbelt <palmer@dabbelt•com>,
Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org,
"Kirill A. Shutemov" <kirill.shutemov@linux•intel.com>
Subject: Re: [PATCH V3 (RESEND) 0/3] arm64: Enable vmemmap mapping from device memory
Date: Thu, 18 Jun 2020 11:56:41 +0300 [thread overview]
Message-ID: <20200618085641.GE6493@linux.ibm.com> (raw)
In-Reply-To: <1592442930-9380-1-git-send-email-anshuman.khandual@arm.com>
On Thu, Jun 18, 2020 at 06:45:27AM +0530, Anshuman Khandual wrote:
> This series enables vmemmap backing memory allocation from device memory
> ranges on arm64. But before that, it enables vmemmap_populate_basepages()
> and vmemmap_alloc_block_buf() to accommodate struct vmem_altmap based
> alocation requests.
>
> This series applies on 5.8-rc1.
>
> Pending Question:
>
> altmap_alloc_block_buf() does not have any other remaining users in
> the tree after this change. Should it be converted into a static
> function and it's declaration be dropped from the header
> (include/linux/mm.h). Avoided doing so because I was not sure if there
> are any off-tree users or not.
Well, off-tree users probably have an active fork anyway so they could
switch to vmemmap_alloc_block_buf()...
Regardless, can you please update Documentation/vm/memory-model.rst to
keep it in sync with the code?
> Changes in V3:
>
> - Dropped comment from free_hotplug_page_range() per Robin
> - Modified comment in unmap_hotplug_range() per Robin
> - Enabled altmap support in vmemmap_alloc_block_buf() per Robin
>
> Changes in V2: (https://lkml.org/lkml/2020/3/4/475)
>
> - Rebased on latest hot-remove series (v14) adding P4D page table support
>
> Changes in V1: (https://lkml.org/lkml/2020/1/23/12)
>
> - Added an WARN_ON() in unmap_hotplug_range() when altmap is
> provided without the page table backing memory being freed
>
> Changes in RFC V2: (https://lkml.org/lkml/2019/10/21/11)
>
> - Changed the commit message on 1/2 patch per Will
> - Changed the commit message on 2/2 patch as well
> - Rebased on arm64 memory hot remove series (v10)
>
> RFC V1: (https://lkml.org/lkml/2019/6/28/32)
>
> Cc: Catalin Marinas <catalin.marinas@arm•com>
> Cc: Will Deacon <will@kernel•org>
> Cc: Mark Rutland <mark.rutland@arm•com>
> Cc: Paul Walmsley <paul.walmsley@sifive•com>
> Cc: Palmer Dabbelt <palmer@dabbelt•com>
> Cc: Tony Luck <tony.luck@intel•com>
> Cc: Fenghua Yu <fenghua.yu@intel•com>
> Cc: Dave Hansen <dave.hansen@linux•intel.com>
> Cc: Andy Lutomirski <luto@kernel•org>
> Cc: Peter Zijlstra <peterz@infradead•org>
> Cc: Thomas Gleixner <tglx@linutronix•de>
> Cc: Ingo Molnar <mingo@redhat•com>
> Cc: David Hildenbrand <david@redhat•com>
> Cc: Mike Rapoport <rppt@linux•ibm.com>
> Cc: Michal Hocko <mhocko@suse•com>
> Cc: "Matthew Wilcox (Oracle)" <willy@infradead•org>
> Cc: "Kirill A. Shutemov" <kirill.shutemov@linux•intel.com>
> Cc: Andrew Morton <akpm@linux-foundation•org>
> Cc: Dan Williams <dan.j.williams@intel•com>
> Cc: Pavel Tatashin <pasha.tatashin@soleen•com>
> Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> Cc: Paul Mackerras <paulus@samba•org>
> Cc: Michael Ellerman <mpe@ellerman•id.au>
> Cc: linux-arm-kernel@lists•infradead.org
> Cc: linux-ia64@vger•kernel.org
> Cc: linux-riscv@lists•infradead.org
> Cc: x86@kernel•org
> Cc: linuxppc-dev@lists•ozlabs.org
> Cc: linux-mm@kvack•org
> Cc: linux-kernel@vger•kernel.org
>
> Anshuman Khandual (3):
> mm/sparsemem: Enable vmem_altmap support in vmemmap_populate_basepages()
> mm/sparsemem: Enable vmem_altmap support in vmemmap_alloc_block_buf()
> arm64/mm: Enable vmem_altmap support for vmemmap mappings
>
> arch/arm64/mm/mmu.c | 59 ++++++++++++++++++++++++++-------------
> arch/ia64/mm/discontig.c | 2 +-
> arch/powerpc/mm/init_64.c | 10 +++----
> arch/riscv/mm/init.c | 2 +-
> arch/x86/mm/init_64.c | 12 ++++----
> include/linux/mm.h | 8 ++++--
> mm/sparse-vmemmap.c | 38 ++++++++++++++++++++-----
> 7 files changed, 87 insertions(+), 44 deletions(-)
>
> --
> 2.20.1
>
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2020-06-18 8:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 1:15 [PATCH V3 (RESEND) 0/3] arm64: Enable vmemmap mapping from device memory Anshuman Khandual
2020-06-18 1:15 ` [PATCH V3 (RESEND) 2/3] mm/sparsemem: Enable vmem_altmap support in vmemmap_alloc_block_buf() Anshuman Khandual
2020-07-02 14:07 ` Catalin Marinas
2020-07-03 6:32 ` Anshuman Khandual
2020-07-03 10:43 ` Michael Ellerman
2020-06-18 8:56 ` Mike Rapoport [this message]
2020-06-19 1:34 ` [PATCH V3 (RESEND) 0/3] arm64: Enable vmemmap mapping from device memory Anshuman Khandual
2020-06-23 7:39 ` Jia He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618085641.GE6493@linux.ibm.com \
--to=rppt@linux$(echo .)ibm.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anshuman.khandual@arm$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=dan.j.williams@intel$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=david@redhat$(echo .)com \
--cc=fenghua.yu@intel$(echo .)com \
--cc=kirill.shutemov@linux$(echo .)intel.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=luto@kernel$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mhocko@suse$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=pasha.tatashin@soleen$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=willy@infradead$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox