Subject: Re: [PATCH 05/18] powerpc/numa: make vphn_enabled, prrn_enabled flags const

From: Srikar Dronamraju <[email-masked]>
Date: Tue, 23 Jun 2020 21:54:44 +0530

* Nathan Lynch <[email-masked]> [2020-06-12 00:12:25]:

> Previous changes have made it so these flags are never changed;
> enforce this by making them const.
> 
> Signed-off-by: Nathan Lynch <[email-masked]>
> ---

Looks good to me.

Reviewed-by: Srikar Dronamraju <[email-masked]>

>  arch/powerpc/mm/numa.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
> index 9e20f12e6caf..1b89bacb8975 100644
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@ -1132,8 +1132,8 @@ struct topology_update_data {
>  #define TOPOLOGY_DEF_TIMER_SECS	60
> 
>  static cpumask_t cpu_associativity_changes_mask;
> -static int vphn_enabled;
> -static int prrn_enabled;
> +static const int vphn_enabled;
> +static const int prrn_enabled;
>  static void reset_topology_timer(void);
>  static int topology_timer_secs = 1;
>  static int topology_inited;
> -- 
> 2.25.4
> 

-- 
Thanks and Regards
Srikar Dronamraju