Subject: Re: [PATCH 12/18] powerpc/rtasd: simplify handle_rtas_event(), emit message on events

From: Srikar Dronamraju <[email-masked]>
Date: Tue, 23 Jun 2020 22:00:48 +0530

* Nathan Lynch <[email-masked]> [2020-06-12 00:12:32]:

> prrn_is_enabled() always returns false/0, so handle_rtas_event() can
> be simplified and some dead code can be removed. Use machine_is()
> instead of #ifdef to run this code only on pseries, and add an
> informational ratelimited message that we are ignoring the
> events. PRRN events are relatively rare in normal operation and
> usually arise from operator-initiated actions such as a DPO (Dynamic
> Platform Optimizer) run.
> 
> Eventually we do want to consume these events and update the device
> tree, but that needs more care to be safe vs LPM and DLPAR.
> 
> Signed-off-by: Nathan Lynch <[email-masked]>
> ---
>  arch/powerpc/kernel/rtasd.c | 28 +++-------------------------
>  1 file changed, 3 insertions(+), 25 deletions(-)
> 

Looks good to me.

Reviewed-by: Srikar Dronamraju <[email-masked]>
-- 
Thanks and Regards
Srikar Dronamraju