From: Catalin Marinas <catalin.marinas@arm•com>
To: Anshuman Khandual <anshuman.khandual@arm•com>
Cc: x86@kernel•org, justin.he@arm•com, linux-doc@vger•kernel.org,
Jonathan Corbet <corbet@lwn•net>,
Peter Zijlstra <peterz@infradead•org>,
Dave Hansen <dave.hansen@linux•intel.com>,
"H. Peter Anvin" <hpa@zytor•com>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
linux-mm@kvack•org, Ingo Molnar <mingo@redhat•com>,
Paul Mackerras <paulus@samba•org>,
Andy Lutomirski <luto@kernel•org>, Borislav Petkov <bp@alien8•de>,
akpm@linux-foundation•org, Will Deacon <will@kernel•org>,
Thomas Gleixner <tglx@linutronix•de>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH V4 2/3] mm/sparsemem: Enable vmem_altmap support in vmemmap_alloc_block_buf()
Date: Wed, 8 Jul 2020 14:25:20 +0100 [thread overview]
Message-ID: <20200708132520.GD6308@gaia> (raw)
In-Reply-To: <1594004178-8861-3-git-send-email-anshuman.khandual@arm.com>
On Mon, Jul 06, 2020 at 08:26:17AM +0530, Anshuman Khandual wrote:
> There are many instances where vmemap allocation is often switched between
> regular memory and device memory just based on whether altmap is available
> or not. vmemmap_alloc_block_buf() is used in various platforms to allocate
> vmemmap mappings. Lets also enable it to handle altmap based device memory
> allocation along with existing regular memory allocations. This will help
> in avoiding the altmap based allocation switch in many places. To summarize
> there are two different methods to call vmemmap_alloc_block_buf().
>
> vmemmap_alloc_block_buf(size, node, NULL) /* Allocate from system RAM */
> vmemmap_alloc_block_buf(size, node, altmap) /* Allocate from altmap */
>
> This converts altmap_alloc_block_buf() into a static function, drops it's
s/it's/its/
> entry from the header and updates Documentation/vm/memory-model.rst.
>
> Cc: Jonathan Corbet <corbet@lwn•net>
> Cc: Catalin Marinas <catalin.marinas@arm•com>
> Cc: Will Deacon <will@kernel•org>
> Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> Cc: Paul Mackerras <paulus@samba•org>
> Cc: Michael Ellerman <mpe@ellerman•id.au>
> Cc: Dave Hansen <dave.hansen@linux•intel.com>
> Cc: Andy Lutomirski <luto@kernel•org>
> Cc: Peter Zijlstra <peterz@infradead•org>
> Cc: Thomas Gleixner <tglx@linutronix•de>
> Cc: Ingo Molnar <mingo@redhat•com>
> Cc: Borislav Petkov <bp@alien8•de>
> Cc: "H. Peter Anvin" <hpa@zytor•com>
> Cc: Andrew Morton <akpm@linux-foundation•org>
> Cc: linux-doc@vger•kernel.org
> Cc: x86@kernel•org
> Cc: linux-arm-kernel@lists•infradead.org
> Cc: linuxppc-dev@lists•ozlabs.org
> Cc: linux-mm@kvack•org
> Cc: linux-kernel@vger•kernel.org
> Tested-by: Jia He <justin.he@arm•com>
> Suggested-by: Robin Murphy <robin.murphy@arm•com>
> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm•com>
With the fallback argument dropped, the patch looks fine to me.
Reviewed-by: Catalin Marinas <catalin.marinas@arm•com>
next prev parent reply other threads:[~2020-07-08 13:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 2:56 [PATCH V4 0/3] arm64: Enable vmemmap mapping from device memory Anshuman Khandual
2020-07-06 2:56 ` [PATCH V4 2/3] mm/sparsemem: Enable vmem_altmap support in vmemmap_alloc_block_buf() Anshuman Khandual
2020-07-08 13:25 ` Catalin Marinas [this message]
2020-07-09 3:30 ` [PATCH V4 0/3] arm64: Enable vmemmap mapping from device memory Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708132520.GD6308@gaia \
--to=catalin.marinas@arm$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=anshuman.khandual@arm$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=corbet@lwn$(echo .)net \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=hpa@zytor$(echo .)com \
--cc=justin.he@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-doc@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=luto@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox