From: Segher Boessenkool <segher@kernel•crashing.org>
To: Mathieu Desnoyers <mathieu.desnoyers@efficios•com>
Cc: Boqun Feng <boqun.feng@gmail•com>,
linuxppc-dev <linuxppc-dev@lists•ozlabs.org>,
Michael Jeanson <mjeanson@efficios•com>
Subject: Re: Failure to build librseq on ppc
Date: Wed, 8 Jul 2020 19:10:03 -0500 [thread overview]
Message-ID: <20200709001003.GB3598@gate.crashing.org> (raw)
In-Reply-To: <1623833219.1877.1594216801865.JavaMail.zimbra@efficios.com>
Hi!
On Wed, Jul 08, 2020 at 10:00:01AM -0400, Mathieu Desnoyers wrote:
> >> So perhaps you have code like
> >>
> >> int *p;
> >> int x;
> >> ...
> >> asm ("lwz %0,%1" : "=r"(x) : "m"(*p));
> >
> > We indeed have explicit "lwz" and "stw" instructions in there.
> >
> >>
> >> where that last line should actually read
> >>
> >> asm ("lwz%X1 %0,%1" : "=r"(x) : "m"(*p));
> >
> > Indeed, turning those into "lwzx" and "stwx" seems to fix the issue.
> >
> > There has been some level of extra CPP macro coating around those instructions
> > to
> > support both ppc32 and ppc64 with the same assembly. So adding %X[arg] is not
> > trivial.
> > Let me see what can be done here.
>
> I did the following changes which appear to generate valid asm.
> See attached corresponding .S output.
>
> I grepped for uses of "m" asm operand in Linux powerpc code and noticed it's pretty much
> always used with e.g. "lwz%U1%X1". I could find one blog post discussing that %U is about
> update flag, and nothing about %X. Are those documented ?
Historically, no machine-specific output modifiers were documented.
For GCC 10 i added a few (in
https://gcc.gnu.org/onlinedocs/gcc-10.1.0/gcc/Machine-Constraints.html#Machine-Constraints
), but not all (that user code should use!) yet.
> Although it appears to generate valid asm, I have the feeling I'm relying on undocumented
> features here. :-/
It is supported for 30 years or so now. GCC itself uses this a *lot*
internally as well. It works, and it will work forever.
> -#define STORE_WORD "std "
> -#define LOAD_WORD "ld "
> -#define LOADX_WORD "ldx "
> +#define STORE_WORD(arg) "std%U[" __rseq_str(arg) "]%X[" __rseq_str(arg) "] " /* To memory ("m" constraint) */
> +#define LOAD_WORD(arg) "lwd%U[" __rseq_str(arg) "]%X[" __rseq_str(arg) "] " /* From memory ("m" constraint) */
That cannot work (you typoed "ld" here).
Some more advice about this code, pretty generic stuff:
The way this all uses r17 will likely not work reliably.
The way multiple asm statements are used seems to have missing
dependencies between the statements.
Don't try to work *against* the compiler. You will not win.
Alternatively, write assembler code, if that is what you actually want
to do? Not C code.
And done macro-mess this, you want to be able to debug it, and you need
other people to be able to read it!
Segher
next prev parent reply other threads:[~2020-07-09 0:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 19:17 Failure to build librseq on ppc Mathieu Desnoyers
2020-07-08 0:59 ` Segher Boessenkool
2020-07-08 12:27 ` Michael Ellerman
2020-07-08 23:53 ` Segher Boessenkool
2020-07-09 0:01 ` Mathieu Desnoyers
2020-07-09 0:18 ` Segher Boessenkool
2020-07-09 13:43 ` Mathieu Desnoyers
2020-07-09 17:37 ` Segher Boessenkool
2020-07-09 17:42 ` Mathieu Desnoyers
2020-07-09 17:56 ` Mathieu Desnoyers
2020-07-09 20:46 ` Segher Boessenkool
2020-07-09 20:57 ` Mathieu Desnoyers
2020-07-09 20:31 ` Segher Boessenkool
2020-07-08 12:33 ` Mathieu Desnoyers
2020-07-08 14:00 ` Mathieu Desnoyers
2020-07-08 14:21 ` Christophe Leroy
2020-07-08 14:32 ` Mathieu Desnoyers
2020-07-08 16:11 ` Christophe Leroy
2020-07-09 0:15 ` Segher Boessenkool
2020-07-09 0:10 ` Segher Boessenkool [this message]
2020-07-09 13:33 ` Mathieu Desnoyers
2020-07-09 17:31 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709001003.GB3598@gate.crashing.org \
--to=segher@kernel$(echo .)crashing.org \
--cc=boqun.feng@gmail$(echo .)com \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mathieu.desnoyers@efficios$(echo .)com \
--cc=mjeanson@efficios$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox