From: Jessica Yu <jeyu@kernel•org>
To: Jarkko Sakkinen <jarkko.sakkinen@linux•intel.com>
Cc: Catalin Marinas <catalin.marinas@arm•com>,
Kefeng Wang <wangkefeng.wang@huawei•com>,
Paul Mackerras <paulus@samba•org>, Zong Li <zong.li@sifive•com>,
Andi Kleen <ak@linux•intel.com>,
Paul Burton <paulburton@kernel•org>,
Vincent Whitchurch <vincent.whitchurch@axis•com>,
Petr Mladek <pmladek@suse•com>, Brian Gerst <brgerst@gmail•com>,
Andy Lutomirski <luto@kernel•org>,
Thomas Gleixner <tglx@linutronix•de>,
Jiri Kosina <jkosina@suse•cz>, Anup Patel <anup.patel@wdc•com>,
Linux Kernel Mailing List <linux-kernel@vger•kernel.org>,
Philipp Rudo <prudo@linux•ibm.com>, Torsten Duwe <duwe@lst•de>,
Masami Hiramatsu <mhiramat@kernel•org>,
Andrew Morton <akpm@linux-foundation•org>,
Mark Rutland <mark.rutland@arm•com>,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership•com>,
Vincent Chen <deanbo422@gmail•com>,
Omar Sandoval <osandov@fb•com>,
"open list:S390" <linux-s390@vger•kernel.org>,
Joe Lawrence <joe.lawrence@redhat•com>,
Helge Deller <deller@gmx•de>,
John Fastabend <john.fastabend@gmail•com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@intel•com>,
Yonghong Song <yhs@fb•com>, Iurii Zaikin <yzaikin@google•com>,
Andrii Nakryiko <andriin@fb•com>, Thomas Huth <thuth@redhat•com>,
Vasily Gorbik <gor@linux•ibm.com>,
"moderated list:ARM PORT" <linux-arm-kernel@lists•infradead.org>,
Daniel Axtens <dja@axtens•net>,
Damien Le Moal <damien.lemoal@wdc•com>,
Martin KaFai Lau <kafai@fb•com>, Song Liu <songliubraving@fb•com>,
Josh Poimboeuf <jpoimboe@redhat•com>,
Heiko Carstens <heiko.carstens@de•ibm.com>,
Alexei Starovoitov <ast@kernel•org>,
Atish Patra <atish.patra@wdc•com>, Will Deacon <will@kernel•org>,
Daniel Borkmann <daniel@iogearbox•net>,
Masahiro Yamada <masahiroy@kernel•org>,
Nayna Jain <nayna@linux•ibm.com>,
Ley Foon Tan <ley.foon.tan@intel•com>,
Christian Borntraeger <borntraeger@de•ibm.com>,
Sami Tolvanen <samitolvanen@google•com>,
"Naveen N. Rao" <naveen.n.rao@linux•ibm.com>,
Mao Han <han_mao@c-sky•com>, Marco Elver <elver@google•com>,
Steven Rostedt <rostedt@goodmis•org>,
Babu Moger <Babu.Moger@amd•com>, Borislav Petkov <bp@alien8•de>,
Greentime Hu <green.hu@gmail•com>,
Ben Dooks <ben-linux@fluff•org>, Guan Xuetao <gxt@pku•edu.cn>,
Tiezhu Yang <yangtiezhu@loongson•cn>,
Thomas Bogendoerfer <tsbogend@alpha•franken.de>,
"open list:PARISC ARCHITECTURE" <linux-parisc@vger•kernel.org>,
"open list:BPF JIT for MIPS 32-BIT AND 64-BIT"
<bpf@vger•kernel.org>, "David S. Miller" <davem@davemloft•net>,
Thiago Jung Bauermann <bauerman@linux•ibm.com>,
Peter Zijlstra <peterz@infradead•org>,
David Howells <dhowells@redhat•com>,
Amit Daniel Kachhap <amit.kachhap@arm•com>,
Sandipan Das <sandipan@linux•ibm.com>,
"H. Peter Anvin" <hpa@zytor•com>,
"open list:SPARC + UltraSPARC sparc/sparc64"
<sparclinux@vger•kernel.org>,
"open list:RISC-V ARCHITECTURE" <linux-riscv@lists•infradead.org>,
Miroslav Benes <mbenes@suse•cz>, Jiri Olsa <jolsa@redhat•com>,
Ard Biesheuvel <ardb@kernel•org>,
Vincenzo Frascino <vincenzo.frascino@arm•com>,
Anders Roxell <anders.roxell@linaro•org>,
Sven Schnelle <svens@stackframe•org>,
"maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT" <x86@kernel•org>,
Russell King <linux@armlinux•org.uk>,
Mike Rapoport <rppt@linux•ibm.com>,
Ingo Molnar <mingo@redhat•com>, Albert Ou <aou@eecs•berkeley.edu>,
"Paul E. McKenney" <paulmck@kernel•org>,
Paul Walmsley <paul.walmsley@sifive•com>,
KP Singh <kpsingh@chromium•org>,
Dmitry Vyukov <dvyukov@google•com>,
Nick Hu <nickhu@andestech•com>,
"open list:BPF JIT for MIPS 32-BIT AND 64-BIT"
<netdev@vger•kernel.org>,
"open list:MIPS" <linux-mips@vger•kernel.org>,
Palmer Dabbelt <palmer@dabbelt•com>,
"open list:LINUX FOR POWERPC 32-BIT AND 64-BIT"
<linuxppc-dev@lists•ozlabs.org>
Subject: Re: [PATCH v2 1/3] module: Rename module_alloc() to text_alloc() and move to kernel proper
Date: Fri, 24 Jul 2020 10:05:08 +0200 [thread overview]
Message-ID: <20200724080508.GA17719@linux-8ccs> (raw)
In-Reply-To: <20200724073621.GC1872662@linux.intel.com>
+++ Jarkko Sakkinen [24/07/20 10:36 +0300]:
>On Thu, Jul 23, 2020 at 03:42:09PM +0300, Ard Biesheuvel wrote:
>> On Thu, 23 Jul 2020 at 04:52, Jarkko Sakkinen
>> <jarkko.sakkinen@linux•intel.com> wrote:
>> >
>> > On Thu, Jul 16, 2020 at 06:49:09PM +0200, Christophe Leroy wrote:
>> > > Jarkko Sakkinen <jarkko.sakkinen@linux•intel.com> a écrit :
>> > >
>> > > > Rename module_alloc() to text_alloc() and module_memfree() to
>> > > > text_memfree(), and move them to kernel/text.c, which is unconditionally
>> > > > compiled to the kernel proper. This allows kprobes, ftrace and bpf to
>> > > > allocate space for executable code without requiring to compile the modules
>> > > > support (CONFIG_MODULES=y) in.
>> > >
>> > > You are not changing enough in powerpc to have this work.
>> > > On powerpc 32 bits (6xx), when STRICT_KERNEL_RWX is selected, the vmalloc
>> > > space is set to NX (no exec) at segment level (ie by 256Mbytes zone) unless
>> > > CONFIG_MODULES is selected.
>> > >
>> > > Christophe
>> >
>> > This has been deduced down to:
>> >
>> > https://lore.kernel.org/lkml/20200717030422.679972-1-jarkko.sakkinen@linux.intel.com/
>> >
>> > I.e. not intruding PPC anymore :-)
>> >
>>
>> Ok, so after the elaborate discussion we had between Jessica, Russell,
>> Peter, Will, Mark, you and myself, where we pointed out that
>> a) a single text_alloc() abstraction for bpf, kprobes and ftrace does
>> not fit other architectures very well, and
>> b) that module_alloc() is not suitable as a default to base text_alloc() on,
>
>In the latest iteration (v5) it is conditionally available only if arch
>defines and fallback has been removed.
>
>> you went ahead and implemented that anyway, but only cc'ing Peter,
>> akpm, Masami and the mm list this time?
>
>No problems with that. Actually each patch gets everything that
>get_maintainer.pl gives with a cc cmd script, not just the ones
>explicitly listed in the patch.
>
>Should I explicitly CC you to the next version? I'm happy to grow
>the list when requested.
Yes, please CC everybody that was part of the discussion last time
especially during v2, and please use a consistent CC list for the
whole patchset. It is difficult to review when you only receive patch
1 out of 6 with no mention of text_alloc() anywhere and without being
CC'd on the cover letter.
Jessica
next prev parent reply other threads:[~2020-07-24 8:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 9:45 [PATCH v2 0/3] kprobes: Remove MODULE dependency Jarkko Sakkinen
2020-07-14 9:45 ` [PATCH v2 1/3] module: Rename module_alloc() to text_alloc() and move to kernel proper Jarkko Sakkinen
2020-07-14 9:50 ` Russell King - ARM Linux admin
2020-07-14 10:28 ` Will Deacon
2020-07-14 11:29 ` Peter Zijlstra
2020-07-14 12:19 ` Ard Biesheuvel
2020-07-14 13:01 ` Peter Zijlstra
2020-07-14 13:33 ` Mark Rutland
2020-07-14 13:47 ` Ard Biesheuvel
2020-07-14 14:03 ` Steven Rostedt
2020-07-15 5:03 ` Masami Hiramatsu
2020-07-14 16:31 ` Jarkko Sakkinen
2020-07-14 16:46 ` Peter Zijlstra
2020-07-15 8:15 ` David Laight
2020-07-14 16:42 ` Russell King - ARM Linux admin
2020-07-14 12:25 ` Jarkko Sakkinen
2020-07-14 13:56 ` Jessica Yu
2020-07-14 15:44 ` Steven Rostedt
2020-07-14 16:37 ` Jarkko Sakkinen
2020-07-16 16:49 ` Christophe Leroy
2020-07-23 1:51 ` Jarkko Sakkinen
2020-07-23 12:42 ` Ard Biesheuvel
2020-07-24 7:36 ` Jarkko Sakkinen
2020-07-24 8:05 ` Jessica Yu [this message]
2020-07-24 15:46 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200724080508.GA17719@linux-8ccs \
--to=jeyu@kernel$(echo .)org \
--cc=Babu.Moger@amd$(echo .)com \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=ak@linux$(echo .)intel.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=amit.kachhap@arm$(echo .)com \
--cc=anders.roxell@linaro$(echo .)org \
--cc=andriin@fb$(echo .)com \
--cc=anil.s.keshavamurthy@intel$(echo .)com \
--cc=anup.patel@wdc$(echo .)com \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=ardb@kernel$(echo .)org \
--cc=ast@kernel$(echo .)org \
--cc=atish.patra@wdc$(echo .)com \
--cc=bauerman@linux$(echo .)ibm.com \
--cc=ben-linux@fluff$(echo .)org \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=bp@alien8$(echo .)de \
--cc=bpf@vger$(echo .)kernel.org \
--cc=brgerst@gmail$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=damien.lemoal@wdc$(echo .)com \
--cc=daniel@iogearbox$(echo .)net \
--cc=davem@davemloft$(echo .)net \
--cc=deanbo422@gmail$(echo .)com \
--cc=deller@gmx$(echo .)de \
--cc=dhowells@redhat$(echo .)com \
--cc=dja@axtens$(echo .)net \
--cc=duwe@lst$(echo .)de \
--cc=dvyukov@google$(echo .)com \
--cc=elver@google$(echo .)com \
--cc=gor@linux$(echo .)ibm.com \
--cc=green.hu@gmail$(echo .)com \
--cc=gxt@pku$(echo .)edu.cn \
--cc=han_mao@c-sky$(echo .)com \
--cc=heiko.carstens@de$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=jarkko.sakkinen@linux$(echo .)intel.com \
--cc=jkosina@suse$(echo .)cz \
--cc=joe.lawrence@redhat$(echo .)com \
--cc=john.fastabend@gmail$(echo .)com \
--cc=jolsa@redhat$(echo .)com \
--cc=jpoimboe@redhat$(echo .)com \
--cc=kafai@fb$(echo .)com \
--cc=kpsingh@chromium$(echo .)org \
--cc=ley.foon.tan@intel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=luto@kernel$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=masahiroy@kernel$(echo .)org \
--cc=mbenes@suse$(echo .)cz \
--cc=mhiramat@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=naveen.n.rao@linux$(echo .)ibm.com \
--cc=nayna@linux$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=nickhu@andestech$(echo .)com \
--cc=osandov@fb$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=paulburton@kernel$(echo .)org \
--cc=paulmck@kernel$(echo .)org \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=pmladek@suse$(echo .)com \
--cc=prudo@linux$(echo .)ibm.com \
--cc=rostedt@goodmis$(echo .)org \
--cc=rppt@linux$(echo .)ibm.com \
--cc=samitolvanen@google$(echo .)com \
--cc=sandipan@linux$(echo .)ibm.com \
--cc=songliubraving@fb$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=svens@stackframe$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=thuth@redhat$(echo .)com \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=vincent.whitchurch@axis$(echo .)com \
--cc=vincenzo.frascino@arm$(echo .)com \
--cc=wangkefeng.wang@huawei$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=yangtiezhu@loongson$(echo .)cn \
--cc=yhs@fb$(echo .)com \
--cc=yzaikin@google$(echo .)com \
--cc=zong.li@sifive$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox