From: Christoph Hellwig <hch@lst•de>
To: Nicolin Chen <nicoleotsuka@gmail•com>
Cc: linux-ia64@vger•kernel.org,
James.Bottomley@HansenPartnership•com, paulus@samba•org,
hpa@zytor•com, sparclinux@vger•kernel.org,
Christoph Hellwig <hch@lst•de>,
sfr@canb•auug.org.au, deller@gmx•de, x86@kernel•org,
borntraeger@de•ibm.com, mingo@redhat•com, mattst88@gmail•com,
fenghua.yu@intel•com, gor@linux•ibm.com, schnelle@linux•ibm.com,
hca@linux•ibm.com, ink@jurassic•park.msu.ru, tglx@linutronix•de,
gerald.schaefer@linux•ibm.com, rth@twiddle•net,
tony.luck@intel•com, linux-parisc@vger•kernel.org,
linux-s390@vger•kernel.org, linux-kernel@vger•kernel.org,
linux-alpha@vger•kernel.org, bp@alien8•de,
linuxppc-dev@lists•ozlabs.org, davem@davemloft•net
Subject: Re: [RESEND][PATCH 0/7] Avoid overflow at boundary_size
Date: Tue, 1 Sep 2020 11:11:05 +0200 [thread overview]
Message-ID: <20200901091105.GA4959@lst.de> (raw)
In-Reply-To: <20200901075401.GA5667@Asurada-Nvidia>
On Tue, Sep 01, 2020 at 12:54:01AM -0700, Nicolin Chen wrote:
> Hi Christoph,
>
> On Tue, Sep 01, 2020 at 09:36:23AM +0200, Christoph Hellwig wrote:
> > I really don't like all the open coded smarts in the various drivers.
> > What do you think about a helper like the one in the untested patch
>
> A helper function will be actually better. I was thinking of
> one yet not very sure about the naming and where to put it.
>
> > below (on top of your series). Also please include the original
> > segment boundary patch with the next resend so that the series has
> > the full context.
>
> I will use your change instead and resend with the ULONG_MAX
> change. But in that case, should I make separate changes for
> different files like this series, or just one single change
> like yours?
>
> Asking this as I was expecting that those changes would get
> applied by different maintainers. But now it feels like you
> will merge it to your tree at once?
I guess one patch is fine. I can queue it up in the dma-mapping
tree as a prep patch for the default boundary change.
prev parent reply other threads:[~2020-09-01 9:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 20:38 [RESEND][PATCH 0/7] Avoid overflow at boundary_size Nicolin Chen
2020-08-31 20:38 ` [RESEND][PATCH 1/7] powerpc/iommu: " Nicolin Chen
2020-09-01 13:27 ` Michael Ellerman
2020-09-01 20:53 ` Nicolin Chen
2020-08-31 20:38 ` [RESEND][PATCH 2/7] alpha: " Nicolin Chen
2020-08-31 20:38 ` [RESEND][PATCH 3/7] ia64/sba_iommu: " Nicolin Chen
2020-08-31 20:38 ` [RESEND][PATCH 4/7] s390/pci_dma: " Nicolin Chen
2020-08-31 20:38 ` [RESEND][PATCH 5/7] sparc: " Nicolin Chen
2020-08-31 20:38 ` [RESEND][PATCH 6/7] x86/amd_gart: " Nicolin Chen
2020-08-31 20:38 ` [RESEND][PATCH 7/7] parisc: " Nicolin Chen
2020-09-01 7:36 ` [RESEND][PATCH 0/7] " Christoph Hellwig
2020-09-01 7:54 ` Nicolin Chen
2020-09-01 9:11 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200901091105.GA4959@lst.de \
--to=hch@lst$(echo .)de \
--cc=James.Bottomley@HansenPartnership$(echo .)com \
--cc=borntraeger@de$(echo .)ibm.com \
--cc=bp@alien8$(echo .)de \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=fenghua.yu@intel$(echo .)com \
--cc=gerald.schaefer@linux$(echo .)ibm.com \
--cc=gor@linux$(echo .)ibm.com \
--cc=hca@linux$(echo .)ibm.com \
--cc=hpa@zytor$(echo .)com \
--cc=ink@jurassic$(echo .)park.msu.ru \
--cc=linux-alpha@vger$(echo .)kernel.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mattst88@gmail$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=nicoleotsuka@gmail$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=rth@twiddle$(echo .)net \
--cc=schnelle@linux$(echo .)ibm.com \
--cc=sfr@canb$(echo .)auug.org.au \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=tony.luck@intel$(echo .)com \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox