From: Rob Herring <robh@kernel•org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm•com>
Cc: Kunihiko Hayashi <hayashi.kunihiko@socionext•com>,
Neil Armstrong <narmstrong@baylibre•com>,
linux-pci@vger•kernel.org,
Binghui Wang <wangbinghui@hisilicon•com>,
Bjorn Andersson <bjorn.andersson@linaro•org>,
linux-tegra@vger•kernel.org,
Thierry Reding <thierry.reding@gmail•com>,
linux-arm-kernel@axis•com,
Thomas Petazzoni <thomas.petazzoni@bootlin•com>,
Jonathan Chocron <jonnyc@amazon•com>,
Shawn Guo <shawnguo@kernel•org>,
Jonathan Hunter <jonathanh@nvidia•com>,
Fabio Estevam <festevam@gmail•com>,
Jerome Brunet <jbrunet@baylibre•com>,
Jesper Nilsson <jesper.nilsson@axis•com>,
linux-samsung-soc@vger•kernel.org,
Minghuan Lian <minghuan.Lian@nxp•com>,
Kevin Hilman <khilman@baylibre•com>,
Pratyush Anand <pratyush.anand@gmail•com>,
Krzysztof Kozlowski <krzk@kernel•org>,
Kishon Vijay Abraham I <kishon@ti•com>,
Kukjin Kim <kgene@kernel•org>, NXP Linux Team <linux-imx@nxp•com>,
Xiaowei Song <songxiaowei@hisilicon•com>,
Richard Zhu <hongxing.zhu@nxp•com>,
Martin Blumenstingl <martin.blumenstingl@googlemail•com>,
linux-arm-msm@vger•kernel.org,
Sascha Hauer <s.hauer@pengutronix•de>,
Yue Wang <yue.wang@Amlogic•com>,
Murali Karicheri <m-karicheri2@ti•com>,
Bjorn Helgaas <bhelgaas@google•com>,
linux-amlogic@lists•infradead.org, linux-omap@vger•kernel.org,
Mingkai Hu <mingkai.hu@nxp•com>, Roy Zang <roy.zang@nxp•com>,
Masahiro Yamada <yamada.masahiro@socionext•com>,
Jingoo Han <jingoohan1@gmail•com>, Andy Gross <agross@kernel•org>,
Stanimir Varbanov <svarbanov@mm-sol•com>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Gustavo Pimentel <gustavo.pimentel@synopsys•com>,
linuxppc-dev@lists•ozlabs.org,
Lucas Stach <l.stach@pengutronix•de>
Subject: [PATCH 01/13] PCI: dwc/imx6: Drop setting PCI_MSI_FLAGS_ENABLE
Date: Wed, 28 Oct 2020 15:46:34 -0500 [thread overview]
Message-ID: <20201028204646.356535-2-robh@kernel.org> (raw)
In-Reply-To: <20201028204646.356535-1-robh@kernel.org>
No other host driver sets the PCI_MSI_FLAGS_ENABLE bit, so it must not
be necessary. If it is, a comment is needed.
Cc: Richard Zhu <hongxing.zhu@nxp•com>
Cc: Lucas Stach <l.stach@pengutronix•de>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm•com>
Cc: Bjorn Helgaas <bhelgaas@google•com>
Cc: Shawn Guo <shawnguo@kernel•org>
Cc: Sascha Hauer <s.hauer@pengutronix•de>
Cc: Pengutronix Kernel Team <kernel@pengutronix•de>
Cc: Fabio Estevam <festevam@gmail•com>
Cc: NXP Linux Team <linux-imx@nxp•com>
Signed-off-by: Rob Herring <robh@kernel•org>
---
drivers/pci/controller/dwc/pci-imx6.c | 8 --------
1 file changed, 8 deletions(-)
diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c
index 5cf1ef12fb9b..7dd137d62dca 100644
--- a/drivers/pci/controller/dwc/pci-imx6.c
+++ b/drivers/pci/controller/dwc/pci-imx6.c
@@ -1002,7 +1002,6 @@ static int imx6_pcie_probe(struct platform_device *pdev)
struct resource *dbi_base;
struct device_node *node = dev->of_node;
int ret;
- u16 val;
imx6_pcie = devm_kzalloc(dev, sizeof(*imx6_pcie), GFP_KERNEL);
if (!imx6_pcie)
@@ -1167,13 +1166,6 @@ static int imx6_pcie_probe(struct platform_device *pdev)
if (ret < 0)
return ret;
- if (pci_msi_enabled()) {
- u8 offset = dw_pcie_find_capability(pci, PCI_CAP_ID_MSI);
- val = dw_pcie_readw_dbi(pci, offset + PCI_MSI_FLAGS);
- val |= PCI_MSI_FLAGS_ENABLE;
- dw_pcie_writew_dbi(pci, offset + PCI_MSI_FLAGS, val);
- }
-
return 0;
}
--
2.25.1
next prev parent reply other threads:[~2020-10-28 20:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 20:46 [PATCH 00/13] PCI: dwc: Another round of clean-ups Rob Herring
2020-10-28 20:46 ` Rob Herring [this message]
2020-10-29 0:21 ` [PATCH 01/13] PCI: dwc/imx6: Drop setting PCI_MSI_FLAGS_ENABLE Michael Ellerman
2020-10-29 13:01 ` Rob Herring
2020-10-28 20:46 ` [PATCH 02/13] PCI: dwc/intel-gw: Move ATU offset out of driver match data Rob Herring
2020-10-28 20:46 ` [PATCH 03/13] PCI: dwc: Move "dbi", "dbi2", and "addr_space" resource setup into common code Rob Herring
2020-10-29 22:09 ` Jingoo Han
2020-10-28 20:46 ` [PATCH 04/13] PCI: dwc/intel-gw: Remove some unneeded function wrappers Rob Herring
2020-10-28 20:46 ` [PATCH 05/13] PCI: dwc: Ensure all outbound ATU windows are reset Rob Herring
2020-10-29 22:12 ` Jingoo Han
2020-10-28 20:46 ` [PATCH 06/13] PCI: dwc/dra7xx: Use the common MSI irq_chip Rob Herring
2020-10-28 20:46 ` [PATCH 07/13] PCI: dwc: Drop the .set_num_vectors() host op Rob Herring
2020-10-29 22:15 ` Jingoo Han
2020-10-28 20:46 ` [PATCH 08/13] PCI: dwc: Move MSI interrupt setup into DWC common code Rob Herring
2020-10-29 22:18 ` Jingoo Han
2020-10-28 20:46 ` [PATCH 09/13] PCI: dwc: Rework MSI initialization Rob Herring
2020-10-29 22:20 ` Jingoo Han
2020-10-28 20:46 ` [PATCH 10/13] PCI: dwc: Move link handling into common code Rob Herring
2020-10-29 22:24 ` Jingoo Han
2020-10-28 20:46 ` [PATCH 11/13] PCI: dwc: Move dw_pcie_msi_init() into core Rob Herring
2020-10-29 22:26 ` Jingoo Han
2020-10-28 20:46 ` [PATCH 12/13] PCI: dwc: Move dw_pcie_setup_rc() to DWC common code Rob Herring
2020-10-29 22:29 ` Jingoo Han
2020-10-28 20:46 ` [PATCH 13/13] PCI: dwc: Remove unnecessary wrappers around dw_pcie_host_init() Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028204646.356535-2-robh@kernel.org \
--to=robh@kernel$(echo .)org \
--cc=agross@kernel$(echo .)org \
--cc=bhelgaas@google$(echo .)com \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=festevam@gmail$(echo .)com \
--cc=gustavo.pimentel@synopsys$(echo .)com \
--cc=hayashi.kunihiko@socionext$(echo .)com \
--cc=hongxing.zhu@nxp$(echo .)com \
--cc=jbrunet@baylibre$(echo .)com \
--cc=jesper.nilsson@axis$(echo .)com \
--cc=jingoohan1@gmail$(echo .)com \
--cc=jonathanh@nvidia$(echo .)com \
--cc=jonnyc@amazon$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=kgene@kernel$(echo .)org \
--cc=khilman@baylibre$(echo .)com \
--cc=kishon@ti$(echo .)com \
--cc=krzk@kernel$(echo .)org \
--cc=l.stach@pengutronix$(echo .)de \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@axis$(echo .)com \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-pci@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=linux-tegra@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=m-karicheri2@ti$(echo .)com \
--cc=martin.blumenstingl@googlemail$(echo .)com \
--cc=minghuan.Lian@nxp$(echo .)com \
--cc=mingkai.hu@nxp$(echo .)com \
--cc=narmstrong@baylibre$(echo .)com \
--cc=pratyush.anand@gmail$(echo .)com \
--cc=roy.zang@nxp$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=songxiaowei@hisilicon$(echo .)com \
--cc=svarbanov@mm-sol$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=wangbinghui@hisilicon$(echo .)com \
--cc=yamada.masahiro@socionext$(echo .)com \
--cc=yue.wang@Amlogic$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox