From: Miquel Raynal <miquel.raynal@bootlin•com>
To: Lee Jones <lee.jones@linaro•org>
Cc: vigneshr@ti•com, linux-kernel@vger•kernel.org,
Paul Mackerras <paulus@samba•org>,
Richard Weinberger <richard@nod•at>,
linux-mtd@lists•infradead.org, linuxppc-dev@lists•ozlabs.org,
Cyril Bur <cyril.bur@au1•ibm.com>
Subject: Re: [PATCH 23/23] mtd: devices: powernv_flash: Add function names to headers and fix 'dev'
Date: Mon, 2 Nov 2020 13:52:37 +0100 [thread overview]
Message-ID: <20201102135237.7a03b817@xps13> (raw)
In-Reply-To: <20201102115406.1074327-24-lee.jones@linaro.org>
Hi Lee,
Lee Jones <lee.jones@linaro•org> wrote on Mon, 2 Nov 2020 11:54:06
+0000:
> Fixes the following W=1 kernel build warning(s):
>
> drivers/mtd/devices/powernv_flash.c:129: warning: Cannot understand * @mtd: the device
> drivers/mtd/devices/powernv_flash.c:145: warning: Cannot understand * @mtd: the device
> drivers/mtd/devices/powernv_flash.c:161: warning: Cannot understand * @mtd: the device
> drivers/mtd/devices/powernv_flash.c:184: warning: Function parameter or member 'dev' not described in 'powernv_flash_set_driver_info'
>
> Cc: Miquel Raynal <miquel.raynal@bootlin•com>
> Cc: Richard Weinberger <richard@nod•at>
> Cc: Vignesh Raghavendra <vigneshr@ti•com>
> Cc: Michael Ellerman <mpe@ellerman•id.au>
> Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> Cc: Paul Mackerras <paulus@samba•org>
> Cc: Cyril Bur <cyril.bur@au1•ibm.com>
> Cc: linux-mtd@lists•infradead.org
> Cc: linuxppc-dev@lists•ozlabs.org
> Signed-off-by: Lee Jones <lee.jones@linaro•org>
> ---
> drivers/mtd/devices/powernv_flash.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/devices/powernv_flash.c b/drivers/mtd/devices/powernv_flash.c
> index 0b757d9ba2f6b..32cb0e649096f 100644
> --- a/drivers/mtd/devices/powernv_flash.c
> +++ b/drivers/mtd/devices/powernv_flash.c
> @@ -126,6 +126,8 @@ static int powernv_flash_async_op(struct mtd_info *mtd, enum flash_op op,
> }
>
> /**
> + * powernv_flash_read
> + *
Perhaps we should not add blank lines if the rest of the file does not
already have such spacing (see below).
> * @mtd: the device
> * @from: the offset to read from
> * @len: the number of bytes to read
> @@ -142,6 +144,7 @@ static int powernv_flash_read(struct mtd_info *mtd, loff_t from, size_t len,
> }
>
> /**
> + * powernv_flash_write
> * @mtd: the device
> * @to: the offset to write to
> * @len: the number of bytes to write
> @@ -158,6 +161,7 @@ static int powernv_flash_write(struct mtd_info *mtd, loff_t to, size_t len,
> }
>
> /**
> + * powernv_flash_erase
> * @mtd: the device
> * @erase: the erase info
> * Returns 0 if erase successful or -ERRNO if an error occurred
> @@ -176,7 +180,7 @@ static int powernv_flash_erase(struct mtd_info *mtd, struct erase_info *erase)
>
> /**
> * powernv_flash_set_driver_info - Fill the mtd_info structure and docg3
> - * structure @pdev: The platform device
> + * @dev: The device structure
> * @mtd: The structure to fill
> */
> static int powernv_flash_set_driver_info(struct device *dev,
Thanks,
Miquèl
prev parent reply other threads:[~2020-11-02 12:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201102115406.1074327-1-lee.jones@linaro.org>
2020-11-02 11:54 ` [PATCH 23/23] mtd: devices: powernv_flash: Add function names to headers and fix 'dev' Lee Jones
2020-11-02 12:52 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102135237.7a03b817@xps13 \
--to=miquel.raynal@bootlin$(echo .)com \
--cc=cyril.bur@au1$(echo .)ibm.com \
--cc=lee.jones@linaro$(echo .)org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
--cc=richard@nod$(echo .)at \
--cc=vigneshr@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox