From: Lee Jones <lee.jones@linaro•org>
To: Christophe Leroy <christophe.leroy@csgroup•eu>
Cc: Paul Mackerras <paulus@samba•org>,
linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH 31/36] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location
Date: Thu, 5 Nov 2020 08:38:44 +0000 [thread overview]
Message-ID: <20201105083844.GX4488@dell> (raw)
In-Reply-To: <d2a23842-631e-cd5e-84ec-48485328ba52@csgroup.eu>
On Thu, 05 Nov 2020, Christophe Leroy wrote:
>
>
> Le 04/11/2020 à 20:35, Lee Jones a écrit :
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/tty/hvc/hvc_vio.c:385:13: warning: no previous prototype for ‘hvc_vio_init_early’ [-Wmissing-prototypes]
> > 385 | void __init hvc_vio_init_early(void)
> > | ^~~~~~~~~~~~~~~~~~
> >
> > Cc: Michael Ellerman <mpe@ellerman•id.au>
> > Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> > Cc: Paul Mackerras <paulus@samba•org>
> > Cc: linuxppc-dev@lists•ozlabs.org
> > Signed-off-by: Lee Jones <lee.jones@linaro•org>
> > ---
> > arch/powerpc/include/asm/hvconsole.h | 3 +++
> > arch/powerpc/platforms/pseries/pseries.h | 3 ---
> > arch/powerpc/platforms/pseries/setup.c | 1 +
> > 3 files changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/powerpc/include/asm/hvconsole.h b/arch/powerpc/include/asm/hvconsole.h
> > index 999ed5ac90531..936a1ee1ac786 100644
> > --- a/arch/powerpc/include/asm/hvconsole.h
> > +++ b/arch/powerpc/include/asm/hvconsole.h
> > @@ -24,5 +24,8 @@
> > extern int hvc_get_chars(uint32_t vtermno, char *buf, int count);
> > extern int hvc_put_chars(uint32_t vtermno, const char *buf, int count);
> > +/* Provided by HVC VIO */
> > +extern void hvc_vio_init_early(void);
> > +
>
> Declaring a prototype 'extern' is pointless. Don't add new misuse of 'extern' keyword.
No new code (misuse or otherwise) is being added in this patch.
It's just moved from one place to another.
I can also strip out 'extern' if it's preferred.
> > #endif /* __KERNEL__ */
> > #endif /* _PPC64_HVCONSOLE_H */
> > diff --git a/arch/powerpc/platforms/pseries/pseries.h b/arch/powerpc/platforms/pseries/pseries.h
> > index 13fa370a87e4e..7be5b054dfc36 100644
> > --- a/arch/powerpc/platforms/pseries/pseries.h
> > +++ b/arch/powerpc/platforms/pseries/pseries.h
> > @@ -43,9 +43,6 @@ extern void pSeries_final_fixup(void);
> > /* Poweron flag used for enabling auto ups restart */
> > extern unsigned long rtas_poweron_auto;
> > -/* Provided by HVC VIO */
> > -extern void hvc_vio_init_early(void);
> > -
> > /* Dynamic logical Partitioning/Mobility */
> > extern void dlpar_free_cc_nodes(struct device_node *);
> > extern void dlpar_free_cc_property(struct property *);
> > diff --git a/arch/powerpc/platforms/pseries/setup.c b/arch/powerpc/platforms/pseries/setup.c
> > index 633c45ec406da..6999b83f06612 100644
> > --- a/arch/powerpc/platforms/pseries/setup.c
> > +++ b/arch/powerpc/platforms/pseries/setup.c
> > @@ -71,6 +71,7 @@
> > #include <asm/swiotlb.h>
> > #include <asm/svm.h>
> > #include <asm/dtl.h>
> > +#include <asm/hvconsole.h>
> > #include "pseries.h"
> > #include "../../../../drivers/pci/pci.h"
> >
>
> Christophe
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-11-05 8:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 19:35 [PATCH 00/36] Rid W=1 issues from TTY Lee Jones
2020-11-04 19:35 ` [PATCH 31/36] powerpc: asm: hvconsole: Move 'hvc_vio_init_early's prototype to shared location Lee Jones
2020-11-04 23:36 ` Michael Ellerman
2020-11-05 8:39 ` Lee Jones
2020-11-05 7:10 ` Christophe Leroy
2020-11-05 8:38 ` Lee Jones [this message]
2020-11-26 9:36 ` [PATCH v2 " Lee Jones
2020-11-04 19:35 ` [PATCH 32/36] tty: hvc: hvc_vio: Staticify function invoked only by reference Lee Jones
2020-11-04 19:35 ` [PATCH 33/36] tty: hvc: hvc_opal: Staticify function invoked " Lee Jones
2020-11-04 19:35 ` [PATCH 34/36] tty: serial: pmac_zilog: Make disposable variable __always_unused Lee Jones
2020-11-05 7:04 ` Christophe Leroy
2020-11-05 7:39 ` Jiri Slaby
2020-11-05 8:36 ` Lee Jones
2020-11-05 8:55 ` Jiri Slaby
2020-11-05 9:00 ` Lee Jones
2020-11-06 9:54 ` [PATCH 00/36] Rid W=1 issues from TTY Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105083844.GX4488@dell \
--to=lee.jones@linaro$(echo .)org \
--cc=christophe.leroy@csgroup$(echo .)eu \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=paulus@samba$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox