public inbox for linuxppc-dev@ozlabs.org 
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@kernel•org>
To: Timur Tabi <timur@kernel•org>,
	Nicolin Chen <nicoleotsuka@gmail•com>,
	Xiubo Li <Xiubo.Lee@gmail•com>,
	Liam Girdwood <lgirdwood@gmail•com>,
	Mark Brown <broonie@kernel•org>, Jaroslav Kysela <perex@perex•cz>,
	Takashi Iwai <tiwai@suse•com>,
	Shengjiu Wang <shengjiu.wang@nxp•com>
Cc: alsa-devel@alsa-project•org, Arnd Bergmann <arnd@arndb•de>,
	Fabio Estevam <festevam@gmail•com>,
	linuxppc-dev@lists•ozlabs.org, linux-kernel@vger•kernel.org,
	Shengjiu Wang <shengjiu.wang@gmail•com>
Subject: [PATCH] ASoC: fsl_aud2htx: mark PM functions as __maybe_unused
Date: Thu,  3 Dec 2020 23:28:47 +0100	[thread overview]
Message-ID: <20201203222900.1042578-1-arnd@kernel.org> (raw)

From: Arnd Bergmann <arnd@arndb•de>

When CONFIG_PM is disabled, we get a warning for unused functions:

sound/soc/fsl/fsl_aud2htx.c:261:12: error: unused function 'fsl_aud2htx_runtime_suspend' [-Werror,-Wunused-function]
static int fsl_aud2htx_runtime_suspend(struct device *dev)
sound/soc/fsl/fsl_aud2htx.c:271:12: error: unused function 'fsl_aud2htx_runtime_resume' [-Werror,-Wunused-function]
static int fsl_aud2htx_runtime_resume(struct device *dev)

Mark these as __maybe_unused to avoid the warning without adding
an #ifdef.

Fixes: 8a24c834c053 ("ASoC: fsl_aud2htx: Add aud2htx module driver")
Signed-off-by: Arnd Bergmann <arnd@arndb•de>
---
 sound/soc/fsl/fsl_aud2htx.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/fsl/fsl_aud2htx.c b/sound/soc/fsl/fsl_aud2htx.c
index 4091ccc7c3e9..d70d5e75a30c 100644
--- a/sound/soc/fsl/fsl_aud2htx.c
+++ b/sound/soc/fsl/fsl_aud2htx.c
@@ -258,7 +258,7 @@ static int fsl_aud2htx_remove(struct platform_device *pdev)
 	return 0;
 }
 
-static int fsl_aud2htx_runtime_suspend(struct device *dev)
+static int __maybe_unused fsl_aud2htx_runtime_suspend(struct device *dev)
 {
 	struct fsl_aud2htx *aud2htx = dev_get_drvdata(dev);
 
@@ -268,7 +268,7 @@ static int fsl_aud2htx_runtime_suspend(struct device *dev)
 	return 0;
 }
 
-static int fsl_aud2htx_runtime_resume(struct device *dev)
+static int __maybe_unused fsl_aud2htx_runtime_resume(struct device *dev)
 {
 	struct fsl_aud2htx *aud2htx = dev_get_drvdata(dev);
 	int ret;
-- 
2.27.0


             reply	other threads:[~2020-12-03 22:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03 22:28 Arnd Bergmann [this message]
2020-12-03 22:36 ` [PATCH] ASoC: fsl_aud2htx: mark PM functions as __maybe_unused Nicolin Chen
2020-12-04 23:30 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201203222900.1042578-1-arnd@kernel.org \
    --to=arnd@kernel$(echo .)org \
    --cc=Xiubo.Lee@gmail$(echo .)com \
    --cc=alsa-devel@alsa-project$(echo .)org \
    --cc=arnd@arndb$(echo .)de \
    --cc=broonie@kernel$(echo .)org \
    --cc=festevam@gmail$(echo .)com \
    --cc=lgirdwood@gmail$(echo .)com \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linuxppc-dev@lists$(echo .)ozlabs.org \
    --cc=nicoleotsuka@gmail$(echo .)com \
    --cc=perex@perex$(echo .)cz \
    --cc=shengjiu.wang@gmail$(echo .)com \
    --cc=shengjiu.wang@nxp$(echo .)com \
    --cc=timur@kernel$(echo .)org \
    --cc=tiwai@suse$(echo .)com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox