From: Sukadev Bhattiprolu <sukadev@linux•ibm.com>
To: "Uwe Kleine-König" <uwe@kleine-koenig•org>
Cc: "Tyrel Datwyler" <tyreld@linux•ibm.com>,
"Cristobal Forno" <cforno12@linux•ibm.com>,
sparclinux@vger•kernel.org, target-devel@vger•kernel.org,
"Paul Mackerras" <paulus@samba•org>,
"Breno Leitão" <leitao@debian•org>,
"Peter Huewe" <peterhuewe@gmx•de>,
"Jiri Slaby" <jirislaby@kernel•org>,
"Herbert Xu" <herbert@gondor•apana.org.au>,
linux-scsi@vger•kernel.org, "Nayna Jain" <nayna@linux•ibm.com>,
"Jason Gunthorpe" <jgg@ziepe•ca>,
"Michael Cyr" <mikecyr@linux•ibm.com>,
"Jakub Kicinski" <kuba@kernel•org>,
"Arnd Bergmann" <arnd@arndb•de>,
"James E.J. Bottomley" <jejb@linux•ibm.com>,
linux-block@vger•kernel.org, "Lijun Pan" <ljp@linux•ibm.com>,
"Matt Mackall" <mpm@selenic•com>, "Jens Axboe" <axboe@kernel•dk>,
"Steven Royer" <seroyer@linux•ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle•com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation•org>,
linux-kernel@vger•kernel.org,
"Jarkko Sakkinen" <jarkko@kernel•org>,
linux-crypto@vger•kernel.org, netdev@vger•kernel.org,
"Dany Madden" <drt@linux•ibm.com>,
"Paulo Flabiano Smorigo" <pfsmorigo@gmail•com>,
linux-integrity@vger•kernel.org, linuxppc-dev@lists•ozlabs.org,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH] vio: make remove callback return void
Date: Thu, 28 Jan 2021 11:07:50 -0800 [thread overview]
Message-ID: <20210128190750.GA490196@us.ibm.com> (raw)
In-Reply-To: <20210127215010.99954-1-uwe@kleine-koenig.org>
Uwe Kleine-König [uwe@kleine-koenig•org] wrote:
> The driver core ignores the return value of struct bus_type::remove()
> because there is only little that can be done. To simplify the quest to
> make this function return void, let struct vio_driver::remove() return
> void, too. All users already unconditionally return 0, this commit makes
> it obvious that returning an error code is a bad idea and makes it
> obvious for future driver authors that returning an error code isn't
> intended.
Slightly off-topic, should ndo_stop() also return a void? Its return value
seems to be mostly ignored and __dev_close_many() has:
/*
* Call the device specific close. This cannot fail.
* Only if device is UP
*
* We allow it to be called even after a DETACH hot-plug
* event.
*/
if (ops->ndo_stop)
ops->ndo_stop(dev);
Sukadev
next prev parent reply other threads:[~2021-01-28 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 21:50 [PATCH] vio: make remove callback return void Uwe Kleine-König
2021-01-28 19:07 ` Sukadev Bhattiprolu [this message]
2021-01-28 20:08 ` Uwe Kleine-König
2021-01-29 18:58 ` Tyrel Datwyler
2021-01-29 19:08 ` Lijun Pan
2021-02-04 16:08 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210128190750.GA490196@us.ibm.com \
--to=sukadev@linux$(echo .)ibm.com \
--cc=arnd@arndb$(echo .)de \
--cc=axboe@kernel$(echo .)dk \
--cc=cforno12@linux$(echo .)ibm.com \
--cc=davem@davemloft$(echo .)net \
--cc=drt@linux$(echo .)ibm.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=herbert@gondor$(echo .)apana.org.au \
--cc=jarkko@kernel$(echo .)org \
--cc=jejb@linux$(echo .)ibm.com \
--cc=jgg@ziepe$(echo .)ca \
--cc=jirislaby@kernel$(echo .)org \
--cc=kuba@kernel$(echo .)org \
--cc=leitao@debian$(echo .)org \
--cc=linux-block@vger$(echo .)kernel.org \
--cc=linux-crypto@vger$(echo .)kernel.org \
--cc=linux-integrity@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-scsi@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=ljp@linux$(echo .)ibm.com \
--cc=martin.petersen@oracle$(echo .)com \
--cc=mikecyr@linux$(echo .)ibm.com \
--cc=mpm@selenic$(echo .)com \
--cc=nayna@linux$(echo .)ibm.com \
--cc=netdev@vger$(echo .)kernel.org \
--cc=paulus@samba$(echo .)org \
--cc=peterhuewe@gmx$(echo .)de \
--cc=pfsmorigo@gmail$(echo .)com \
--cc=seroyer@linux$(echo .)ibm.com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=target-devel@vger$(echo .)kernel.org \
--cc=tyreld@linux$(echo .)ibm.com \
--cc=uwe@kleine-koenig$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox